Skip to contentSkip to conversation

Cgroup: needs to mount to /sys/fs/cgroup.

PATCH New Dominick Grift 3 participants 4 messages Oct 8, 2010 – Oct 11, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Cgroup: needs to mount to /sys/fs/cgroup.

I am not sure why libcgroup is moving locations for cgroupfs. Seems they now use /cgroup again, where they were using /sys/fs/cgroup a version before.

But since we added initial support for /sys/fs/cgroup, we might as well make that work i guess.

---
:100644 100644 99482ca... ab8b7aa... M policy/modules/kernel/devices.if
:100644 100644 59bae6a... f0cce08... M policy/modules/kernel/filesystem.fc
:100644 100644 0dff98e... d5b1551... M policy/modules/kernel/filesystem.te

 policy/modules/kernel/devices.if    |   18 ++++++++++++++++++
 policy/modules/kernel/filesystem.fc |    4 +++-
 policy/modules/kernel/filesystem.te |    1 +
 3 files changed, 22 insertions(+), 1 deletions(-)
policy/modules/kernel/devices.if +18 -0
index 99482ca..ab8b7aa 100644
@@ -3613,6 +3613,24 @@ interface(`dev_manage_smartcard',`
 
 ########################################
 ## <summary>
+##	Associate to sysfs filesystems.
+## </summary>
+## <param name="file_type">
+##	<summary>
+##	Type to be associated.
+##	</summary>
+## </param>
+#
+interface(`dev_associate_sysfs',`
+	gen_require(`
+		type sysfs_t;
+	')
+
+	allow $1 sysfs_t:filesystem associate;
+')
+
+########################################
+## <summary>
 ##	Get the attributes of sysfs directories.
 ## </summary>
 ## <param name="domain">
policy/modules/kernel/filesystem.fc +3 -1
index 59bae6a..f0cce08 100644
@@ -2,5 +2,7 @@
 /dev/shm/.*		<<none>>
 
 /cgroup		-d	gen_context(system_u:object_r:cgroup_t,s0)
+/cgroup/.*	<<none>>
 
-/sys/fs/cgroup(/.*)?	<<none>>
+/sys/fs/cgroup	-d	gen_context(system_u:object_r:cgroup_t,s0)
+/sys/fs/cgroup/.*	<<none>>
policy/modules/kernel/filesystem.te +1 -0
index 0dff98e..d5b1551 100644
@@ -71,6 +71,7 @@ type cgroup_t;
 fs_type(cgroup_t)
 files_type(cgroup_t)
 files_mountpoint(cgroup_t)
+dev_associate_sysfs(cgroup_t)
 genfscon cgroup / gen_context(system_u:object_r:cgroup_t,s0)
 
 type configfs_t;
Signature · 9 lines
1.7.2.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://oss.tresys.com/pipermail/refpolicy/attachments/20101008/b643373b/attachment.bin 
#2 lore raw

PATCH 1/1 Cgroup: needs to mount to /sys/fs/cgroup.

Quoted 10 lines · Paul Howarth
Quoted 3 lines · On Fri, 8 Oct 2010 23:28:01 +0200 Dominick Grift<[email protected]> wrote:

I am not sure why libcgroup is moving locations for cgroupfs. Seems they now use /cgroup again, where they were using /sys/fs/cgroup a version before.

https://bugzilla.redhat.com/show_bug.cgi?id=640282

It'll move back again for F-15.

I'm going to pass on this change for now.

Signature · 3 lines
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
#3 lore raw

PATCH 1/1 Cgroup: needs to mount to /sys/fs/cgroup.

Quoted 8 lines · Christopher J. PeBenito
Quoted 7 lines · Paul Howarth
Quoted 3 lines · On Fri, 8 Oct 2010 23:28:01 +0200 Dominick Grift<[email protected]> wrote:

I am not sure why libcgroup is moving locations for cgroupfs. Seems they now use /cgroup again, where they were using /sys/fs/cgroup a version before.

Quoted 5 lines
Quoted 3 lines

https://bugzilla.redhat.com/show_bug.cgi?id=640282

It'll move back again for F-15.

I'm going to pass on this change for now.

Good call, it wont work anyways. sysfs is a pseudo fs so type cgroup_t for /sys/fs/cgroup wont apply at boot.
So if they move to that location we either need to allow libcgroup to mounon sysfs_t or it needs some magic in the kernel to label that dir cgroup_t.

But thats for f15..

i do have some cgroup related patches in the pipeline for f14 (initrc_t (cgreds and cgconfigs rc scripts need to read their config files :( )

Quoted 9 lines
Signature · 8 lines
-- 
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
_______________________________________________
refpolicy mailing list
refpolicy at oss.tresys.com
http://oss.tresys.com/mailman/listinfo/refpolicy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://oss.tresys.com/pipermail/refpolicy/attachments/20101011/9c25361f/attachment.bin