Skip to contentSkip to conversation

cfi_flash: Fix "Unknown FLASH" error message

PATCH New Peter Tyser 2 participants 2 messages Sep 29, 2010 – Oct 12, 2010 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cfi_flash: Fix "Unknown FLASH" error message

From: John Schmoller <[email protected]>

When a CFI flash chip could not be detected an error message similar to the following would be printed on bootup:

FLASH: ## Unknown FLASH on Bank 1 - Size = 0x01000000 = 0 MB

The printf incorrectly converted the flash size into megabytes. This patch fixes the printing of the flash size in megabytes:

FLASH: ## Unknown FLASH on Bank 1 - Size = 0x01000000 = 16 MB

---
 drivers/mtd/cfi_flash.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/cfi_flash.c +1 -1
index 02dd27f..798902f 100644
@@ -2033,7 +2033,7 @@ unsigned long flash_init (void)
 			printf ("## Unknown FLASH on Bank %d "
 				"- Size = 0x%08lx = %ld MB\n",
 				i+1, flash_info[i].size,
-				flash_info[i].size << 20);
+				flash_info[i].size >> 20);
 #endif /* CONFIG_SYS_FLASH_QUIET_TEST */
 		}
 #ifdef CONFIG_SYS_FLASH_PROTECTION
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 cfi_flash: Fix "Unknown FLASH" error message

Quoted 11 lines · On Wednesday 29 September 2010 20:49:05 Peter Tyser wrote:

From: John Schmoller <[email protected]>

When a CFI flash chip could not be detected an error message similar to the following would be printed on bootup:

FLASH: ## Unknown FLASH on Bank 1 - Size = 0x01000000 = 0 MB

The printf incorrectly converted the flash size into megabytes. This patch fixes the printing of the flash size in megabytes:

FLASH: ## Unknown FLASH on Bank 1 - Size = 0x01000000 = 16 MB

Applied to u-boot-cfi-flash/master. Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de