cp/cmp: Add WATCHDOG_RESET in copy and compare loop
PATCH v3 1/1 cp/cmp: Add WATCHDOG_RESET in copy and compare loop
On some boards with a very short watchdog timeout, the "cp" and "cmp" commands may reset the board. This patch adds some watchdog resets inside the loops. Otherwise for example the lwmon5 board will reset while doing something like this:
=> cp.b fc000000 1000000 100000
---
v3
- Increased loop count as suggested by Wolfgang
(256k still resets the lwmon5 board)
v2:
- Changed to power of 2 value to simplify the resulting code, 4096 seems to be enough for lwmon5.
common/cmd_mem.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
common/cmd_mem.c +8 -0
@@ -337,6 +337,10 @@ int do_mem_cmp (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) ngood++; addr1 += size; addr2 += size; + +/* reset watchdog from time to time */ +if ((count % (64 <<10 )) ==0 ) +WATCHDOG_RESET (); } printf("Total of %ld %s%s were the same\n",
@@ -447,6 +451,10 @@ int do_mem_cp ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) *((u_char *)dest) = *((u_char *)addr); addr += size; dest += size; + +/* reset watchdog from time to time */ +if ((count % (64 <<10 )) ==0 ) +WATCHDOG_RESET (); }return 0 ; }
Signature · 1 line
1.7.2.3
Wolfgang Denk
AppliedPATCH v3 1/1 cp/cmp: Add WATCHDOG_RESET in copy and compare loop
Dear Stefan Roese,
Quoted 13 lines · In message <[email protected]> you wrote:
On some boards with a very short watchdog timeout, the "cp" and "cmp" commands may reset the board. This patch adds some watchdog resets inside the loops. Otherwise for example the lwmon5 board will reset while doing something like this:
=> cp.b
fc0000001000000 100000Signed-off-by Stefan Roese <[email protected]>---
v3
- Increased loop count as suggested by Wolfgang
(256k still resets the lwmon5 board)
Quoted 6 lines
v2:
- Changed to power of 2 value to simplify the resulting code, 4096 seems to be enough for lwmon5.common/cmd_mem.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 9 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Fantasy is like alcohol - too much is bad for you, a little bit makes the world a better place. Like an exercise bicycle it takes you nowhere, but it just might tone up the muscles that will. Daydreaming got us where we are today; early in our evolution we learned to let our minds wander so well that they started coming back with souve- nirs. - Terry Pratchett & Stephen Briggs, _The Discworld Companion_