Skip to contentSkip to conversation

tifm: fix kconfig dependencies

PATCH In review Randy Dunlap 2 participants 2 messages Oct 14, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tifm: fix kconfig dependencies

From: Randy Dunlap <[email protected]>

Fix kconfig dependency warning to satisfy dependencies:

warning: (MMC_TIFM_SD && MMC && EXPERIMENTAL && PCI || MEMSTICK_TIFM_MS && MEMSTICK && EXPERIMENTAL && PCI) selects TIFM_CORE which has unmet direct dependencies (MISC_DEVICES && EXPERIMENTAL && PCI)

---
 drivers/memstick/host/Kconfig |    1 +
 drivers/mmc/host/Kconfig      |    1 +
 2 files changed, 2 insertions(+)
drivers/memstick/host/Kconfig +1 -0
@@ -7,6 +7,7 @@ comment "MemoryStick Host Controller Dri
 config MEMSTICK_TIFM_MS
 	tristate "TI Flash Media MemoryStick Interface support  (EXPERIMENTAL)"
 	depends on EXPERIMENTAL && PCI
+	select MISC_DEVICES
 	select TIFM_CORE
 	help
 	  Say Y here if you want to be able to access MemoryStick cards with
drivers/mmc/host/Kconfig +1 -0
@@ -277,6 +277,7 @@ config MMC_MXC
 config MMC_TIFM_SD
 	tristate "TI Flash Media MMC/SD Interface support  (EXPERIMENTAL)"
 	depends on EXPERIMENTAL && PCI
+	select MISC_DEVICES
 	select TIFM_CORE
 	help
 	  Say Y here if you want to be able to access MMC/SD cards with
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 25 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix kconfig dependency warning to satisfy dependencies:

warning: (MMC_TIFM_SD && MMC && EXPERIMENTAL && PCI || MEMSTICK_TIFM_MS && MEMSTICK && EXPERIMENTAL && PCI) selects TIFM_CORE which has unmet direct dependencies (MISC_DEVICES && EXPERIMENTAL && PCI)

---
 drivers/memstick/host/Kconfig |    1 +
 drivers/mmc/host/Kconfig      |    1 +
 2 files changed, 2 insertions(+)
drivers/memstick/host/Kconfig +1 -0
@@ -7,6 +7,7 @@ comment "MemoryStick Host Controller Dri
 config MEMSTICK_TIFM_MS
 	tristate "TI Flash Media MemoryStick Interface support  (EXPERIMENTAL)"
 	depends on EXPERIMENTAL && PCI
+	select MISC_DEVICES
 	select TIFM_CORE
 	help
 	  Say Y here if you want to be able to access MemoryStick cards with

drivers/mmc/host/Kconfig config MMC_MXC · line 283

Quoted 7 lines
drivers/mmc/host/Kconfig +1 -0
@@ -277,6 +277,7 @@ config MMC_MXC
 config MMC_TIFM_SD
 	tristate "TI Flash Media MMC/SD Interface support  (EXPERIMENTAL)"
 	depends on EXPERIMENTAL && PCI
+	select MISC_DEVICES
 	select TIFM_CORE
 	help
 	  Say Y here if you want to be able to access MMC/SD cards with

for the mmc hunk.

Andrew, perhaps you should take this to keep the mmc/memstick trees from modifying files outside of their namespace? (Or we could just ask Randy to split up the patch; whatever is preferred.)

Thanks,

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child