Skip to contentSkip to conversation

LZO: Add a LZO compression feature

PATCH New Donggeun Kim 2 participants 2 messages Oct 4, 2010 – Oct 13, 2010

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 LZO: Add a LZO compression feature

Changes from V1 to V2:
- Add a configuration option for the LZO compression
- Add a comment line specifying the origin of the source code

In some case, LZO compression function is needed in U-Boot.

This patch supports LZO compression feature which is originated from Linux kernel.

Thanks.
-Donggeun Kim

---
 lib/lzo/Makefile         |    1 +
 lib/lzo/lzo1x_compress.c |  221 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 222 insertions(+), 0 deletions(-)
 create mode 100644 lib/lzo/lzo1x_compress.c
lib/lzo/Makefile +1 -0
index 5dd1bf5..ca2253a 100644
@@ -28,6 +28,7 @@ LIB	= $(obj)liblzo.a
 SOBJS	=
 
 COBJS-$(CONFIG_LZO) += lzo1x_decompress.o
+COBJS-$(CONFIG_LZO_COMPRESSION) += lzo1x_compress.o
 
 COBJS	= $(COBJS-y)
 SRCS 	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
lib/lzo/lzo1x_compress.c new file +221 -0

221 lines not on this page · raw message

Signature · 1 line
1.6.3.3
#1 lore raw

PATCH v2 1/1 LZO: Add a LZO compression feature

Dear Donggeun Kim,

Quoted 3 lines · In message <[email protected]> you wrote:

Changes from V1 to V2:
- Add a configuration option for the LZO compression
- Add a comment line specifying the origin of the source code

These comments must go into the com,ment section, i. e. below the "---" line.

Quoted 3 lines

In some case, LZO compression function is needed in U-Boot.

This patch supports LZO compression feature which is originated from Linux kernel.

Please give exact reference (file name, commit id).

See http://www.denx.de/wiki/U-Boot/Patches for details.

Quoted 7 lines
lib/lzo/lzo1x_compress.c new file +4 -0
@@ -0,0 +1,221 @@
+/*
+ *  LZO1X Compressor from MiniLZO
+ *
+ *  Copyright (C) 1996-2005 Markus F.X.J. Oberhumer <[email protected]>

lib/lzo/lzo1x_compress.c line 14

Quoted 10 lines
lib/lzo/lzo1x_compress.c new file +10 -0
+ *
+ *  The full LZO package can be found at:
+ *  http://www.oberhumer.com/opensource/lzo/
+ *
+ *  Changed for kernel use by:
+ *  Nitin Gupta <[email protected]>
+ *  Richard Purdie <[email protected]>
+ *
+ *  Note : This code is taken from linux kernel.
+ */

I see no user interface (i. e. there is no way to use this function from the command line), and I see no other users (callers) of this code.

As such, it is just dead code, which I will not add.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
On the subject of C program indentation: "In My Egotistical  Opinion,
most  people's  C  programs  should be indented six feet downward and
covered with dirt."                               - Blair P. Houghton