gianfar: fix double lock typo

PATCH In review Dan Carpenter 2 participants 2 messages Oct 13, 2010 – Oct 18, 2010

Subsystems (3)

Networking Network drivers Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-10-13 19:19 UTC #0 lore raw

PATCH 1/1 gianfar: fix double lock typo

This should be a _restore() instead of a _save().

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/gianfar_ethtool.c +1 -1

index ae8e5d3..5c566eb 100644
@@ -538,7 +538,7 @@ static int gfar_set_rx_csum(struct net_device *dev, uint32_t data)
 
 		unlock_tx_qs(priv);
 		unlock_rx_qs(priv);
-		local_irq_save(flags);
+		local_irq_restore(flags);
 
 		for (i = 0; i < priv->num_rx_queues; i++)
 			gfar_clean_rx_ring(priv->rx_queue[i],

David Miller

maintainer

2010-10-18 08:55 UTC #1 lore raw

From: Dan Carpenter <[email protected]>
Date: Wed, 13 Oct 2010 21:19:55 +0200

Quoted 3 lines

This should be a _restore() instead of a _save().
Signed-off-by Dan Carpenter <[email protected]>

Good find, applied, thanks!