Skip to contentSkip to conversation

S3C64XX: Fix special function for IISv4 port

PATCH New Mark Brown 2 participants 4 messages Oct 13, 2010

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 S3C64XX: Fix special function for IISv4 port

When converting to use s3c_gpio_cfgpin_range() the function for the IISv4 block appears to have been typoed as 4 (the keypad) rather than 5 as it should be.

---
 arch/arm/mach-s3c64xx/dev-audio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-s3c64xx/dev-audio.c +1 -1
index e53764e..76426a3 100644
@@ -49,7 +49,7 @@ static int s3c64xx_i2sv4_cfg_gpio(struct platform_device *pdev)
 	s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C_GPIO_SFN(5));
 	s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C_GPIO_SFN(5));
 	s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C_GPIO_SFN(5));
-	s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(4));
+	s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(5));
 
 	return 0;
 }
Signature · 1 line
1.7.1
author
#1 lore raw

PATCH 1/1 S3C64XX: Fix special function for IISv4 port

Quoted 3 lines · Mark Brown

When converting to use s3c_gpio_cfgpin_range() the function for the IISv4 block appears to have been typoed as 4 (the keypad) rather than 5 as it should be.

Sorry about the 2.6.36 in the subject line - this actually only applies to -next.

#2 lore raw

PATCH 1/1 S3C64XX: Fix special function for IISv4 port

Quoted 8 lines · Mark Brown
Quoted 3 lines · Mark Brown

When converting to use s3c_gpio_cfgpin_range() the function for the IISv4 block appears to have been typoed as 4 (the keypad) rather than 5 as it should be.

Sorry about the 2.6.36 in the subject line - this actually only applies to -next.

No problem ;-)
Thanks for your fixing.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#3 lore raw

PATCH 1/1 S3C64XX: Fix special function for IISv4 port

In reply to Mark Brown

Review

Quoted 11 lines · Mark Brown

When converting to use s3c_gpio_cfgpin_range() the function for the IISv4 block appears to have been typoed as 4 (the keypad) rather than 5 as it should be.

---
 arch/arm/mach-s3c64xx/dev-audio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-s3c64xx/dev-

Quoted 13 lines

audio.c
index e53764e..76426a3 100644

arch/arm/mach-s3c64xx/dev-audio.c +1 -1
@@ -49,7 +49,7 @@ static int s3c64xx_i2sv4_cfg_gpio(struct platform_device
 *pdev)
 	s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C_GPIO_SFN(5));
 	s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C_GPIO_SFN(5));
 	s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C_GPIO_SFN(5));
-	s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(4));
+	s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(5));
 
 	return 0;
Quoted 2 lines

}
--

Hi,

According to commit f08269d8, when converting to use s3c_gpio_cfgpin_range() the function, there was no typo.
(Commit f08269d8: ARM: S3C64XX: Change to using s3c_gpio_cfgpin_range())

@@ -51,10 +48,7 @@ static int s3c64xx_i2sv4_cfg_gpio(struct platform_device *pdev)
s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C_GPIO_SFN(5)); s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C_GPIO_SFN(5)); s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C_GPIO_SFN(5));
- s3c_gpio_cfgpin(S3C64XX_GPH(6), S3C_GPIO_SFN(4));
- s3c_gpio_cfgpin(S3C64XX_GPH(7), S3C_GPIO_SFN(4));
- s3c_gpio_cfgpin(S3C64XX_GPH(8), S3C_GPIO_SFN(4));
- s3c_gpio_cfgpin(S3C64XX_GPH(9), S3C_GPIO_SFN(4));
+ s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(4));

return 0;
}

It seems to happen more before...
Anyway, you're right. should be fixed.

Will apply in -next :-)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.