Skip to contentSkip to conversation

spi/fsl_spi: Fix compile errors when building on ppc64

PATCH Applied Kumar Gala 2 participants 4 messages Oct 14, 2010 SPI

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 spi/fsl_spi: Fix compile errors when building on ppc64

We get the following when building on ppc64 due to lack of include of <asm/io.h>:

In file included from drivers/spi/spi_fsl_espi.c:25:0:
drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_write_reg':
drivers/spi/spi_fsl_lib.h:88:2: error: implicit declaration of function 'out_be32' drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_read_reg':
drivers/spi/spi_fsl_lib.h:93:2: error: implicit declaration of function 'in_be32' drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_remove':
drivers/spi/spi_fsl_espi.c:571:2: error: implicit declaration of function 'iounmap' drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_probe':
drivers/spi/spi_fsl_espi.c:602:2: error: implicit declaration of function 'ioremap' drivers/spi/spi_fsl_espi.c:602:24: warning: assignment makes pointer from integer without a cast

---
 drivers/spi/spi_fsl_lib.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/spi/spi_fsl_lib.h +2 -0
index 15aa6c2..281e060 100644
@@ -18,6 +18,8 @@
 #ifndef __SPI_FSL_LIB_H__
 #define __SPI_FSL_LIB_H__
 
+#include <asm/io.h>
+
 /* SPI/eSPI Controller driver's private data. */
 struct mpc8xxx_spi {
 	struct device *dev;
Signature · 1 line
1.7.2.3
#1 lore raw
Quoted 2 lines · Kumar Gala

We get the following when building on ppc64 due to lack of include of <asm/io.h>:

Is this an immediate problem (merge for .36), or is it a linux-next thing?

g.

Quoted 33 lines

In file included from drivers/spi/spi_fsl_espi.c:25:0:
drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_write_reg':
drivers/spi/spi_fsl_lib.h:88:2: error: implicit declaration of function 'out_be32' drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_read_reg':
drivers/spi/spi_fsl_lib.h:93:2: error: implicit declaration of function 'in_be32' drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_remove':
drivers/spi/spi_fsl_espi.c:571:2: error: implicit declaration of function 'iounmap' drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_probe':
drivers/spi/spi_fsl_espi.c:602:2: error: implicit declaration of function 'ioremap' drivers/spi/spi_fsl_espi.c:602:24: warning: assignment makes pointer from integer without a cast

---
 drivers/spi/spi_fsl_lib.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/spi/spi_fsl_lib.h +2 -0
index 15aa6c2..281e060 100644
@@ -18,6 +18,8 @@
 #ifndef __SPI_FSL_LIB_H__
 #define __SPI_FSL_LIB_H__
 
+#include <asm/io.h>
+
 /* SPI/eSPI Controller driver's private data. */
 struct mpc8xxx_spi {
 	struct device *dev;
Signature · 1 line
1.7.2.3
author
#2 lore raw
Quoted 7 lines · Grant Likely
Quoted 2 lines · Kumar Gala

We get the following when building on ppc64 due to lack of include of <asm/io.h>:

Is this an immediate problem (merge for .36), or is it a linux-next thing?

g.

.37 / next is fine.

- k

Applied
#3 lore raw
In reply to Kumar Gala
Quoted 2 lines · Kumar Gala

We get the following when building on ppc64 due to lack of include of <asm/io.h>:

Applied.

g.

Quoted 33 lines

In file included from drivers/spi/spi_fsl_espi.c:25:0:
drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_write_reg':
drivers/spi/spi_fsl_lib.h:88:2: error: implicit declaration of function 'out_be32' drivers/spi/spi_fsl_lib.h: In function 'mpc8xxx_spi_read_reg':
drivers/spi/spi_fsl_lib.h:93:2: error: implicit declaration of function 'in_be32' drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_remove':
drivers/spi/spi_fsl_espi.c:571:2: error: implicit declaration of function 'iounmap' drivers/spi/spi_fsl_espi.c: In function 'fsl_espi_probe':
drivers/spi/spi_fsl_espi.c:602:2: error: implicit declaration of function 'ioremap' drivers/spi/spi_fsl_espi.c:602:24: warning: assignment makes pointer from integer without a cast

---
 drivers/spi/spi_fsl_lib.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/spi/spi_fsl_lib.h +2 -0
index 15aa6c2..281e060 100644
@@ -18,6 +18,8 @@
 #ifndef __SPI_FSL_LIB_H__
 #define __SPI_FSL_LIB_H__
 
+#include <asm/io.h>
+
 /* SPI/eSPI Controller driver's private data. */
 struct mpc8xxx_spi {
 	struct device *dev;
Signature · 1 line
1.7.2.3