Skip to contentSkip to conversation

ixgbe: DCB: remove DCB check config

PATCH Applied Jeff Kirsher 2 participants 2 messages Oct 15, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbe: DCB: remove DCB check config

From: John Fastabend <[email protected]>

Remove a DCB check config from DCB configuration we continue to configure DCB even if it fails so don't even bother to check. Plus user space (lldpad) checks this before programming the hw anyways.

Worse case is we program some values into the hw that don't make total sense resulting in incorrect bandwidth allocation.

---

 drivers/net/ixgbe/ixgbe_main.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/ixgbe/ixgbe_main.c +0 -1
index 95dbf60..790a0da 100644
@@ -3374,7 +3374,6 @@ static void ixgbe_configure_dcb(struct ixgbe_adapter *adapter)
 	if (hw->mac.type == ixgbe_mac_82598EB)
 		netif_set_gso_max_size(adapter->netdev, 32768);
 
-	ixgbe_dcb_check_config(&adapter->dcb_cfg);
 	ixgbe_dcb_calculate_tc_credits(&adapter->dcb_cfg, DCB_TX_CONFIG);
 	ixgbe_dcb_calculate_tc_credits(&adapter->dcb_cfg, DCB_RX_CONFIG);
 
maintainer Applied
#1 lore raw

From: Jeff Kirsher <[email protected]>
Date: Thu, 14 Oct 2010 22:21:22 -0700

Quoted 7 lines

From: John Fastabend <[email protected]>

Remove a DCB check config from DCB configuration we continue to configure DCB even if it fails so don't even bother to check. Plus user space (lldpad) checks this before programming the hw anyways.

Quoted 6 lines

Worse case is we program some values into the hw that don't make total sense resulting in incorrect bandwidth allocation.

Applied, thanks.