Skip to contentSkip to conversation

Staging: ft1000-usb: use the correct list head

PATCH In review Dan Carpenter 2 participants 2 messages Oct 15, 2010

Subsystems (2)
Staging Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/2 Staging: ft1000-usb: use the correct list head

Using pdpram_blk here would cause an oops. We intended to use &freercvpool.

Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/ft1000/ft1000-usb/ft1000_hw.c +1 -1
index d0637c3..076ba75 100644
@@ -1115,7 +1115,7 @@ u16 init_ft1000_netdev(struct ft1000_device *ft1000dev)
 
 
 err_free:
-	list_for_each_safe(cur, tmp, &pdpram_blk->list) {
+	list_for_each_safe(cur, tmp, &freercvpool) {
 		pdpram_blk = list_entry(cur, DPRAM_BLK, list);
 		list_del(&pdpram_blk->list);
 		kfree(pdpram_blk->pbuffer);
#1 lore raw
Quoted 12 lines · Dan Carpenter

Using pdpram_blk here would cause an oops.  We intended to use &freercvpool.

Signed-off-by Dan Carpenter <[email protected]>
drivers/staging/ft1000/ft1000-usb/ft1000_hw.c +0 -0
index d0637c3..076ba75 100644
@@ -1115,7 +1115,7 @@ u16 init_ft1000_netdev(struct ft1000_device *ft1000dev)
Quoted 7 lines

 err_free:
-       list_for_each_safe(cur, tmp, &pdpram_blk->list) {
+       list_for_each_safe(cur, tmp, &freercvpool) { pdpram_blk = list_entry(cur, DPRAM_BLK, list); list_del(&pdpram_blk->list); kfree(pdpram_blk->pbuffer);

Greg, you can add my Tested by: Marek Belisko <[email protected]>

@Dan, good catch. Thanks.

Marek

Signature · 10 lines
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com