Skip to contentSkip to conversation

mac80211: don't sanitize invalid rates

PATCH New Christian Lamparter 1 participant 1 message Oct 16, 2010 mac80211

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mac80211: don't sanitize invalid rates

I found this bug while poking around with a pure-gn AP.

Commit:
cfg80211/mac80211: Use more generic bitrate mask for rate control

Added some sanity checks to ensure that each tx rate index is included in the configured mask and it would change any rate indexes if it wasn't.

But, the current implementation doesn't take into account that the invalid rate index "-1" has a special meaning (= no further attempts) and it should not be "changed".

---

net/mac80211/rate.c +3 -0
index 4f772de..50a1200 100644
@@ -328,6 +328,9 @@ void rate_control_get_rate(struct ieee80211_sub_if_data *sdata,
 		 * if needed.
 		 */
 		for (i = 0; i < IEEE80211_TX_MAX_RATES; i++) {
+			/* Skip invalid rates */
+			if (info->control.rates[i].idx < 0)
+				break;
 			/* Rate masking supports only legacy rates for now */
 			if (info->control.rates[i].flags & IEEE80211_TX_RC_MCS)
 				continue;