Skip to contentSkip to conversation

ACPI / PM: Blacklist another machine that needs acpi_sleep=nonvs

PATCH Applied Rafael J. Wysocki 3 participants 11 messages Oct 17, 2010 – Oct 26, 2010 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI / PM: Blacklist another machine that needs acpi_sleep=nonvs

From: Rafael J. Wysocki <[email protected]>

Sony Vaio VPCEB1Z1E is reported to require acpi_sleep=nonvs for suspend/resume to work on it correctly, so blacklist it.

---
 drivers/acpi/sleep.c |    8 ++++++++
 1 file changed, 8 insertions(+)
drivers/acpi/sleep.c +8 -0
Index: linux-2.6/drivers/acpi/sleep.c
===================================================================
@@ -419,6 +419,14 @@ static struct dmi_system_id __initdata a
 		DMI_MATCH(DMI_PRODUCT_NAME, "Everex StepNote Series"),
 		},
 	},
+	{
+	.callback = init_nvs_nosave,
+	.ident = "Sony Vaio VPCEB1Z1E",
+	.matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+		DMI_MATCH(DMI_PRODUCT_NAME, "VPCEB1Z1E"),
+		},
+	},
 	{},
 };
 #endif /* CONFIG_SUSPEND */
reviewer Applied
#1 lore raw

Rather than a black list of machines that can not survive saving NVS, I wonder how long a white list of machines requiring NVS save would be?

applied.

thanks,
Len Brown, Intel Open Source Technology Center

reviewer Applied
#2 lore raw
In reply to Rafael J. Wysocki

Rather than a black list of machines that can not survive saving NVS, I wonder how long a white list of machines requiring NVS save would be?

applied.

thanks,
Len Brown, Intel Open Source Technology Center

#3 lore raw
Quoted 2 lines · Len Brown

Rather than a black list of machines that can not survive saving NVS, I wonder how long a white list of machines requiring NVS save would be?

Windows saves the NVS area in my testing. Either there's something that indicates the choices of one behaviour over the other, or the machines that are broken by NVS saving are actually tripping some other bug.

Signature · 1 line
Matthew Garrett | [email protected]
#4 lore raw
In reply to Len Brown
Quoted 2 lines · Len Brown

Rather than a black list of machines that can not survive saving NVS, I wonder how long a white list of machines requiring NVS save would be?

Windows saves the NVS area in my testing. Either there's something that indicates the choices of one behaviour over the other, or the machines that are broken by NVS saving are actually tripping some other bug.

Signature · 1 line
Matthew Garrett | [email protected]
#5 lore raw
Quoted 7 lines · Matthew Garrett
Quoted 2 lines · Len Brown

Rather than a black list of machines that can not survive saving NVS, I wonder how long a white list of machines requiring NVS save would be?

Windows saves the NVS area in my testing. Either there's something that indicates the choices of one behaviour over the other, or the machines that are broken by NVS saving are actually tripping some other bug.

Since we're claiming Windows compatibility through _OSI, we should follow Windows except for on machines that are blacklisted as not being Windows-compatible.

Thanks,
Rafael

#6 lore raw
In reply to Matthew Garrett
Quoted 7 lines · Matthew Garrett
Quoted 2 lines · Len Brown

Rather than a black list of machines that can not survive saving NVS, I wonder how long a white list of machines requiring NVS save would be?

Windows saves the NVS area in my testing. Either there's something that indicates the choices of one behaviour over the other, or the machines that are broken by NVS saving are actually tripping some other bug.

Since we're claiming Windows compatibility through _OSI, we should follow Windows except for on machines that are blacklisted as not being Windows-compatible.

Thanks,
Rafael

reviewer
#7 lore raw
Quoted 1 line

Windows-compatible.

Matthew,
Exactly what version of Windows did you test to be saving NVS? Is it possible that different versions of Windows behave differently?

thanks,
Len Brown, Intel Open Source Technology Center

reviewer
#8 lore raw
In reply to Rafael J. Wysocki
Quoted 1 line

Windows-compatible.

Matthew,
Exactly what version of Windows did you test to be saving NVS? Is it possible that different versions of Windows behave differently?

thanks,
Len Brown, Intel Open Source Technology Center

#9 lore raw
Quoted 5 lines · Len Brown
Quoted 1 line

Windows-compatible.

Matthew,
Exactly what version of Windows did you test to be saving NVS? Is it possible that different versions of Windows behave differently?

XP. It's certainly possible that later versions behave differently - I'll have to go back and check the original machine that had this problem to see which _OSI calls it makes. It may be that querying Vista or 7 disables this functionality.

Signature · 1 line
Matthew Garrett | [email protected]
#10 lore raw
In reply to Len Brown
Quoted 5 lines · Len Brown
Quoted 1 line

Windows-compatible.

Matthew,
Exactly what version of Windows did you test to be saving NVS? Is it possible that different versions of Windows behave differently?

XP. It's certainly possible that later versions behave differently - I'll have to go back and check the original machine that had this problem to see which _OSI calls it makes. It may be that querying Vista or 7 disables this functionality.

Signature · 1 line
Matthew Garrett | [email protected]