Skip to contentSkip to conversation

NFS sillyrename side effect

DISCUSSION Ian Munsie 9 participants 15 messages Oct 18, 2010 – Oct 21, 2010 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

Ian Munsie

author
#0 lore raw

Hi Trond,

I'm currently investigating a bug report related to NFS for an internal project, and I wanted to get your input as I've been able to reproduce it on an upstream 2.6.36-rc7 kernel on Power7 hardware. I have tracked it down to a side effect of the nfs_sillyrename function.

I'm not very familiar with the inner workings of the nfs layer, is the purpose of the sillyrename function to work around a limitation of nfs if a file is unlinked while in use?

It seems to me that if the sillyrename function is indeed necessary that we should not reveal the temporary filename it produces to userspace, but I wonder if that might create issues (say if userspace thinks a directory is empty when it acutally has a sillyrename file in it)?

Basically I want to know if the behaviour I've outlined below is the expected behaviour of NFS, or if you considder this a bug?

The gist of the original bug report is that running the syscalls test suite from the Linux Test Project on an nfsroot would emit warnings on the recvmsg01 test, however that test never emits warnings when run individually. The particular warning in question is:

tst_rmdir(): rmobj(/tmp/ltp-Url7aJLwfH/recZ7XHW6) failed:
unlink(/tmp/ltp-Url7aJLwfH/recZ7XHW6/.nfs00000000019f12d80000002e) failed; errno=16: Device or resource busy

However removing a number of preceding tests would instead produce a warning like the following:

recvmsg01 0 TWARN : tst_rmdir():
rmobj(/tmp/ltp-eenc4irncU/recRpxeMd) failed:
lstat(/tmp/ltp-eenc4irncU/recRpxeMd/.nfs00000000400a0e9a0000023c) failed; errno=2: No such file or directory

Scott (on CC), the original reporter produced that second behaviour by commenting out the first 475 tests and all the tests after recvmsg01. I've been able to produce it over 50% of the time with just the following two test cases:

foo echo
recvmsg01 recvmsg01

Presumably this is a race and the exact conditions necessary to reproduce it will vary depending on network, hardware, etc. Scott reported that this behaviour only began after transitioning from 2.6.31 to 2.6.32 - I haven't checked 2.6.31 to determine if the issue may have existed and just have been harder to produce or if 2.6.31 really did not exhibit this behaviour.

The recvmsg01 testcase sets up a temporary directory, performs a mkstemp to generate a temporary file within that directory which it promptly unlinks and creates a unix socket with that filename to perform it's tests. That all seems to work fine.

When it cleans up it kills it's server, unlinks that unix socket then calls tst_rmdir() which recursively removes (by calling it's rmobj function) the temporary directory and it's contents.

The race seems to be that when the socket is unlinked it's still in use, so the nfs layer performs a sillyrename on it to asynchronously unlink it, but before that completes the tst_rmdir function has already read the contents of the directory and spotted the .nfs00000... file from the sillyrename, which depending on the exact timing of the unlink will cause one of the above two warnings.

A somewhat filtered (grep -v permission) output of the race after activating nfs_debug is below:

setup:
NFS: lookup(recRpxeMd/udsockOxmZAh)
NFS: create(0:d/1074400921), udsockOxmZAh
NFS: nfs_fhget(0:d/1074400922 ct=1)
NFS: dentry_delete(recRpxeMd/udsockOxmZAh, 0)
NFS: nfs_update_inode(0:d/1074400921 ct=1 info=0x7d7f)
NFS: isize change on server for file 0:d/1074400921
NFS: unlink(0:d/1074400921, udsockOxmZAh)
NFS: safe_remove(recRpxeMd/udsockOxmZAh)
NFS: dentry_delete(recRpxeMd/udsockOxmZAh, 18)
NFS: nfs_update_inode(0:d/1074400921 ct=1 info=0x7d7f)
NFS: isize change on server for file 0:d/1074400921
NFS: lookup(recRpxeMd/udsockOxmZAh)
NFS: mknod(0:d/1074400921), udsockOxmZAh
...
cleanup:
NFS: unlink(0:d/1074400921, udsockOxmZAh)
NFS: silly-rename(recRpxeMd/udsockOxmZAh, ct=3)
NFS: trying to rename udsockOxmZAh to .nfs00000000400a0e9a0000023c
NFS: lookup(recRpxeMd/.nfs00000000400a0e9a0000023c)
NFS: dentry_delete(recRpxeMd/.nfs00000000400a0e9a0000023c, 10)
NFS: nfs_update_inode(0:d/1074400921 ct=1 info=0x7d7f)
NFS: isize change on server for file 0:d/1074400921
NFS: nfs_update_inode(0:d/3758724786 ct=2 info=0x1fdff)
NFS: nfs_update_inode(0:d/1074400921 ct=1 info=0x7d7f)
NFS: dentry_delete(recRpxeMd/.nfs00000000400a0e9a0000023c, 102)
NFS: dentry_delete(recRpxeMd/smtAmobkv, 8)
NFS: dentry_delete(recRpxeMd/smtAmobkv, 8)
NFS: unlink(0:d/1074400921, smtAmobkv)
NFS: safe_remove(recRpxeMd/smtAmobkv)
NFS: dentry_delete(recRpxeMd/smtAmobkv, 18)
NFS: nfs_update_inode(0:d/1074400921 ct=1 info=0x7d7f)
NFS: mtime change on server for file 0:d/1074400921
NFS: isize change on server for file 0:d/1074400921
NFS: lookup(recRpxeMd/.nfs00000000400a0e9a0000023c)
NFS: dentry_delete(recRpxeMd/.nfs00000000400a0e9a0000023c, 0)
NFS: dentry_delete(bin/recvmsg02, 8)

Cheers,
-Ian

#1 lore raw
Quoted 11 lines · On Mon, 18 Oct 2010 12:20:19 +1100 Ian Munsie <[email protected]> wrote:

Hi Trond,

I'm currently investigating a bug report related to NFS for an internal project, and I wanted to get your input as I've been able to reproduce it on an upstream 2.6.36-rc7 kernel on Power7 hardware. I have tracked it down to a side effect of the nfs_sillyrename function.

I'm not very familiar with the inner workings of the nfs layer, is the purpose of the sillyrename function to work around a limitation of nfs if a file is unlinked while in use?

See:

http://nfs.sourceforge.net/

...section D2. The faq mentions that NFSv4 could do away with it because it's stateful, but that's not really the case either.

Quoted 8 lines

It seems to me that if the sillyrename function is indeed necessary that we should not reveal the temporary filename it produces to userspace, but I wonder if that might create issues (say if userspace thinks a directory is empty when it acutally has a sillyrename file in it)?

Basically I want to know if the behaviour I've outlined below is the expected behaviour of NFS, or if you considder this a bug?

It's expected. Sillyrenaming sucks, but there really is no great alternative to it. It's one of the prices we pay for having NFSv2/3 be stateless.

I suppose in principle we could do things like hide silly-renamed dentries from userspace, but that might also be problematic. You'd still be unable to remove a directory that has a silly-renamed file in it, for instance even though it looks empty. There would also be inconsistencies as other machines and the server would still see the .nfsXXXXX files.

The bottom line is that you need to be really careful with programs that use delete-on-last-close when running on NFS.

Quoted 103 lines

The gist of the original bug report is that running the syscalls test suite from the Linux Test Project on an nfsroot would emit warnings on the recvmsg01 test, however that test never emits warnings when run individually. The particular warning in question is:

tst_rmdir(): rmobj(/tmp/ltp-Url7aJLwfH/recZ7XHW6) failed:
unlink(/tmp/ltp-Url7aJLwfH/recZ7XHW6/.nfs00000000019f12d80000002e) failed; errno=16: Device or resource busy

However removing a number of preceding tests would instead produce a warning like the following:

recvmsg01 0 TWARN : tst_rmdir():
rmobj(/tmp/ltp-eenc4irncU/recRpxeMd) failed:
lstat(/tmp/ltp-eenc4irncU/recRpxeMd/.nfs00000000400a0e9a0000023c) failed; errno=2: No such file or directory

Scott (on CC), the original reporter produced that second behaviour by commenting out the first 475 tests and all the tests after recvmsg01. I've been able to produce it over 50% of the time with just the following two test cases:

foo echo
recvmsg01 recvmsg01

Presumably this is a race and the exact conditions necessary to reproduce it will vary depending on network, hardware, etc. Scott reported that this behaviour only began after transitioning from 2.6.31 to 2.6.32 - I haven't checked 2.6.31 to determine if the issue may have existed and just have been harder to produce or if 2.6.31 really did not exhibit this behaviour.

The recvmsg01 testcase sets up a temporary directory, performs a mkstemp to generate a temporary file within that directory which it promptly unlinks and creates a unix socket with that filename to perform it's tests. That all seems to work fine.

When it cleans up it kills it's server, unlinks that unix socket then calls tst_rmdir() which recursively removes (by calling it's rmobj function) the temporary directory and it's contents.

The race seems to be that when the socket is unlinked it's still in use, so the nfs layer performs a sillyrename on it to asynchronously unlink it, but before that completes the tst_rmdir function has already read the contents of the directory and spotted the .nfs00000... file from the sillyrename, which depending on the exact timing of the unlink will cause one of the above two warnings.

A somewhat filtered (grep -v permission) output of the race after activating nfs_debug is below:

setup:
NFS: lookup(recRpxeMd/udsockOxmZAh)
NFS: create(0:d/1074400921), udsockOxmZAh
NFS: nfs_fhget(0:d/1074400922 ct=1)
NFS: dentry_delete(recRpxeMd/udsockOxmZAh, 0)
NFS: nfs_update_inode(0:d/1074400921 ct=1 info=0x7d7f)
NFS: isize change on server for file 0:d/1074400921
NFS: unlink(0:d/1074400921, udsockOxmZAh)
NFS: safe_remove(recRpxeMd/udsockOxmZAh)
NFS: dentry_delete(recRpxeMd/udsockOxmZAh, 18)
NFS: nfs_update_inode(0:d/1074400921 ct=1 info=0x7d7f)
NFS: isize change on server for file 0:d/1074400921
NFS: lookup(recRpxeMd/udsockOxmZAh)
NFS: mknod(0:d/1074400921), udsockOxmZAh
...
cleanup:
NFS: unlink(0:d/1074400921, udsockOxmZAh)
NFS: silly-rename(recRpxeMd/udsockOxmZAh, ct=3)
NFS: trying to rename udsockOxmZAh to .nfs00000000400a0e9a0000023c
NFS: lookup(recRpxeMd/.nfs00000000400a0e9a0000023c)
NFS: dentry_delete(recRpxeMd/.nfs00000000400a0e9a0000023c, 10)
NFS: nfs_update_inode(0:d/1074400921 ct=1 info=0x7d7f)
NFS: isize change on server for file 0:d/1074400921
NFS: nfs_update_inode(0:d/3758724786 ct=2 info=0x1fdff)
NFS: nfs_update_inode(0:d/1074400921 ct=1 info=0x7d7f)
NFS: dentry_delete(recRpxeMd/.nfs00000000400a0e9a0000023c, 102)
NFS: dentry_delete(recRpxeMd/smtAmobkv, 8)
NFS: dentry_delete(recRpxeMd/smtAmobkv, 8)
NFS: unlink(0:d/1074400921, smtAmobkv)
NFS: safe_remove(recRpxeMd/smtAmobkv)
NFS: dentry_delete(recRpxeMd/smtAmobkv, 18)
NFS: nfs_update_inode(0:d/1074400921 ct=1 info=0x7d7f)
NFS: mtime change on server for file 0:d/1074400921
NFS: isize change on server for file 0:d/1074400921
NFS: lookup(recRpxeMd/.nfs00000000400a0e9a0000023c)
NFS: dentry_delete(recRpxeMd/.nfs00000000400a0e9a0000023c, 0)
NFS: dentry_delete(bin/recvmsg02, 8)

Cheers,
-Ian
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 1 line
Jeff Layton <[email protected]>
#2 lore raw
Quoted 7 lines · On Mon, 18 Oct 2010 10:10:59 -0400 Jeff Layton <[email protected]> wrote:

See:

http://nfs.sourceforge.net/

...section D2. The faq mentions that NFSv4 could do away with it because it's stateful, but that's not really the case either.

Section D2 ends with:

"The NFS version 4 protocol is stateful, and could actually support delete-on-last-close. Unfortunately there isn't an easy way to do this and remain backwards-compatible with version 2 and 3 accessors."

So, theoretically, could one modify the code to selectively disable
silly rename on a client, when it knows it is talking v4 with the server?

Thanks

Cláudio

#3 lore raw
Quoted 11 lines · On Mon, 18 Oct 2010 15:48:11 +0100 Cláudio Martins <[email protected]> wrote:

Section D2 ends with:

"The NFS version 4 protocol is stateful, and could actually support delete-on-last-close. Unfortunately there isn't an easy way to do this and remain backwards-compatible with version 2 and 3 accessors."

So, theoretically, could one modify the code to selectively disable
silly rename on a client, when it knows it is talking v4 with the server?

BTW, to clarify, I'm assuming a scenario where the server is
configured to talk v4 only, which I suspect should be common, at least when you're relying on v4 kerberos security.

Best regards

Cláudio

#4 lore raw
Quoted 9 lines · On Mon, 18 Oct 2010 15:53:44 +0100 Cláudio Martins <[email protected]> wrote:
Quoted 7 lines · On Mon, 18 Oct 2010 15:48:11 +0100 Cláudio Martins <[email protected]> wrote:

Section D2 ends with:

"The NFS version 4 protocol is stateful, and could actually support delete-on-last-close. Unfortunately there isn't an easy way to do this and remain backwards-compatible with version 2 and 3 accessors."

Quoted 9 lines
Quoted 4 lines

So, theoretically, could one modify the code to selectively disable
silly rename on a client, when it knows it is talking v4 with the server?

BTW, to clarify, I'm assuming a scenario where the server is
configured to talk v4 only, which I suspect should be common, at least when you're relying on v4 kerberos security.

Sadly, no...

The server does generally hold the file open as long as the client has the file open. So, you could delete the file while nfsd has it open and everything would probably still work.

Suppose though that the server crashes and reboots. When it comes back up, fsck figures out that the file has been unlinked and frees the blocks on the disk. Now you can't reclaim the state on the open file.

We're pretty much stuck with silly-renaming even for v4.

Signature · 1 line
Jeff Layton <[email protected]>

A message that is not in the archive (sent off-list or not yet received): 20101018110138.5f5001eb-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org

#6 lore raw

On Mon, 18 Oct 2010 11:01:38 -0400 Jeff Layton <[email protected]> wro= te:

Quoted 5 lines

On Mon, 18 Oct 2010 15:53:44 +0100
Cl=C3=A1udio Martins <[email protected]> wrote:
=20

Quoted 2 lines
Quoted 2 lines

=20
So, theoretically, could one modify the code to selectively disa=

ble

Quoted 6 lines
Quoted 6 lines
Quoted 3 lines

silly rename on a client, when it knows it is talking v4 with the server?
=20

=20
BTW, to clarify, I'm assuming a scenario where the server is
configured to talk v4 only, which I suspect should be common, at le=

ast

Quoted 6 lines
Quoted 2 lines

when you're relying on v4 kerberos security.
=20

=20
Sadly, no...
=20
The server does generally hold the file open as long as the client ha=

s

Quoted 1 line

the file open. So, you could delete the file while nfsd has it open a=

nd

Quoted 3 lines

everything would probably still work.
=20
Suppose though that the server crashes and reboots. When it comes bac=

k

Quoted 5 lines

up, fsck figures out that the file has been unlinked and frees the blocks on the disk. Now you can't reclaim the state on the open file. =20
We're pretty much stuck with silly-renaming even for v4. =20

Jeff,

Thank you for the explanation, you make a good point.

Best regards

Cl=C3=A1udio

#7 lore raw

You would need to do the state recovery before or during the fsck (which would require the local filesystem to have some loose integration with the network protocol).

Also, re the original issue, can't the client do a silly rename of the directory if it contains only .nfs files during rmdir?

Quoted 3 lines

Suppose though that the server crashes and reboots. When it comes back

Quoted 2 lines

up, fsck figures out that the file has been unlinked and frees the blocks on the disk. Now you can't reclaim the state on the open file.

#8 lore raw
Quoted 7 lines · On Mon, 18 Oct 2010 12:21:43 -0400 Lyle Seaman <[email protected]> wrote:

You would need to do the state recovery before or during the fsck (which would require the local filesystem to have some loose integration with the network protocol).

Also, re the original issue, can't the client do a silly rename of the directory if it contains only .nfs files during rmdir?

I think the problem is that would be racy. You have no guarantee that
other clients won't create files on that directory between the time you check the directory and the time you'd silly-rename it, so you would end up "deleting" directories which are not "empty".

Best regards

Cláudio

#9 lore raw
In reply to Jeff Layton
Quoted 28 lines · Jeff Layton
Quoted 9 lines · On Mon, 18 Oct 2010 15:53:44 +0100 Cláudio Martins <[email protected]> wrote:
Quoted 7 lines · On Mon, 18 Oct 2010 15:48:11 +0100 Cláudio Martins <[email protected]> wrote:

Section D2 ends with:

"The NFS version 4 protocol is stateful, and could actually support delete-on-last-close. Unfortunately there isn't an easy way to do this and remain backwards-compatible with version 2 and 3 accessors."

Quoted 9 lines
Quoted 4 lines

So, theoretically, could one modify the code to selectively disable
silly rename on a client, when it knows it is talking v4 with the server?

BTW, to clarify, I'm assuming a scenario where the server is
configured to talk v4 only, which I suspect should be common, at least when you're relying on v4 kerberos security.

Sadly, no...

The server does generally hold the file open as long as the client has the file open. So, you could delete the file while nfsd has it open and everything would probably still work.

Quoted 5 lines

Suppose though that the server crashes and reboots. When it comes back up, fsck figures out that the file has been unlinked and frees the blocks on the disk. Now you can't reclaim the state on the open file.

We're pretty much stuck with silly-renaming even for v4.

The server could do something like rename the file into a special directory somewhere that only it had access to, preserving the file across reboot. Then at the end of the grace period it would remove any files in that directory that had not been reclaimed by some client.

The problem would still remain that the *client* wouldn't know that the server was capable of doing this, so would still be stuck doing sillyrename on its own just to be sure.

NFSv4.1 adds an open return flag which allows the server to tell the client that the client doesn't need to do sillyrename; see the discussion of OPEN4_RESULT_PRESERVE_UNLINKED flag in rfc 5661.

I don't think anyone's looked into implementing that yet; might be a fun project.

--b.

#10 lore raw
Quoted 29 lines · J. Bruce Fields
Quoted 28 lines · Jeff Layton
Quoted 9 lines · On Mon, 18 Oct 2010 15:53:44 +0100 Cláudio Martins <[email protected]> wrote:
Quoted 7 lines · On Mon, 18 Oct 2010 15:48:11 +0100 Cláudio Martins <[email protected]> wrote:

Section D2 ends with:

"The NFS version 4 protocol is stateful, and could actually support delete-on-last-close. Unfortunately there isn't an easy way to do this and remain backwards-compatible with version 2 and 3 accessors."

Quoted 9 lines
Quoted 4 lines

So, theoretically, could one modify the code to selectively disable
silly rename on a client, when it knows it is talking v4 with the server?

BTW, to clarify, I'm assuming a scenario where the server is
configured to talk v4 only, which I suspect should be common, at least when you're relying on v4 kerberos security.

Sadly, no...

The server does generally hold the file open as long as the client has the file open. So, you could delete the file while nfsd has it open and everything would probably still work.

Quoted 8 lines
Quoted 5 lines

Suppose though that the server crashes and reboots. When it comes back up, fsck figures out that the file has been unlinked and frees the blocks on the disk. Now you can't reclaim the state on the open file.

We're pretty much stuck with silly-renaming even for v4.

The server could do something like rename the file into a special directory somewhere

The clients can do something similar too, like sillyrenaming the files onto <mountpoint>/.unlinked_while_opened.<client-id> Removing this directory when it empties.

Benny

Quoted 20 lines

that only it had access to, preserving the file
across reboot. Then at the end of the grace period it would remove any files in that directory that had not been reclaimed by some client.

The problem would still remain that the *client* wouldn't know that the server was capable of doing this, so would still be stuck doing sillyrename on its own just to be sure.

NFSv4.1 adds an open return flag which allows the server to tell the client that the client doesn't need to do sillyrename; see the discussion of OPEN4_RESULT_PRESERVE_UNLINKED flag in rfc 5661.

I don't think anyone's looked into implementing that yet; might be a fun project.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#11 lore raw
Quoted 34 lines · Benny Halevy
Quoted 33 lines · J. Bruce Fields
Quoted 32 lines · Jeff Layton
Quoted 9 lines · On Mon, 18 Oct 2010 15:53:44 +0100 Cláudio Martins <[email protected]> wrote:
Quoted 7 lines · On Mon, 18 Oct 2010 15:48:11 +0100 Cláudio Martins <[email protected]> wrote:

Section D2 ends with:

"The NFS version 4 protocol is stateful, and could actually support delete-on-last-close. Unfortunately there isn't an easy way to do this and remain backwards-compatible with version 2 and 3 accessors."

Quoted 9 lines
Quoted 4 lines

So, theoretically, could one modify the code to selectively disable
silly rename on a client, when it knows it is talking v4 with the server?

BTW, to clarify, I'm assuming a scenario where the server is
configured to talk v4 only, which I suspect should be common, at least when you're relying on v4 kerberos security.

Sadly, no...

The server does generally hold the file open as long as the client has the file open. So, you could delete the file while nfsd has it open and everything would probably still work.

Suppose though that the server crashes and reboots. When it comes back up, fsck figures out that the file has been unlinked and frees the blocks on the disk. Now you can't reclaim the state on the open file.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

We're pretty much stuck with silly-renaming even for v4.

The server could do something like rename the file into a special directory somewhere

The clients can do something similar too, like sillyrenaming the files onto <mountpoint>/.unlinked_while_opened.<client-id> Removing this directory when it empties.

This would require access, directory create, and delete permissions for the directory '<mountpoint>/', which is not always a given.

Besides, what if the server reboots, and my clientid changes?

Trond

#12 lore raw
Quoted 40 lines · Trond Myklebust
Quoted 39 lines · Benny Halevy
Quoted 37 lines · J. Bruce Fields
Quoted 28 lines · Jeff Layton
Quoted 9 lines · On Mon, 18 Oct 2010 15:53:44 +0100 Cláudio Martins <[email protected]> wrote:
Quoted 7 lines · On Mon, 18 Oct 2010 15:48:11 +0100 Cláudio Martins <[email protected]> wrote:

Section D2 ends with:

"The NFS version 4 protocol is stateful, and could actually support delete-on-last-close. Unfortunately there isn't an easy way to do this and remain backwards-compatible with version 2 and 3 accessors."

Quoted 9 lines
Quoted 4 lines

So, theoretically, could one modify the code to selectively disable
silly rename on a client, when it knows it is talking v4 with the server?

BTW, to clarify, I'm assuming a scenario where the server is
configured to talk v4 only, which I suspect should be common, at least when you're relying on v4 kerberos security.

Sadly, no...

The server does generally hold the file open as long as the client has the file open. So, you could delete the file while nfsd has it open and everything would probably still work.

Quoted 5 lines

Suppose though that the server crashes and reboots. When it comes back up, fsck figures out that the file has been unlinked and frees the blocks on the disk. Now you can't reclaim the state on the open file.

We're pretty much stuck with silly-renaming even for v4.

The server could do something like rename the file into a special directory somewhere

Quoted 6 lines
Quoted 3 lines

The clients can do something similar too, like sillyrenaming the files onto <mountpoint>/.unlinked_while_opened.<client-id> Removing this directory when it empties.

This would require access, directory create, and delete permissions for the directory '<mountpoint>/', which is not always a given.

Correct. But that's pretty easy to probe :)

Quoted 2 lines

Besides, what if the server reboots, and my clientid changes?

By <client-id> I meant a unique identifier for the client, not necessarily the nfsv4.x clientid. The client could just as well use its ip address (to help admins deal with the aftermath in case the client goes away) and its boot time, or even a random string.

Benny

Quoted 2 lines

Trond

#13 lore raw
Quoted 4 lines · Benny Halevy
Quoted 2 lines · Trond Myklebust

This would require access, directory create, and delete permissions for the directory '<mountpoint>/', which is not always a given.

Quoted 8 lines

Correct. But that's pretty easy to probe :)

Quoted 1 line

Besides, what if the server reboots, and my clientid changes?

By <client-id> I meant a unique identifier for the client, not necessarily the nfsv4.x clientid. The client could just as well use its ip address (to help admins deal with the aftermath in case the client goes away) and its boot time, or even a random string.

Like the current sillyrename, it'd help in some cases, but not all. The set of cases where it worked would be a little larger, but also a little harder to explain. There may be diminishing returns to trying to perfect this kind of workaround.

With 4.1 almost actually ready time might be better spent there, as it offers the chance of a complete solution.

--b.

#14 lore raw
In reply to Benny Halevy
Quoted 10 lines · Benny Halevy
Quoted 7 lines · Trond Myklebust
Quoted 3 lines · Benny Halevy

The clients can do something similar too, like sillyrenaming the files onto <mountpoint>/.unlinked_while_opened.<client-id> Removing this directory when it empties.

This would require access, directory create, and delete permissions for the directory '<mountpoint>/', which is not always a given.

Correct. But that's pretty easy to probe :)

Yup, but you'd then need to handle both cases in order to avoid regressions.

You'd also have to deal with more complex locking: avoiding deadlocks when creating mountpoint/.unlinked_while_open.<clientid> while still holding the directory mutex for the unlink(). That basically requires you to take mutexes in the opposite order to that required for a cross-directory rename.

IOW: is it really worth the effort?

Note also that userland can do exactly the same thing. You are basically proposing to do the whole 'trashcan' concept in kernel space...

Quoted 7 lines
Quoted 2 lines

Besides, what if the server reboots, and my clientid changes?

By <client-id> I meant a unique identifier for the client, not necessarily the nfsv4.x clientid. The client could just as well use its ip address (to help admins deal with the aftermath in case the client goes away) and its boot time, or even a random string.

Trond

A message that is not in the archive (sent off-list or not yet received): 20101018101059.574b715a-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org

#16 lore raw

Hi all,

Excerpts from Jeff Layton's message of Tue Oct 19 01:10:59 +1100 2010:

Quoted 6 lines

See:

http://nfs.sourceforge.net/

...section D2. The faq mentions that NFSv4 could do away with it because it's stateful, but that's not really the case either.

Thanks for the pointer.

Quoted 14 lines
Quoted 8 lines

It seems to me that if the sillyrename function is indeed necessary that we should not reveal the temporary filename it produces to userspace, but I wonder if that might create issues (say if userspace thinks a directory is empty when it acutally has a sillyrename file in it)?

Basically I want to know if the behaviour I've outlined below is the expected behaviour of NFS, or if you considder this a bug?

It's expected. Sillyrenaming sucks, but there really is no great alternative to it. It's one of the prices we pay for having NFSv2/3 be stateless.

Quoted 6 lines

I suppose in principle we could do things like hide silly-renamed dentries from userspace, but that might also be problematic. You'd still be unable to remove a directory that has a silly-renamed file in it, for instance even though it looks empty. There would also be inconsistencies as other machines and the server would still see the .nfsXXXXX files.

I had a feeling that would be the case.

Quoted 2 lines

The bottom line is that you need to be really careful with programs that use delete-on-last-close when running on NFS.

Thanks to everyone who replied for clarifying this matter for me.

Cheers,
-Ian