phy/marvell: fix 88e1121 support
Subsystems (3)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 phy/marvell: fix 88e1121 support
Commit c477d0447db08068a497e7beb892b2b2a7bff64b added support for RGMII rx/tx delays except that it ends up clearing rx/tx delays bit for modes differents that RGMII*ID. Due to this, ethernet is not working anymore on my guruplug server +. This patch is fixing that.
drivers/net/phy/marvell.c +4 -4
@@ -199,13 +199,13 @@ mscr =phy_read (phydev,MII_88E1121_PHY_MSCR_REG ) &MII_88E1121_PHY_MSCR_DELAY_MASK ; -if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_ID ) - mscr |= (MII_88E1121_PHY_MSCR_RX_DELAY | -MII_88E1121_PHY_MSCR_TX_DELAY ); -else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) +if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) mscr |=MII_88E1121_PHY_MSCR_RX_DELAY ;else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_TXID ) mscr |=MII_88E1121_PHY_MSCR_TX_DELAY ; +else + mscr |= (MII_88E1121_PHY_MSCR_RX_DELAY | +MII_88E1121_PHY_MSCR_TX_DELAY ); err =phy_write (phydev,MII_88E1121_PHY_MSCR_REG , mscr);if (err <0 )
Hi,
Quoted 18 lines · Arnaud Patard
Commit
c477d0447db08068a497e7beb892b2b2a7bff64badded support for RGMII rx/tx delays except that it ends up clearing rx/tx delays bit for modes differents that RGMII*ID. Due to this, ethernet is not working anymore on my guruplug server +. This patch is fixing that.Signed-off-by Arnaud Patard <[email protected]>Index:
linux-2.6/drivers/net/phy/marvell.c
===================================================================drivers/net/phy/marvell.c +0
-4@@ -199,13 +199,13 @@ mscr =phy_read (phydev,MII_88E1121_PHY_MSCR_REG ) &MII_88E1121_PHY_MSCR_DELAY_MASK ; -if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_ID ) - mscr |= (MII_88E1121_PHY_MSCR_RX_DELAY | -MII_88E1121_PHY_MSCR_TX_DELAY ); -else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID )
drivers/net/phy/marvell.c line 211
Quoted 10 lines
drivers/net/phy/marvell.c +4
-0+if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) mscr |=MII_88E1121_PHY_MSCR_RX_DELAY ;else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_TXID ) mscr |=MII_88E1121_PHY_MSCR_TX_DELAY ; +else + mscr |= (MII_88E1121_PHY_MSCR_RX_DELAY | +MII_88E1121_PHY_MSCR_TX_DELAY ); err =phy_write (phydev,MII_88E1121_PHY_MSCR_REG , mscr);if (err <0 )
This doesn't look right. This change makes it impossible to configure the phy without interface delays, i.e., PHY_INTERFACE_MODE_RGMII ends up behaving the same as PHY_INTERFACE_MODE_RGMII_ID.
I think the correct fix would be to modify guruplug's interface mode to PHY_INTERFACE_MODE_RGMII_ID if both TX and RX side delays are desired.
Regards
Cyril.
Quoted 16 lines
Quoted 16 lines
drivers/net/phy/marvell.c +4
-4@@ -199,13 +199,13 @@ mscr =phy_read (phydev,MII_88E1121_PHY_MSCR_REG ) &MII_88E1121_PHY_MSCR_DELAY_MASK ; -if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_ID ) - mscr |= (MII_88E1121_PHY_MSCR_RX_DELAY | -MII_88E1121_PHY_MSCR_TX_DELAY ); -else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) +if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) mscr |=MII_88E1121_PHY_MSCR_RX_DELAY ;else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_TXID ) mscr |=MII_88E1121_PHY_MSCR_TX_DELAY ; +else + mscr |= (MII_88E1121_PHY_MSCR_RX_DELAY | +MII_88E1121_PHY_MSCR_TX_DELAY );
Quoted 7 lines
drivers/net/phy/marvell.c line 211
Quoted 2 lines
drivers/net/phy/marvell.c +0
-0err =phy_write (phydev,MII_88E1121_PHY_MSCR_REG , mscr);if (err <0 )This doesn't look right. This change makes it impossible to configure the phy without interface delays, i.e.,
PHY_INTERFACE_MODE_RGMIIends up behaving the same asPHY_INTERFACE_MODE_RGMII_ID.
ok. The other possibility is to modify the MII_88E1121_PHY_MSCR_REG regs
only in RGMII_* case like for the 88e1111 case imho.
I'm sending a patch doing that right now.
Regards,
Arnaud
PATCH 1/1 phy/marvell: fix 88e1121 support
Commit c477d0447db08068a497e7beb892b2b2a7bff64b added support for RGMII rx/tx delays except that it ends up clearing rx/tx delays bit for modes differents that RGMII*ID. Due to this, ethernet is not working anymore on my guruplug server +. This patch is fixing that.
drivers/net/phy/marvell.c +19 -12
@@ -196,20 +196,27 @@ MII_88E1121_PHY_MSCR_PAGE);if (err <0 )return err; - mscr =phy_read (phydev,MII_88E1121_PHY_MSCR_REG ) & -MII_88E1121_PHY_MSCR_DELAY_MASK ; -if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_ID ) - mscr |= (MII_88E1121_PHY_MSCR_RX_DELAY | -MII_88E1121_PHY_MSCR_TX_DELAY ); -else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) - mscr |=MII_88E1121_PHY_MSCR_RX_DELAY ; -else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_TXID ) - mscr |=MII_88E1121_PHY_MSCR_TX_DELAY ; +if ((phydev->interface ==PHY_INTERFACE_MODE_RGMII ) || + (phydev->interface ==PHY_INTERFACE_MODE_RGMII_ID ) || + (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) || + (phydev->interface ==PHY_INTERFACE_MODE_RGMII_TXID )) { - err =phy_write (phydev,MII_88E1121_PHY_MSCR_REG , mscr); -if (err <0 ) -return err; + mscr =phy_read (phydev,MII_88E1121_PHY_MSCR_REG ) & +MII_88E1121_PHY_MSCR_DELAY_MASK ; + +if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_ID ) + mscr |= (MII_88E1121_PHY_MSCR_RX_DELAY | +MII_88E1121_PHY_MSCR_TX_DELAY ); +else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) + mscr |=MII_88E1121_PHY_MSCR_RX_DELAY ; +else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_TXID ) + mscr |=MII_88E1121_PHY_MSCR_TX_DELAY ; + + err =phy_write (phydev,MII_88E1121_PHY_MSCR_REG , mscr); +if (err <0 ) +return err; + }phy_write (phydev,MII_88E1121_PHY_PAGE , oldpage);
Hi Arnaud,
Quoted 39 lines · Arnaud Patard
Commit
c477d0447db08068a497e7beb892b2b2a7bff64badded support for RGMII rx/tx delays except that it ends up clearing rx/tx delays bit for modes differents that RGMII*ID. Due to this, ethernet is not working anymore on my guruplug server +. This patch is fixing that.Signed-off-by Arnaud Patard <[email protected]>Index:
linux-2.6/drivers/net/phy/marvell.c
===================================================================drivers/net/phy/marvell.c +11
-12@@ -196,20 +196,27 @@ MII_88E1121_PHY_MSCR_PAGE);if (err <0 )return err; - mscr =phy_read (phydev,MII_88E1121_PHY_MSCR_REG ) & -MII_88E1121_PHY_MSCR_DELAY_MASK ; -if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_ID ) - mscr |= (MII_88E1121_PHY_MSCR_RX_DELAY | -MII_88E1121_PHY_MSCR_TX_DELAY ); -else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) - mscr |=MII_88E1121_PHY_MSCR_RX_DELAY ; -else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_TXID ) - mscr |=MII_88E1121_PHY_MSCR_TX_DELAY ; +if ((phydev->interface ==PHY_INTERFACE_MODE_RGMII ) || + (phydev->interface ==PHY_INTERFACE_MODE_RGMII_ID ) || + (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) || + (phydev->interface ==PHY_INTERFACE_MODE_RGMII_TXID )) { - err =phy_write (phydev,MII_88E1121_PHY_MSCR_REG , mscr); -if (err <0 ) -return err; + mscr =phy_read (phydev,MII_88E1121_PHY_MSCR_REG ) & +MII_88E1121_PHY_MSCR_DELAY_MASK ; + +if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_ID ) + mscr |= (MII_88E1121_PHY_MSCR_RX_DELAY | +MII_88E1121_PHY_MSCR_TX_DELAY ); +else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID )
drivers/net/phy/marvell.c line 221
Quoted 10 lines
drivers/net/phy/marvell.c +8
-0+ mscr |=MII_88E1121_PHY_MSCR_RX_DELAY ; + else if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID) + mscr |= MII_88E1121_PHY_MSCR_TX_DELAY; + + err = phy_write(phydev, MII_88E1121_PHY_MSCR_REG, mscr); +if (err <0 ) +return err; + }phy_write (phydev,MII_88E1121_PHY_PAGE , oldpage);
That looks more correct. Just out of curiosity, what is the interface mode on your platform?
Thanks
Cyril.
Quoted 1 line · Cyril Chemparathy
Hi Arnaud,
Hi,
Quoted 50 lines · Arnaud Patard
Quoted 48 lines
Commit
c477d0447db08068a497e7beb892b2b2a7bff64badded support for RGMII rx/tx delays except that it ends up clearing rx/tx delays bit for modes differents that RGMII*ID. Due to this, ethernet is not working anymore on my guruplug server +. This patch is fixing that.Signed-off-by Arnaud Patard <[email protected]>Index:
linux-2.6/drivers/net/phy/marvell.c
===================================================================drivers/net/phy/marvell.c +19
-12@@ -196,20 +196,27 @@ MII_88E1121_PHY_MSCR_PAGE);if (err <0 )return err; - mscr =phy_read (phydev,MII_88E1121_PHY_MSCR_REG ) & -MII_88E1121_PHY_MSCR_DELAY_MASK ; -if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_ID ) - mscr |= (MII_88E1121_PHY_MSCR_RX_DELAY | -MII_88E1121_PHY_MSCR_TX_DELAY ); -else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) - mscr |=MII_88E1121_PHY_MSCR_RX_DELAY ; -else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_TXID ) - mscr |=MII_88E1121_PHY_MSCR_TX_DELAY ; +if ((phydev->interface ==PHY_INTERFACE_MODE_RGMII ) || + (phydev->interface ==PHY_INTERFACE_MODE_RGMII_ID ) || + (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) || + (phydev->interface ==PHY_INTERFACE_MODE_RGMII_TXID )) { - err =phy_write (phydev,MII_88E1121_PHY_MSCR_REG , mscr); -if (err <0 ) -return err; + mscr =phy_read (phydev,MII_88E1121_PHY_MSCR_REG ) & +MII_88E1121_PHY_MSCR_DELAY_MASK ; + +if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_ID ) + mscr |= (MII_88E1121_PHY_MSCR_RX_DELAY | +MII_88E1121_PHY_MSCR_TX_DELAY ); +else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_RXID ) + mscr |=MII_88E1121_PHY_MSCR_RX_DELAY ; +else if (phydev->interface ==PHY_INTERFACE_MODE_RGMII_TXID ) + mscr |=MII_88E1121_PHY_MSCR_TX_DELAY ; + + err =phy_write (phydev,MII_88E1121_PHY_MSCR_REG , mscr); +if (err <0 ) +return err; + }
Quoted 4 lines
drivers/net/phy/marvell.c line 221
Quoted 1 line
drivers/net/phy/marvell.c +0
-0phy_write (phydev,MII_88E1121_PHY_PAGE , oldpage);That looks more correct. Just out of curiosity, what is the interface mode on your platform?
The interface is in GMII mode iirc. The device is the ethernet embedded in the Kirkwood SoC with a 88e1121 phy connected. It's handled by the mv643xx_eth driver and the marvell phy driver.
Arnaud
From: Arnaud Patard (Rtp) <[email protected]>
Date: Tue, 19 Oct 2010 00:29:48 +0200
Quoted 6 lines
Commit
c477d0447db08068a497e7beb892b2b2a7bff64badded support for RGMII rx/tx delays except that it ends up clearing rx/tx delays bit for modes differents that RGMII*ID. Due to this, ethernet is not working anymore on my guruplug server +. This patch is fixing that.Signed-off-by Arnaud Patard <[email protected]>
Applied, thanks.