Skip to contentSkip to conversation

exec: don't turn PF_KTHREAD off when a target command was not found

PATCH RESEND New KOSAKI Motohiro 1 participant 1 message Oct 19, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 exec: don't turn PF_KTHREAD off when a target command was not found

Now, do_execve() turn PF_KTHREAD off before search_binary_handler(). It has theorical risk of PF_KTHREAD lost. We don't have to turn PF_KTHREAD off when ENOEXEC case.

This patch move this flag modification after founding execution file.

this is only theorical issue because now any kthread don't call do_execve() directly. but anyway fixing would be better.

---
 fs/exec.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
fs/exec.c +1 -2
index fcbd39e..6469c26 100644
@@ -1009,7 +1009,7 @@ int flush_old_exec(struct linux_binprm * bprm)
 
 	bprm->mm = NULL;		/* We're using it now */
 
-	current->flags &= ~PF_RANDOMIZE;
+	current->flags &= ~(PF_RANDOMIZE | PF_KTHREAD);
 	flush_thread();
 	current->personality &= ~bprm->per_clear;
 
@@ -1412,7 +1412,6 @@ int do_execve(const char * filename,
 	if (retval < 0)
 		goto out;
 
-	current->flags &= ~PF_KTHREAD;
 	retval = search_binary_handler(bprm,regs);
 	if (retval < 0)
 		goto out;
Signature · 1 line
1.6.5.2