sdhci-esdhc-imx: fix timeout on i.MX's sdhci
Subsystems (4)
PATCH 1/1 sdhci-esdhc-imx: fix timeout on i.MX's sdhci
this patch fix timeout problems on i.MX51 as suggested by Richard Zhu.
more tests are needed to check if this quirk can be removed for i.MX25 and 35.
--- drivers/mmc/host/sdhci-esdhc-imx.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/mmc/host/sdhci-esdhc-imx.c +2 -1
@@ -134,7 +134,8 @@ static struct sdhci_ops sdhci_esdhc_ops = {struct sdhci_pltfm_data sdhci_esdhc_imx_pdata = { .quirks =ESDHC_DEFAULT_QUIRKS |SDHCI_QUIRK_NO_MULTIBLOCK - |SDHCI_QUIRK_BROKEN_ADMA , + |SDHCI_QUIRK_BROKEN_ADMA + |SDHCI_QUIRK_BROKEN_TIMEOUT_VAL ,/* ADMA has issues. Might be fixable */ /* NO_MULTIBLOCK might be MX35 only (Errata: ENGcm07207) */ .ops = &sdhci_esdhc_ops,
Signature · 1 line
1.7.0.4
PATCH 1/1 sdhci-esdhc-imx: fix timeout on i.MX's sdhci
Quoted 4 lines · Eric B?nard
this patch fix timeout problems on i.MX51 as suggested by Richard Zhu.
more tests are needed to check if this quirk can be removed for i.MX25 and 35.
Didn't you have such boards?
Signature · 9 lines
Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101019/92a987f0/attachment.sig>
PATCH 1/1 sdhci-esdhc-imx: fix timeout on i.MX's sdhci
Hi Wolfram,
Le 19/10/2010 17:07, Wolfram Sang a ?crit :
Quoted 7 lines · Eric B?nard
Quoted 4 lines
this patch fix timeout problems on i.MX51 as suggested by Richard Zhu.
more tests are needed to check if this quirk can be removed for i.MX25 and 35.Didn't you have such boards?
I do have, but I can't do the tests until next week because of other priorities.
Eric
PATCH 1/1 sdhci-esdhc-imx: fix timeout on i.MX's sdhci
Quoted 4 lines · Eric B?nard
Hi Wolfram,
Le 19/10/2010 17:07, Wolfram Sang a ?crit :
Quoted 1 line · Eric B?nard
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
this patch fix timeout problems on i.MX51 as suggested by Richard Zhu.
more tests are needed to check if this quirk can be removed for i.MX25 and 35.Didn't you have such boards?
I do have, but I can't do the tests until next week because of other priorities.
I'd suggest to add a proper patch next week then (maybe together with correct usage of the MULTIBLOCK-quirk, too?). It's a new driver, so adding update patches late in the cycle should not cause problems? Of course, Chris makes the final decision about that.
Signature · 9 lines
Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20101019/d51cbf10/attachment.sig>
PATCH 1/1 sdhci-esdhc-imx: fix timeout on i.MX's sdhci
Quoted 6 lines · Wolfram Sang
Quoted 1 line
I do have, but I can't do the tests until next week because of other priorities.
I'd suggest to add a proper patch next week then (maybe together with correct usage of the MULTIBLOCK-quirk, too?). It's a new driver, so adding update patches late in the cycle should not cause problems? Of course, Chris makes the final decision about that.
Fine with me, tested patches are good. There's no need to rush to get it in before -rc1.
Thanks,
Signature · 2 lines
Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child