Skip to contentSkip to conversation

efikamx support improvements - try 2

PATCH Superseded Arnaud Patard (Rtp) 3 participants 16 messages Oct 21, 2010 – Oct 22, 2010

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover efikamx support improvements - try 2

Hi,

This patchset aims at improving current efikamx support. It adds support for :
- board id detection
- sdhc
- leds
- power button
- spi nor
- reset

I also had to fix/improve some imx51 iomux header so there are patches for iomux-mx51.h.

v2:
- split iomux patch 3 into 2 patches
- reorder patches
- fix space comment
- fix Amit's comments
- decrease board id msleep

Arnaud

#8 lore raw

PATCH v2 7/10 efikamx: add support for power key

Hi Arnaud,

Quoted 2 lines · Arnaud Patard

This patch adds support for power key button of the efika mx. It's connected on ?GPIO 3 31.

Here you mention GPIO 3 31

Quoted 1 line

+#define EFIKAMX_POWER_KEY ? ? ?(1*32 + 31)

,but here you define it as GPIO 2 31

Regards,

Fabio Estevam

#9 lore raw

PATCH v2 7/10 efikamx: add support for power key

Quoted 1 line · Fabio Estevam

Hi Arnaud,

Hi,

Quoted 11 lines
Quoted 2 lines · Arnaud Patard

This patch adds support for power key button of the efika mx. It's connected on ?GPIO 3 31.

Here you mention GPIO 3 31

Quoted 1 line

+#define EFIKAMX_POWER_KEY ? ? ?(1*32 + 31)

,but here you define it as GPIO 2 31

It's a typo in the patch description [ I wouldn't have sent the patch if it was not working :) ]. The reset is on 2 31.

Arnaud

#10 lore raw

PATCH v2 7/10 efikamx: add support for power key

Quoted 12 lines · Arnaud Patard (Rtp)
Quoted 1 line · Fabio Estevam

Hi Arnaud,

Hi,

Quoted 6 lines
Quoted 2 lines · Arnaud Patard

This patch adds support for power key button of the efika mx. It's connected on ?GPIO 3 31.

Quoted 9 lines
Quoted 5 lines

Here you mention GPIO 3 31

Quoted 1 line

+#define EFIKAMX_POWER_KEY ? ? ?(1*32 + 31)

,but here you define it as GPIO 2 31

It's a typo in the patch description [ I wouldn't have sent the patch if it was not working :) ]. The reset is on 2 31.

oops. s/reset is on 2 31/power key is on 2 31/ sorry for the confusion :(

Arnaud

#14 lore raw

v2 cover efikamx support improvements - try 2

In reply to Arnaud Patard (Rtp)
Quoted 14 lines · Arnaud Patard

Hi,

This patchset aims at improving current efikamx support. It adds support for :
- board id detection
- sdhc
- leds
- power button
- spi nor
- reset

I also had to fix/improve some imx51 iomux header so there are patches for iomux-mx51.h.

Quoted 9 lines

v2:
- split iomux patch 3 into 2 patches
- reorder patches
- fix space comment
- fix Amit's comments
- decrease board id msleep

Arnaud

Please fix the typo in 07/10 description. Or perhaps Sascha will fix it while committing.

Also Dinh has added mx51_add_buttons() to platform code. 07/10 should be modified to use that. Search for "ARM: imx: Add gpio-keys to mx51 babbage board" on LAKML.

After that, for the whole series, you can add,

#15 lore raw

v2 cover efikamx support improvements - try 2

Amit Kucheria <[email protected]> writes:

Hi,

Quoted 22 lines · Arnaud Patard
Quoted 21 lines

Hi,

This patchset aims at improving current efikamx support. It adds support for :
- board id detection
- sdhc
- leds
- power button
- spi nor
- reset

I also had to fix/improve some imx51 iomux header so there are patches for iomux-mx51.h.

v2:
- split iomux patch 3 into 2 patches
- reorder patches
- fix space comment
- fix Amit's comments
- decrease board id msleep

Quoted 8 lines
Quoted 2 lines

Arnaud

Please fix the typo in 07/10 description. Or perhaps Sascha will fix it while committing.

Also Dinh has added mx51_add_buttons() to platform code. 07/10 should be modified to use that. Search for "ARM: imx: Add gpio-keys to mx51 babbage board" on LAKML.

uh ? You mean that a patch sent with a subject containing 'mx51 babbage' is containing changes which are generic for all imx51 platforms ? that's rather counter-intuitive and unfortunate imho :(

Moreover, from the archives, it's making what looks like babbage specific changes in iomux-mx51.h file as noted Uwe Kleine-Koenig. I'll wait then that all this stuff has been sorted and merged to send a new patchset.

Thanks,
Arnaud