Skip to contentSkip to conversation

ASoC: alc562[123] / HP t5325 support - try 3

PATCH Superseded Arnaud Patard (Rtp) 2 participants 4 messages Oct 21, 2010

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v3 cover ASoC: alc562[123] / HP t5325 support - try 3

Hi,

It's an other try to get alc562[123] and HP t5325 support merged into ASoC tree. There was not a lot of changes except on places where I got comments (except on the depop stuff). I've also removed the patch on arch/arm/mach-kirkwood/t5325-setup.c which will go through an other route later.

Arnaud

#1 lore raw

PATCH v3 1/2 ASoC: add support for alc562[123] codecs

This patch is adding support for alc562[123] codecs. It's based on the source code available in HP source code and other places.

sound/soc/codecs/Kconfig +5 -0
Index: sound-2.6/sound/soc/codecs/Kconfig
===================================================================
@@ -22,6 +22,7 @@
 	select SND_SOC_AK4535 if I2C
 	select SND_SOC_AK4642 if I2C
 	select SND_SOC_AK4671 if I2C
+	select SND_SOC_ALC562 if I2C
 	select SND_SOC_CQ0093VC if MFD_DAVINCI_VOICECODEC
 	select SND_SOC_CS42L51 if I2C
 	select SND_SOC_CS4270 if I2C
@@ -129,6 +130,9 @@
 config SND_SOC_AK4671
 	tristate
 
+config SND_SOC_ALC5623
+       tristate
+
 config SND_SOC_CQ0093VC
 	tristate
 
@@ -317,3 +321,4 @@
 
 config SND_SOC_WM9090
 	tristate
+
sound/soc/codecs/Makefile +2 -0
Index: sound-2.6/sound/soc/codecs/Makefile
===================================================================
@@ -17,6 +17,7 @@
 snd-soc-l3-objs := l3.o
 snd-soc-max98088-objs := max98088.o
 snd-soc-pcm3008-objs := pcm3008.o
+snd-soc-alc5623-objs := alc5623.o
 snd-soc-spdif-objs := spdif_transciever.o
 snd-soc-ssm2602-objs := ssm2602.o
 snd-soc-stac9766-objs := stac9766.o
@@ -92,6 +93,7 @@
 obj-$(CONFIG_SND_SOC_JZ4740_CODEC)	+= snd-soc-jz4740-codec.o
 obj-$(CONFIG_SND_SOC_MAX98088)	+= snd-soc-max98088.o
 obj-$(CONFIG_SND_SOC_PCM3008)	+= snd-soc-pcm3008.o
+obj-$(CONFIG_SND_SOC_ALC5623)    += snd-soc-alc5623.o
 obj-$(CONFIG_SND_SOC_SPDIF)	+= snd-soc-spdif.o
 obj-$(CONFIG_SND_SOC_SSM2602)	+= snd-soc-ssm2602.o
 obj-$(CONFIG_SND_SOC_STAC9766)	+= snd-soc-stac9766.o
sound/soc/codecs/alc5623.c new file +1148 -0

1,148 lines not on this page · raw message

sound/soc/codecs/alc5623.h new file +161 -0

161 lines not on this page · raw message

include/sound/alc5623.h new file +15 -0
Index: sound-2.6/include/sound/alc5623.h
===================================================================
@@ -0,0 +1,15 @@
+#ifndef _INCLUDE_SOUND_ALC5623_H
+#define _INCLUDE_SOUND_ALC5623_H
+struct alc5623_platform_data {
+	/* configure :                              */
+	/* Lineout/Speaker Amps Vmid ratio control  */
+	/* enable/disable adc/dac high pass filters */
+	unsigned int add_ctrl;
+	/* configure :                              */
+	/* output to enable when jack is low        */
+	/* output to enable when jack is high       */
+	/* jack detect (gpio/nc/jack detect [12]    */
+	unsigned int jack_det_ctrl;
+};
+#endif
+
#2 lore raw

Re: [patch v3 1/2] ASoC: add support for alc562[123] codecs

sound/soc/codecs/alc5623.c line 878

Quoted 6 lines · Arnaud Patard
sound/soc/codecs/alc5623.c new file +6 -0
+static void alc5623_work(struct work_struct *work)
+{
+	struct snd_soc_codec *codec =
+		container_of(work, struct snd_soc_codec, delayed_work.work);
+	alc5623_set_bias_level(codec, codec->bias_level);
+}

Like I said when reviewing the last version please remove this and do the ramping of VMID in line where it's required instead - the framework should support this well enough now. Indeed...

sound/soc/codecs/alc5623.c line 901

Quoted 5 lines
sound/soc/codecs/alc5623.c new file +5 -0
+	/* charge alc5623 caps */
+	if (codec->suspend_bias_level == SND_SOC_BIAS_ON) {
+		alc5623_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
+		codec->bias_level = SND_SOC_BIAS_ON;
+		alc5623_set_bias_level(codec, codec->bias_level);

...it looks like it may just be that the delayed work and associated stuff is left over and can be removed entirely.

#3 lore raw

PATCH v3 2/2 ASoC: kirkwood: Add audio support to hp t5325 thin clients

In reply to Arnaud Patard (Rtp)

This patch is adding support for hp t5325 thin clients. There's a alc5623 codec connected to the i2s interface.

sound/soc/kirkwood/Kconfig +9 -0
Index: sound-2.6/sound/soc/kirkwood/Kconfig
===================================================================
@@ -18,3 +18,12 @@
 	  Say Y if you want to add support for SoC audio on
 	  Openrd Client.
 
+config SND_KIRKWOOD_SOC_T5325
+	tristate "SoC Audio support for HP t5325"
+	depends on SND_KIRKWOOD_SOC && MACH_T5325
+	select SND_KIRKWOOD_SOC_I2S
+	select SND_SOC_ALC5623
+	help
+	  Say Y if you want to add support for SoC audio on
+	  the HP t5325 thin client.
+
sound/soc/kirkwood/Makefile +2 -0
Index: sound-2.6/sound/soc/kirkwood/Makefile
===================================================================
@@ -5,5 +5,7 @@
 obj-$(CONFIG_SND_KIRKWOOD_SOC_I2S) += snd-soc-kirkwood-i2s.o
 
 snd-soc-openrd-objs := kirkwood-openrd.o
+snd-soc-t5325-objs := kirkwood-t5325.o
 
 obj-$(CONFIG_SND_KIRKWOOD_SOC_OPENRD) += snd-soc-openrd.o
+obj-$(CONFIG_SND_KIRKWOOD_SOC_T5325) += snd-soc-t5325.o
sound/soc/kirkwood/kirkwood-t5325.c new file +141 -0

141 lines not on this page · raw message