sctp: remove redundant chunk length check
Subsystems (2)
PATCH 1/1 sctp: remove redundant chunk length check
Checking the chunk length at this point appears redundant, as the rest of the packet gets discarded anyway.
--- net/sctp/sm_statefuns.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)
net/sctp/sm_statefuns.c +0 -6
@@ -3418,12 +3418,6 @@ static sctp_disposition_t sctp_sf_shut_8_4_5(const struct sctp_endpoint *ep,SCTP_INC_STATS (SCTP_MIB_OUTCTRLCHUNKS ); -/* If the chunk length is invalid, we don't want to process -* the reset of the packet. -*/ -if (!sctp_chunk_length_valid (chunk,sizeof (sctp_chunkhdr_t))) -return sctp_sf_pdiscard (ep, asoc, type, arg, commands); -/* We need to discard the rest of the packet to prevent * potential bomming attacks from additional bundled chunks. * This is documented in SCTP Threats ID.
Signature · 1 line
1.7.2.2
Nicolas Kaiser wrote, at 10/21/2010 06:14 PM:
Quoted 4 lines
Checking the chunk length at this point appears redundant, as the rest of the packet gets discarded anyway.
Signed-off-by Nicolas Kaiser <[email protected]>
Yes, indeed.
How did you find this? By reviewing the source code?
Signature · 3 lines
Best Regards ----- Shan Wei
Quoted 21 lines
--- net/sctp/sm_statefuns.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)net/sctp/sm_statefuns.c +0
-6@@ -3418,12 +3418,6 @@ static sctp_disposition_t sctp_sf_shut_8_4_5(const struct sctp_endpoint *ep,SCTP_INC_STATS (SCTP_MIB_OUTCTRLCHUNKS ); -/* If the chunk length is invalid, we don't want to process -* the reset of the packet. -*/ -if (!sctp_chunk_length_valid (chunk,sizeof (sctp_chunkhdr_t))) -return sctp_sf_pdiscard (ep, asoc, type, arg, commands); -/* We need to discard the rest of the packet to prevent * potential bomming attacks from additional bundled chunks. * This is documented in SCTP Threats ID.
* Shan Wei <[email protected]>:
Quoted 7 lines
Nicolas Kaiser wrote, at 10/21/2010 06:14 PM:
Quoted 2 lines
Checking the chunk length at this point appears redundant, as the rest of the packet gets discarded anyway.
Yes, indeed.
How did you find this? By reviewing the source code?
Actually I'm tinkering with Coccinelle patches.
Here's a simple semantic patch, that will give a lot of false positives, and a lot of "if (a) return b; return b;":
// <smpl>
@@
expression a;
statement S;
@@
- if (a)
- {
- S
- }
S
// </smpl>
Best regards,
Nicolas Kaiser