common : bring back some details about technology

PATCH In review Benoît Monin 2 participants 2 messages Oct 21, 2010 – Oct 22, 2010

Share & tools

Benoît Monin

author

2010-10-21 14:07 UTC #0 lore raw

PATCH 1/1 common : bring back some details about technology

Our application require some more details about network technology in use. This patch might be a bit controversial because commit 1e783b3 actively simplified the technology field.

Maybe adding a 'Generation' field ('2G', '2.5G', '3G'...) would be more end-user friendly ?

---
 src/common.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

src/common.c +3 -3

index b5b9a6f..d571d81 100644
@@ -655,15 +655,15 @@ const char *registration_tech_to_string(int tech)
        case ACCESS_TECHNOLOGY_GSM:
                return "gsm";
        case ACCESS_TECHNOLOGY_GSM_COMPACT:
-               return "gsm";
+               return "gprs";
        case ACCESS_TECHNOLOGY_UTRAN:
                return "umts";
        case ACCESS_TECHNOLOGY_GSM_EGPRS:
                return "edge";
        case ACCESS_TECHNOLOGY_UTRAN_HSDPA:
-               return "hspa";
+               return "hsdpa";
        case ACCESS_TECHNOLOGY_UTRAN_HSUPA:
-               return "hspa";
+               return "hsupa";
        case ACCESS_TECHNOLOGY_UTRAN_HSDPA_HSUPA:
                return "hspa";
        case ACCESS_TECHNOLOGY_EUTRAN:

Aki Niemi

2010-10-22 13:29 UTC #1 lore raw

Hi,

2010/10/21 "Benoît Monin" <[email protected]>:

Quoted 15 lines

src/common.c +0 -0
index b5b9a6f..d571d81 100644
@@ -655,15 +655,15 @@ const char *registration_tech_to_string(int tech)
   case ACCESS_TECHNOLOGY_GSM:
   return "gsm";
   case ACCESS_TECHNOLOGY_GSM_COMPACT:
- return "gsm";
+ return "gprs";
   case ACCESS_TECHNOLOGY_UTRAN:
   return "umts";
   case ACCESS_TECHNOLOGY_GSM_EGPRS:
   return "edge";
   case ACCESS_TECHNOLOGY_UTRAN_HSDPA:

Quoted 8 lines

- return "hspa";
+ return "hsdpa";
   case ACCESS_TECHNOLOGY_UTRAN_HSUPA:
- return "hspa";
+ return "hsupa";
   case ACCESS_TECHNOLOGY_UTRAN_HSDPA_HSUPA:
   return "hspa";
   case ACCESS_TECHNOLOGY_EUTRAN:

Do you need to know if the cell supports high speed uplink, downlink or both; or in fact, when uplink or downlink is active (i.e., channel allocated)? Currently the API is telling you the former, and supporting the latter would require changes not only in the D-Bus API, but also in the driver API.

As a side note, I think I was originally proposing using the generation tags, but either way works for me. That is, I consider it 3.5G when at least HSDPA is available.

Cheers,
Aki