rivafb: dubious assignment
PATCH 1/1 rivafb: dubious assignment
A duplicated assignment unconditionally changes max_gfsize to GFIFO_SIZE.
It looks to me like this might not be intended, or is it?
--- drivers/video/riva/riva_hw.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/video/riva/riva_hw.c +0 -1
@@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i vmisses =2 ;if (ainfo->gburst_size =128 ) max_gfsize =GFIFO_SIZE_128 ;else max_gfsize =GFIFO_SIZE ; - max_gfsize =GFIFO_SIZE ;while (1 ) {if (ainfo->vid_en)
Signature · 1 line
1.7.2.2
Quoted 23 lines · Nicolas Kaiser
A duplicated assignment unconditionally changes
max_gfsizetoGFIFO_SIZE.It looks to me like this might not be intended, or is it?
Signed-off-by Nicolas Kaiser <[email protected]>---
drivers/video/riva/riva_hw.c | 1 -1 files changed, 0 insertions(+), 1 deletions(-)drivers/video/riva/riva_hw.c +0
-2@@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i vmisses = 2; if (ainfo->gburst_size = 128) max_gfsize = GFIFO_SIZE_128; else max_gfsize = GFIFO_SIZE; - max_gfsize = GFIFO_SIZE; while (1) { if (ainfo->vid_en) --
Quoted 1 line
1.7.2.2
According to full-history-linux, this comes from the initial drop in 2.3.49pre2, from nVidia code(?), imported by Jeff Garzik.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Quoted 20 lines · Geert Uytterhoeven
Quoted 19 lines · Nicolas Kaiser
A duplicated assignment unconditionally changes
max_gfsizetoGFIFO_SIZE.It looks to me like this might not be intended, or is it?
Signed-off-by Nicolas Kaiser<[email protected]>--- drivers/video/riva/riva_hw.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)drivers/video/riva/riva_hw.c +0
-1@@ -263,7 +263,6 @@ static int nv3_iterate(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_arb_i vmisses =2 ;if (ainfo->gburst_size =128 ) max_gfsize =GFIFO_SIZE_128 ;else max_gfsize =GFIFO_SIZE ; - max_gfsize =GFIFO_SIZE ;
Quoted 8 lines
Quoted 5 lines
drivers/video/riva/riva_hw.c +0
-1while (1 ) {if (ainfo->vid_en) --1.7.2.2
According to full-history-linux, this comes from the initial drop in 2.3.49pre2, from nVidia code(?), imported by Jeff Garzik.
Yep, came straight from X.org driver code... Patch certainly looks
correct, but who knows but NV for sure :)