mlx4_en: Fix out of bounds array access
Subsystems (3)
PATCH 1/1 mlx4_en: Fix out of bounds array access
When searching for a free entry in either mlx4_register_vlan() or mlx4_register_mac(), and there is no free entry, the loop terminates without updating the local variable free thus causing out of array bounds access. Fix this by adding a proper check outside the loop.
--- drivers/net/mlx4/port.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-)
drivers/net/mlx4/port.c +11 -0
@@ -111,6 +111,12 @@ int mlx4_register_mac(struct mlx4_dev *dev, u8 port, u64 mac, int *index) goto out; } } + +if (free <0 ) { + err = -ENOMEM ; + goto out; + } +mlx4_dbg (dev,"Free MAC index is %d\n" , free);if (table->total == table->max) {
@@ -224,6 +230,11 @@ int mlx4_register_vlan(struct mlx4_dev *dev, u8 port, u16 vlan, int *index) } } +if (free <0 ) { + err = -ENOMEM ; + goto out; + } +if (table->total == table->max) {/* No free vlan entries */ err = -ENOSPC ;
Signature · 1 line
1.7.3.1
From: Eli Cohen <[email protected]>
Date: Mon, 25 Oct 2010 14:56:47 +0200
Quoted 6 lines
When searching for a free entry in either
mlx4_register_vlan()ormlx4_register_mac(), and there is no free entry, the loop terminates without updating the local variable free thus causing out of array bounds access. Fix this by adding a proper check outside the loop.Signed-off-by Eli Cohen <eli-VPRAkNaXOzVS1MOuV/[email protected]>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html