ARM: use the same branch insn on all architectures
PATCH 1/1 ARM: use the same branch insn on all architectures
For the "fixloop" implementation in start.S a number of different instructions was used. Unify code so all architectures use "blo" here because it is more robust in case of incorrect alignments.
--- arch/arm/cpu/arm1136/start.S | 2 +- arch/arm/cpu/arm1176/start.S | 2 +- arch/arm/cpu/arm720t/start.S | 2 +- arch/arm/cpu/arm920t/start.S | 2 +- arch/arm/cpu/arm925t/start.S | 2 +- arch/arm/cpu/arm946es/start.S | 2 +- arch/arm/cpu/arm_intcm/start.S | 2 +- arch/arm/cpu/ixp/start.S | 2 +- arch/arm/cpu/lh7a40x/start.S | 2 +- arch/arm/cpu/s3c44b0/start.S | 2 +- arch/arm/cpu/sa1100/start.S | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-)
arch/arm/cpu/arm1136/start.S +1 -1
@@ -262,7 +262,7 @@ fixnext: str r1, [r0] add r2, r2, #8 /* each rel.dyn entry is 8 bytes */ cmp r2, r3 - ble fixloop + blo fixloop #endif #endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
arch/arm/cpu/arm1176/start.S +1 -1
@@ -305,7 +305,7 @@ fixloop: str r4, [r2] add r2, r2, #4 cmp r2, r3 - bne fixloop + blo fixloop #endif #endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
arch/arm/cpu/arm720t/start.S +1 -1
@@ -222,7 +222,7 @@ fixloop: str r4, [r2] add r2, r2, #4 cmp r2, r3 - bne fixloop + blo fixloop #endif #endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
arch/arm/cpu/arm920t/start.S +1 -1
@@ -267,7 +267,7 @@ fixloop: str r4, [r2] add r2, r2, #4 cmp r2, r3 - bne fixloop + blo fixloop #endif #endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
arch/arm/cpu/arm925t/start.S +1 -1
@@ -259,7 +259,7 @@ fixloop: str r4, [r2] add r2, r2, #4 cmp r2, r3 - bne fixloop + blo fixloop #endif #endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
arch/arm/cpu/arm946es/start.S +1 -1
@@ -228,7 +228,7 @@ fixloop: str r4, [r2] add r2, r2, #4 cmp r2, r3 - bne fixloop + blo fixloop #endif #endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
arch/arm/cpu/arm_intcm/start.S +1 -1
@@ -226,7 +226,7 @@ fixloop: str r4, [r2] add r2, r2, #4 cmp r2, r3 - bne fixloop + blo fixloop #endif #endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
arch/arm/cpu/ixp/start.S +1 -1
@@ -351,7 +351,7 @@ fixloop: str r4, [r2] add r2, r2, #4 cmp r2, r3 - bne fixloop + blo fixloop #endif #endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
arch/arm/cpu/lh7a40x/start.S +1 -1
@@ -240,7 +240,7 @@ fixloop: str r4, [r2] add r2, r2, #4 cmp r2, r3 - bne fixloop + blo fixloop #endif #endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
arch/arm/cpu/s3c44b0/start.S +1 -1
@@ -212,7 +212,7 @@ fixloop: str r4, [r2] add r2, r2, #4 cmp r2, r3 - bne fixloop + blo fixloop #endif /* now copy to sram the interrupt vector
arch/arm/cpu/sa1100/start.S +1 -1
@@ -216,7 +216,7 @@ fixloop: str r4, [r2] add r2, r2, #4 cmp r2, r3 - bne fixloop + blo fixloop #endif #endif /* #ifndef CONFIG_SKIP_RELOCATE_UBOOT */
Signature · 1 line
1.7.2.3
PATCH 1/1 ARM: use the same branch insn on all architectures
Hello Wolfgang,
Quoted 11 lines · Wolfgang Denk
For the "fixloop" implementation in
start.Sa number of different instructions was used. Unify code so all architectures use "blo" here because it is more robust in case of incorrect alignments.Signed-off-by Wolfgang Denk <[email protected]>Cc Albert ARIBAUD <[email protected]>Cc Minkyu Kang <[email protected]>Cc Sandeep Paulraj <[email protected]>Cc Prafulla Wadaskar <[email protected]>Cc Stefano Babic <[email protected]>Cc Marek Vasut <[email protected]>
Quoted 13 lines
--- arch/arm/cpu/arm1136/start.S | 2 +- arch/arm/cpu/arm1176/start.S | 2 +- arch/arm/cpu/arm720t/start.S | 2 +- arch/arm/cpu/arm920t/start.S | 2 +- arch/arm/cpu/arm925t/start.S | 2 +- arch/arm/cpu/arm946es/start.S | 2 +- arch/arm/cpu/arm_intcm/start.S | 2 +- arch/arm/cpu/ixp/start.S | 2 +- arch/arm/cpu/lh7a40x/start.S | 2 +- arch/arm/cpu/s3c44b0/start.S | 2 +- arch/arm/cpu/sa1100/start.S | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-)
bye,
Heiko
Signature · 2 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Wolfgang Denk
AppliedPATCH 1/1 ARM: use the same branch insn on all architectures
In reply to Wolfgang DenkQuoted 11 lines · In message <[email protected]> you wrote:
For the "fixloop" implementation in
start.Sa number of different instructions was used. Unify code so all architectures use "blo" here because it is more robust in case of incorrect alignments.Signed-off-by Wolfgang Denk <[email protected]>Cc Albert ARIBAUD <[email protected]>Cc Minkyu Kang <[email protected]>Cc Sandeep Paulraj <[email protected]>Cc Prafulla Wadaskar <[email protected]>Cc Stefano Babic <[email protected]>Cc Marek Vasut <[email protected]>
Quoted 13 lines
--- arch/arm/cpu/arm1136/start.S | 2 +- arch/arm/cpu/arm1176/start.S | 2 +- arch/arm/cpu/arm720t/start.S | 2 +- arch/arm/cpu/arm920t/start.S | 2 +- arch/arm/cpu/arm925t/start.S | 2 +- arch/arm/cpu/arm946es/start.S | 2 +- arch/arm/cpu/arm_intcm/start.S | 2 +- arch/arm/cpu/ixp/start.S | 2 +- arch/arm/cpu/lh7a40x/start.S | 2 +- arch/arm/cpu/s3c44b0/start.S | 2 +- arch/arm/cpu/sa1100/start.S | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-)
Applied.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The Buddha, the Godhead, resides quite as comfortably in the circuits
of a digital computer or the gears of a cycle transmission as he does
at the top of a mountain or in the petals of a flower.
- R. Pirsig, "Zen and the Art of Motorcycle Maintenance"