cmd_net: drop spurious comma in U_BOOT_CMD
PATCH 1/1 cmd_net: drop spurious comma in U_BOOT_CMD
Building for boards that have CONFIG_CMD_CDP enabled fail with:
cmd_net.c:301: error: expected expression before ',' token
--- common/cmd_net.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
common/cmd_net.c +1 -1
@@ -297,7 +297,7 @@ int do_cdp (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])U_BOOT_CMD ( cdp,1 ,1 , do_cdp, - "Perform CDP network configuration", +"Perform CDP network configuration" );#endif
Signature · 1 line
1.7.3.1
Wolfgang Denk
AppliedPATCH 1/1 cmd_net: drop spurious comma in U_BOOT_CMD
Dear Mike Frysinger,
Quoted 7 lines · In message <[email protected]> you wrote:
Building for boards that have
CONFIG_CMD_CDPenabled fail with:
cmd_net.c:301: error: expected expression before ',' tokenSigned-off-by Mike Frysinger <[email protected]>--- common/cmd_net.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de America has been discovered before, but it has always been hushed up. - Oscar Wilde
PATCH 1/1 cmd_net: drop spurious comma in U_BOOT_CMD
Quoted 6 lines · In message <[email protected]> I wrote:
Dear Mike Frysinger,
Quoted 3 lines · In message <[email protected]> you wrote:
Building for boards that have
CONFIG_CMD_CDPenabled fail with:
cmd_net.c:301: error: expected expression before ',' token
Quoted 6 lines
Quoted 4 lines
Signed-off-by Mike Frysinger <[email protected]>--- common/cmd_net.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)Applied, thanks.
I wish I had tested this before applying - and even more I wish you had run MAKEALL as requested when sumbitting patches.
Reverted, as it breaks building of some boards:
Configuring for LANTEC board...
cmd_net.c:301:1: error: macro "U_BOOT_CMD" requires 6 arguments, but only 5 given cmd_net.c:298: warning: data definition has no type or storage class cmd_net.c:298: warning: type defaults to 'int' in declaration of 'U_BOOT_CMD' make[1]: *** [/work/wd/tmp-ppc/common/cmd_net.o] Error 1
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Unsichtbar macht sich die Dummheit, indem sie immer gr??ere Ausma?e annimmt. -- Bertold Brecht: Der Tui-Roman
PATCH 1/1 cmd_net: drop spurious comma in U_BOOT_CMD
Quoted 9 lines · On Tuesday, October 26, 2010 17:45:10 Wolfgang Denk wrote:
Quoted 5 lines · In message <[email protected]> I wrote:
Quoted 2 lines · Mike Frysinger
Building for boards that have
CONFIG_CMD_CDPenabled fail with:
cmd_net.c:301: error: expected expression before ',' tokenApplied, thanks.
I wish I had tested this before applying - and even more I wish you had run MAKEALL as requested when sumbitting patches.
actually, as i had stated in one of my other patches, i *was* running MAKEALL but the vast majority of boards were failing (probably because of your patches you noted some time later). for the few boards that didnt fail in that way, they were failing *because of this code*.
i wrote the patch *because* MAKEALL was reporting failures due to this code. but perhaps the failure i was seeing was just fallout of the bad patches you had pushed already. i guess i dont really care because none of my boards were or are failing due to this, and i'll stop trying to fix other people's board failures.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101026/ed655b40/attachment.pgp