ipv6 POSTDAD fix
Subsystems (4)
cover ipv6 POSTDAD fix
Dave,
running into a refcnt problem with a bond device,
I propose this patch to solve it.
Regards, Ursula
PATCH 1/1 ipv6: fix refcnt problem related to POSTDAD state
Subject: [patch 1/1] [PATCH BUG_FIX] ipv6: fix refcnt problem related to POSTDAD state
From: Ursula Braun <[email protected]>
After running this bonding setup script
modprobe bonding miimon=100 mode=0 max_bonds=1
ifconfig bond0 10.1.1.1/16
ifenslave bond0 eth1
ifenslave bond0 eth3
on s390 with qeth-driven slaves, modprobe -r fails with this message
unregister_netdevice: waiting for bond0 to become free. Usage count = 1
due to twice detection of duplicate address.
Problem is caused by a missing decrease of ifp->refcnt in addrconf_dad_failure. An extra call of in6_ifa_put(ifp) solves it.
Problem has been introduced with commit f2344a131bccdbfc5338e17fa71a807dee7944fa.
--- net/ipv6/addrconf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
net/ipv6/addrconf.c +3 -1
@@ -1426,8 +1426,10 @@ void addrconf_dad_failure(struct inet6_i {struct inet6_dev *idev = ifp->idev; -if (addrconf_dad_end (ifp)) +if (addrconf_dad_end (ifp)) { +in6_ifa_put (ifp);return ; + }if (net_ratelimit ()) printk(KERN_INFO "%s: IPv6 duplicate address %pI6c detected!\n",
Re: [patch 1/1] [PATCH BUG_FIX] ipv6: fix refcnt problem related to POSTDAD state
Quoted 16 lines · Ursula Braun
Subject: [patch 1/1] [PATCH
BUG_FIX] ipv6: fix refcnt problem related to POSTDAD stateFrom: Ursula Braun <[email protected]>
After running this bonding setup script
modprobe bonding miimon=100 mode=0 max_bonds=1
ifconfig bond0 10.1.1.1/16
ifenslave bond0 eth1
ifenslave bond0 eth3
on s390 with qeth-driven slaves, modprobe -r fails with this message
unregister_netdevice: waiting for bond0 to become free. Usage count = 1
due to twice detection of duplicate address.
Problem is caused by a missing decrease ofifp->refcntinaddrconf_dad_failure. An extra call ofin6_ifa_put(ifp)solves it.
Problem has been introduced with commitf2344a131bccdbfc5338e17fa71a807dee7944fa.
Quoted 2 lines
Signed-off-by Ursula Braun <[email protected]>Cc David S. Miller <[email protected]>
Thanks for catching this!
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [patch 1/1] [PATCH BUG_FIX] ipv6: fix refcnt problem related to POSTDAD state
From: Herbert Xu <[email protected]>
Date: Mon, 25 Oct 2010 16:01:32 -0700
Quoted 17 lines · Ursula Braun
Quoted 16 lines
Subject: [patch 1/1] [PATCH
BUG_FIX] ipv6: fix refcnt problem related to POSTDAD stateFrom: Ursula Braun <[email protected]>
After running this bonding setup script
modprobe bonding miimon=100 mode=0 max_bonds=1
ifconfig bond0 10.1.1.1/16
ifenslave bond0 eth1
ifenslave bond0 eth3
on s390 with qeth-driven slaves, modprobe -r fails with this message
unregister_netdevice: waiting for bond0 to become free. Usage count = 1
due to twice detection of duplicate address.
Problem is caused by a missing decrease ofifp->refcntinaddrconf_dad_failure. An extra call ofin6_ifa_put(ifp)solves it.
Problem has been introduced with commitf2344a131bccdbfc5338e17fa71a807dee7944fa.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Ursula Braun <[email protected]>Cc David S. Miller <[email protected]>Acked-by Herbert Xu <[email protected]>Thanks for catching this!
Applied, thanks everyone.