Skip to contentSkip to conversation

mcu25: fix out of tree building

PATCH New Wolfgang Denk 1 participant 3 messages Oct 27, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mcu25: fix out of tree building

Out of tree building of the Netstal hcu4 and hcu5 boards failed like that:

Configuring for mcu25 board...
Assembler messages: Fatal error: can't create /work/wd/tmp-ppc/board/netstal/mcu25/../common/fixed_sdram.o: No such file or directory Assembler messages: Fatal error: can't create /work/wd/tmp-ppc/board/netstal/mcu25/../common/nm_bsp.o: No such file or directory

Adapt (and simplify) the Makefile.

---
 board/netstal/mcu25/Makefile |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)
board/netstal/mcu25/Makefile +10 -10
index 6722d53..cd62642 100644
@@ -19,24 +19,24 @@
 #
 
 include $(TOPDIR)/config.mk
+ifneq ($(OBJTREE),$(SRCTREE))
+$(shell mkdir -p $(obj)../common)
+endif
 
 LIB	= $(obj)lib$(BOARD).a
 
-# NOBJS : Netstal common objects
-NOBJS	= fixed_sdram.o nm_bsp.o
-COBJS	= $(BOARD).o
-SOBJS	=
+COBJS	= $(BOARD).o \
+	../common/fixed_sdram.o \
+	../common/nm_bsp.o
 
-SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c) $(addprefix ../common/,$(NOBJS:.o=.c))
+SRCS	:= $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))
-NOBJS	:= $(addprefix $(obj)../common/,$(NOBJS))
-SOBJS	:= $(addprefix $(obj),$(SOBJS))
 
-$(LIB):	$(OBJS) $(SOBJS) $(NOBJS)
-	$(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) $(NOBJS)
+$(LIB):	$(OBJS)
+	$(AR) $(ARFLAGS) $@ $^
 
 clean:
-	rm -f $(SOBJS) $(OBJS)
+	rm -f $(OBJS)
 
 distclean:	clean
 	rm -f $(LIB) core *.bak $(obj).depend
Signature · 1 line
1.7.2.3
#1 lore raw

PATCH 1/1 mcu25: fix out of tree building

Quoted 4 lines · In message <[email protected]> you wrote:

Out of tree building of the Netstal hcu4 and hcu5 boards failed like that:

Configuring for mcu25 board...

Please s/hcu4 and hcu5 boards/mcu25 board/ in the first line of
the commit message.

[not resending; will fix when applying, assuming no other comments come in.]

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Insults are effective only where emotion is present.
	-- Spock, "Who Mourns for Adonais?"  stardate 3468.1
#2 lore raw

PATCH 1/1 mcu25: fix out of tree building

In reply to Wolfgang Denk

Dear Wolfgang Denk,

Quoted 7 lines · In message <[email protected]> you wrote:

Out of tree building of the Netstal hcu4 and hcu5 boards failed like that:

Configuring for mcu25 board...
Assembler messages: Fatal error: can't create /work/wd/tmp-ppc/board/netstal/mcu25/../common/fixed_sdram.o: No such file or directory Assembler messages: Fatal error: can't create /work/wd/tmp-ppc/board/netstal/mcu25/../common/nm_bsp.o: No such file or directory

Quoted 7 lines

Adapt (and simplify) the Makefile.

---
 board/netstal/mcu25/Makefile |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

Applied (with the ...of the Netstal mcu25 board... fix)

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Lots of people drink from the wrong bottle sometimes.
	-- Edith Keeler, "The City on the Edge of Forever",
	   stardate unknown