Skip to contentSkip to conversation

mmc: new legacy MMC/SPI driver

PATCH New Mike Frysinger 2 participants 7 messages Oct 28, 2010 – Dec 12, 2010 1 message not in the archive MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: new legacy MMC/SPI driver

From: Hans Eklund <[email protected]>

---
i'd like this considered for merging even though this is using the legacy framework. there have been attempts to rewrite the driver on top of the new framework, but all attempts thus far have failed. this driver however is continued to be used by many people/boards in production setups. thus i'd like this merged until we have a new working driver to replace it.

 drivers/mmc/Makefile  |    3 +
 drivers/mmc/spi_mmc.c | 1111 +++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 1114 insertions(+), 0 deletions(-)
 create mode 100644 drivers/mmc/spi_mmc.c
drivers/mmc/Makefile +3 -0
index 2ead634..5d8f05b 100644
@@ -23,6 +23,9 @@
 
 include $(TOPDIR)/config.mk
 
+# stick it up here to avoid conflicts
+COBJS-$(CONFIG_SPI_MMC) += spi_mmc.o
+
 LIB	:= $(obj)libmmc.a
 
 COBJS-$(CONFIG_ATMEL_MCI) += atmel_mci.o
drivers/mmc/spi_mmc.c new file +1111 -0

1,111 lines not on this page · raw message

Signature · 1 line
1.7.3.2
#1 lore raw

PATCH 1/1 mmc: new legacy MMC/SPI driver

Quoted 1 line · Mike Frysinger

+ * Licensed under the GPL-2 or later.

Could you include the normal GPL license text instead? We have in-house tools that scan for the strings in that text to determine the license of the file.

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#2 lore raw

PATCH 1/1 mmc: new legacy MMC/SPI driver

Quoted 6 lines · On Wednesday, October 27, 2010 21:30:37 Timur Tabi wrote:
Quoted 1 line · Mike Frysinger

+ * Licensed under the GPL-2 or later.

Could you include the normal GPL license text instead? We have in-house tools that scan for the strings in that text to determine the license of the file.

update your tools then
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101027/17ed9ae9/attachment.pgp

#3 lore raw

PATCH 1/1 mmc: new legacy MMC/SPI driver

Quoted 5 lines · Mike Frysinger
Quoted 3 lines

Could you include the normal GPL license text instead? ?We have in-house tools that scan for the strings in that text to determine the license of the file.

update your tools then

Come on, Mike, that's not fair. I'm asking for a simple change that doesn't inconvenience you, and this is how you respond? Are you having a bad day or something?

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#4 lore raw

PATCH 1/1 mmc: new legacy MMC/SPI driver

Quoted 10 lines · On Wednesday, October 27, 2010 21:53:22 Timur Tabi wrote:
Quoted 5 lines · Mike Frysinger
Quoted 3 lines

Could you include the normal GPL license text instead? We have in-house tools that scan for the strings in that text to determine the license of the file.

update your tools then

Come on, Mike, that's not fair. I'm asking for a simple change that doesn't inconvenience you, and this is how you respond? Are you having a bad day or something?

i'm not about to go through the u-boot/linux/uClibc/whatever tree to satisfy a random licensing tool. it'd make a lot more sense to fix your tool.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101027/b05fcfe0/attachment.pgp

A message that is not in the archive (sent off-list or not yet received): 5610599F537DD74A8D1F5CC946A7507303479410@az33exm25.fsl.freescale.net

#6 lore raw

PATCH 1/1 mmc: new legacy MMC/SPI driver

Quoted 7 lines · On Thu, Oct 28, 2010 at 8:06 AM, Tabi Timur-B04825 wrote:
Quoted 2 lines · Mike Frysinger

i'm not about to go through the u-boot/linux/uClibc/whatever tree to satisfy a random licensing tool. ?it'd make a lot more sense to fix your tool.

I'm not asking you to go through existing code and make changes. ?You're posting a patch for a new file. ?Why can't this particular new file use the convention that most of U-Boot uses?

i'm not going to change my coding style to suite some random tool when it makes a lot more sense to fix the tool. i constantly merge code using this style and will continue to do so in the future. -mike

#7 lore raw

PATCH 1/1 mmc: new legacy MMC/SPI driver

In reply to Mike Frysinger
Quoted 5 lines · On Wednesday, October 27, 2010 21:23:17 Mike Frysinger wrote:

i'd like this considered for merging even though this is using the legacy framework. there have been attempts to rewrite the driver on top of the new framework, but all attempts thus far have failed. this driver however is continued to be used by many people/boards in production setups. thus i'd like this merged until we have a new working driver to replace it.

can we get this into next ? or at least some indication that it's going to be merged post 2010.12 ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101212/89dbcd25/attachment.pgp