ixgb: call pci_disable_device in ixgb_remove
Subsystems (2)
PATCH 1/1 ixgb: call pci_disable_device in ixgb_remove
From: Emil Tantilov <[email protected]>
ixgb fails to work after reload on recent kernels:
rmmod ixgb (dev->current_state = PCI_UNKNOWN)
modprobe ixgb (pci_enable_device will bail leaving current_state to PCI_UNKNOWN) ifup eth0do_IRQ: 2.82 No irq handler for vector (irq -1)
The issue was exposed by commit fcd097f31a6ee207cc0c3da9cccd2a86d4334785
PCI: MSI: Remove unsafe and unnecessary hardware access
which avoids HW writes for power states != PCI_D0
---
drivers/net/ixgb/ixgb_main.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ixgb/ixgb_main.c +1 -0
@@ -533,6 +533,7 @@ ixgb_remove(struct pci_dev *pdev)pci_release_regions (pdev);free_netdev (netdev); +pci_disable_device (pdev); }/**
From: Jeff Kirsher <[email protected]>
Date: Thu, 28 Oct 2010 03:59:49 -0700
Quoted 12 lines
From: Emil Tantilov <[email protected]>
ixgb fails to work after reload on recent kernels:
rmmod ixgb (
dev->current_state=PCI_UNKNOWN)
modprobe ixgb (pci_enable_devicewill bail leavingcurrent_statetoPCI_UNKNOWN) ifup eth0do_IRQ: 2.82 No irq handler for vector (irq -1)The issue was exposed by commit
fcd097f31a6ee207cc0c3da9cccd2a86d4334785
PCI: MSI: Remove unsafe and unnecessary hardware access
Quoted 6 lines
which avoids HW writes for power states !=
PCI_D0CC Ben Hutchings <[email protected]>Signed-off-by Emil Tantilov <[email protected]>Tested-by Jeff Pieper <[email protected]>Signed-off-by Jeff Kirsher <[email protected]>
Applied.