Skip to contentSkip to conversation

ixgb: call pci_disable_device in ixgb_remove

PATCH Applied Jeff Kirsher 2 participants 2 messages Oct 28, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgb: call pci_disable_device in ixgb_remove

From: Emil Tantilov <[email protected]>

ixgb fails to work after reload on recent kernels:

rmmod ixgb (dev->current_state = PCI_UNKNOWN)
modprobe ixgb (pci_enable_device will bail leaving current_state to PCI_UNKNOWN) ifup eth0
do_IRQ: 2.82 No irq handler for vector (irq -1)

The issue was exposed by commit fcd097f31a6ee207cc0c3da9cccd2a86d4334785
PCI: MSI: Remove unsafe and unnecessary hardware access

which avoids HW writes for power states != PCI_D0

---

 drivers/net/ixgb/ixgb_main.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ixgb/ixgb_main.c +1 -0
index 666207a..caa8192 100644
@@ -533,6 +533,7 @@ ixgb_remove(struct pci_dev *pdev)
 	pci_release_regions(pdev);
 
 	free_netdev(netdev);
+	pci_disable_device(pdev);
 }
 
 /**
maintainer Applied
#1 lore raw

From: Jeff Kirsher <[email protected]>
Date: Thu, 28 Oct 2010 03:59:49 -0700

Quoted 12 lines

From: Emil Tantilov <[email protected]>

ixgb fails to work after reload on recent kernels:

rmmod ixgb (dev->current_state = PCI_UNKNOWN)
modprobe ixgb (pci_enable_device will bail leaving current_state to PCI_UNKNOWN) ifup eth0
do_IRQ: 2.82 No irq handler for vector (irq -1)

The issue was exposed by commit fcd097f31a6ee207cc0c3da9cccd2a86d4334785
PCI: MSI: Remove unsafe and unnecessary hardware access

Quoted 6 lines

which avoids HW writes for power states != PCI_D0

Applied.