u64_stats_sync.h: move "inline" before the return type
PATCH 1/1 u64_stats_sync.h: move "inline" before the return type
With the option -Wextra, gcc emits warnings like this one:
include/linux/u64_stats_sync.h:70: warning: 'inline' is not at beginning of declaration
While this is legal according to the C standard, it would be more readable to have all modifiers before the return type.
--- include/linux/u64_stats_sync.h | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-)
include/linux/u64_stats_sync.h +6 -6
@@ -67,21 +67,21 @@ struct u64_stats_sync {#endif }; -static void inline u64_stats_update_begin (struct u64_stats_sync *syncp) +static inline void u64_stats_update_begin (struct u64_stats_sync *syncp) {#if BITS_PER_LONG ==32 && defined(CONFIG_SMP )write_seqcount_begin (&syncp->seq);#endif } -static void inline u64_stats_update_end (struct u64_stats_sync *syncp) +static inline void u64_stats_update_end (struct u64_stats_sync *syncp) {#if BITS_PER_LONG ==32 && defined(CONFIG_SMP )write_seqcount_end (&syncp->seq);#endif } -static unsigned int inline u64_stats_fetch_begin (const struct u64_stats_sync *syncp) +static inline unsigned int u64_stats_fetch_begin (const struct u64_stats_sync *syncp) {#if BITS_PER_LONG ==32 && defined(CONFIG_SMP )return read_seqcount_begin (&syncp->seq);
@@ -93,7 +93,7 @@ static unsigned int inline u64_stats_fetch_begin(const struct u64_stats_sync *sy#endif } -static bool inline u64_stats_fetch_retry (const struct u64_stats_sync *syncp, +static inline bool u64_stats_fetch_retry (const struct u64_stats_sync *syncp,unsigned int start) {#if BITS_PER_LONG ==32 && defined(CONFIG_SMP )
@@ -112,7 +112,7 @@ static bool inline u64_stats_fetch_retry(const struct u64_stats_sync *syncp,* - UP 32bit must disable BH. * - 64bit have no problem atomically reading u64 values, irq safe. */ -static unsigned int inline u64_stats_fetch_begin_bh (const struct u64_stats_sync *syncp) +static inline unsigned int u64_stats_fetch_begin_bh (const struct u64_stats_sync *syncp) {#if BITS_PER_LONG ==32 && defined(CONFIG_SMP )return read_seqcount_begin (&syncp->seq);
@@ -124,7 +124,7 @@ static unsigned int inline u64_stats_fetch_begin_bh(const struct u64_stats_sync#endif } -static bool inline u64_stats_fetch_retry_bh (const struct u64_stats_sync *syncp, +static inline bool u64_stats_fetch_retry_bh (const struct u64_stats_sync *syncp,unsigned int start) {#if BITS_PER_LONG ==32 && defined(CONFIG_SMP )
Quoted 7 lines · Max Kellermann
With the option -Wextra, gcc emits warnings like this one:
include/linux/u64_stats_sync.h:70: warning: 'inline' is not at beginning of declarationWhile this is legal according to the C standard, it would be more readable to have all modifiers before the return type.
---
Acked-by Eric Dumazet <[email protected]>