ipc: shm: fix information leak to userland
A message that is not in the archive (sent off-list or not yet received): 1288450677.3964.1.camel@dan
This one already got taken care of by Kees Cook:
http://lkml.org/lkml/2010/10/6/486
Thanks,
Dan
Quoted 22 lines
Structure
shmid_dsis copied to userland with shm_unused{,2,3} fields unitialized. It leads to leaking of contents of kernel stack memory.Acked-by Al Viro <[email protected]>Signed-off-by Vasiliy Kulikov <[email protected]>---
Compile tested.ipc/shm.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)ipc/shm.c +1
-0@@ -479,6 +479,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_ {struct shmid_ds out; +memset (&out,0 ,sizeof (out));ipc64_perm_to_ipc_perm (&in->shm_perm, &out.shm_perm); out.shm_segsz = in->shm_segsz; out.shm_atime = in->shm_atime;
Hi Dan,
Quoted 3 lines · Dan Rosenberg
This one already got taken care of by Kees Cook:
After 25 days it is still not in linux-next. Also the second hunk is IMO odd as all five fields are initialized:
case IPC_OLD:
{
struct shminfo out;
if(in->shmmax > INT_MAX)
out.shmmax = INT_MAX;
else
out.shmmax = (int)in->shmmax;
out.shmmin = in->shmmin;
out.shmmni = in->shmmni;
out.shmseg = in->shmseg;
out.shmall = in->shmall;
return copy_to_user(buf, &out, sizeof(out));
}/* Obsolete, used only for backwards compatibility */
struct shminfo {
int shmmax;
int shmmin;
int shmmni;
int shmseg;
int shmall;
};And I see no padding hole in shminfo.
Quoted 21 lines
Thanks,
DanQuoted 18 lines
Structure
shmid_dsis copied to userland with shm_unused{,2,3} fields unitialized. It leads to leaking of contents of kernel stack memory.Acked-by Al Viro <[email protected]>Signed-off-by Vasiliy Kulikov <[email protected]>---
Compile tested.ipc/shm.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)ipc/shm.c +0
-0@@ -479,6 +479,7 @@ static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_ {struct shmid_ds out;
Quoted 6 lines
ipc/shm.c static inline unsigned long copy_shmid_to_user(void __user *buf, struct shmid64_ · line 485
Quoted 4 lines
ipc/shm.c +1
-0+memset (&out,0 ,sizeof (out));ipc64_perm_to_ipc_perm (&in->shm_perm, &out.shm_perm); out.shm_segsz = in->shm_segsz; out.shm_atime = in->shm_atime;
Thanks,
Signature · 1 line
Vasiliy