kzalloc with swapped params in l2tp_dfs_seq_open
Subsystems (2)
PATCH 1/1 kzalloc with swapped params in l2tp_dfs_seq_open
Hi,
'sparse' spotted that the parameters to kzalloc in l2tp_dfs_seq_open
were swapped.
Tested on current git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
at 1792f17b7210280a3d7ff29da9614ba779cfcedb build, boots and I can see that directory, but there again I could see /sys/kernel/debug/l2tp with it swapped; I don't have any l2tp in use.
--
net/l2tp/l2tp_debugfs.c +1 -1
@@ -249,7 +249,7 @@ static int l2tp_dfs_seq_open(struct inode *inode, struct file *file)struct seq_file *seq;int rc = -ENOMEM ; - pd =kzalloc (GFP_KERNEL ,sizeof (*pd)); + pd =kzalloc (sizeof (*pd),GFP_KERNEL );if (pd ==NULL ) goto out;
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ gro.gilbert @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
From: "Dr. David Alan Gilbert" <[email protected]>
Date: Sun, 31 Oct 2010 17:26:03 +0000
Quoted 10 lines
Hi,
'sparse' spotted that the parameters to kzalloc inl2tp_dfs_seq_open
were swapped.Tested on current
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
at1792f17b7210280a3d7ff29da9614ba779cfcedbbuild, boots and I can see that directory, but there again I could see/sys/kernel/debug/l2tpwith it swapped; I don't have any l2tp in use.Signed-off-by Dr. David Alan Gilbert <[email protected]>
Applied, thank you.