Skip to contentSkip to conversation

spi/pl022: fix erroneous platform data in U300

PATCH New Linus Walleij 2 participants 2 messages Oct 21, 2010 – Nov 1, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi/pl022: fix erroneous platform data in U300

This fixes an erroneous use of LSB first in the U300 machine, the PL022 used in U300 is a standard ARM core that doesn't support this bit so it should never have been set.

---
 arch/arm/mach-u300/spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-u300/spi.c +1 -1
index 779abf7..5767208 100644
@@ -67,7 +67,7 @@ static struct spi_board_info u300_spi_devices[] = {
 		.bus_num        = 0, /* Only one bus on this chip */
 		.chip_select    = 0,
 		/* Means SPI_CS_HIGH, change if e.g low CS */
-		.mode           = SPI_MODE_1 | SPI_LSB_FIRST | SPI_LOOP,
+		.mode           = SPI_MODE_1 | SPI_LOOP,
 	},
 #endif
 };
Signature · 1 line
1.6.3.3
Applied
#1 lore raw

PATCH 1/1 spi/pl022: fix erroneous platform data in U300

Quoted 6 lines · Linus Walleij

This fixes an erroneous use of LSB first in the U300 machine, the PL022 used in U300 is a standard ARM core that doesn't support this bit so it should never have been set.

Applied, thanks.

Quoted 20 lines
---
 arch/arm/mach-u300/spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-u300/spi.c +1 -1
index 779abf7..5767208 100644
@@ -67,7 +67,7 @@ static struct spi_board_info u300_spi_devices[] = {
 		.bus_num        = 0, /* Only one bus on this chip */
 		.chip_select    = 0,
 		/* Means SPI_CS_HIGH, change if e.g low CS */
-		.mode           = SPI_MODE_1 | SPI_LSB_FIRST | SPI_LOOP,
+		.mode           = SPI_MODE_1 | SPI_LOOP,
 	},
 #endif
 };
Signature · 1 line
1.6.3.3