saa7164: make buffer smaller

PATCH New Dan Carpenter 1 participant 1 message Nov 2, 2010

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-11-02 03:22 UTC #0 lore raw

PATCH 1/1 saa7164: make buffer smaller

This isn't a runtime bug, it's just to make static checkers happy.

In vidioc_querycap() we copy a saa7164_dev ->name driver array into a v4l2_capability -> driver array. The ->driver array is only 16 chars long so ->name also can't be more than 16 characters.

The ->name gets set in v4l2_capability() and it always is less than 16 characters so we can easily make the buffer smaller.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/video/saa7164/saa7164.h +1 -1

index 1d9c5cb..8b3e844 100644
@@ -448,7 +448,7 @@ struct saa7164_dev {
 	int	nr;
 	int	hwrevision;
 	u32	board;
-	char	name[32];
+	char	name[16];
 
 	/* firmware status */
 	struct saa7164_fw_status	fw_status;

drivers/media/video/saa7164/saa7164-core.c +1 -1

index e1bac50..b66f78f 100644
@@ -1001,7 +1001,7 @@ static int saa7164_dev_setup(struct saa7164_dev *dev)
 	atomic_inc(&dev->refcount);
 	dev->nr = saa7164_devcount++;
 
-	sprintf(dev->name, "saa7164[%d]", dev->nr);
+	snprintf(dev->name, sizeof(dev->name), "saa7164[%d]", dev->nr);
 
 	mutex_lock(&devlist);
 	list_add_tail(&dev->devlist, &saa7164_devlist);