Skip to contentSkip to conversation

Staging: frontier: alphatrack: Fixed coding style issues

PATCH In review Audun Hoem 2 participants 3 messages Nov 2, 2010 Staging

lore
Share & tools
lore

Audun Hoem

author
#0 lore raw

PATCH 1/1 Staging: frontier: alphatrack: Fixed coding style issues

From: audun <[email protected]>

I cleaned up the coding style.

---
 drivers/staging/frontier/alphatrack.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
drivers/staging/frontier/alphatrack.c +6 -3
index ef7fbf8..9d439fa 100644
@@ -88,8 +88,11 @@ MODULE_SUPPORTED_DEVICE("Frontier Designs Alphatrack Control Surface");
 static int debug = ALPHATRACK_DEBUG;
 
 /* Use our own dbg macro */
-#define dbg_info(dev, format, arg...) do \
-    { if (debug) dev_info(dev , format , ## arg); } while (0)
+#define dbg_info(dev, format, arg...) \
+do {
+	if (debug)
+		dev_info(dev , format , ## arg);
+} while (0)
 
 #define alphatrack_ocmd_info(dev, cmd, format, arg...)
 
@@ -769,7 +772,7 @@ static int usb_alphatrack_probe(struct usb_interface *intf,
 	}
 
 	dev->write_buffer =
-	    kmalloc(sizeof(struct alphatrack_ocmd) * true_size, GFP_KERNEL);
+	    kmalloc(sizeof(struct alphatrack_ocmd) *true_size, GFP_KERNEL);
 
 	if (!dev->write_buffer) {
 		dev_err(&intf->dev, "Couldn't allocate write_buffer\n");
Signature · 1 line
1.7.0.4
#1 lore raw
Quoted 1 line · Audun Hoem

From: audun <[email protected]>

Minor nit, use your full name here in the From: line.

Quoted 4 lines

I cleaned up the coding style.

Like you used here, that's the correct thing to put here.

Quoted 9 lines
---
 drivers/staging/frontier/alphatrack.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
drivers/staging/frontier/alphatrack.c +0 -0
index ef7fbf8..9d439fa 100644

drivers/staging/frontier/alphatrack.c MODULE_SUPPORTED_DEVICE("Frontier Designs Alphatrack Control Surface"); · line 95

Quoted 10 lines
drivers/staging/frontier/alphatrack.c +5 -2
@@ -88,8 +88,11 @@ MODULE_SUPPORTED_DEVICE("Frontier Designs Alphatrack Control Surface");
 static int debug = ALPHATRACK_DEBUG;
 
 /* Use our own dbg macro */
-#define dbg_info(dev, format, arg...) do \
-    { if (debug) dev_info(dev , format , ## arg); } while (0)
+#define dbg_info(dev, format, arg...) \
+do {
+	if (debug)
+		dev_info(dev , format , ## arg);
+} while (0)

In the future, you can probably just remove this macro and switch the dev_info() users in the driver to use dev_dbg() as it handles the debug toggle already. Then you can remove the debug variable as well as the debugging is handled by the dynamic debug core code in the kernel.

Thanks for the patch, I'll queue it up later and you will get an automated email when it goes into my tree.

greg k-h

#2 lore raw
In reply to Audun Hoem
Quoted 14 lines · Audun Hoem

From: Audun Hoem <[email protected]>

I cleaned up the coding style.

---
 drivers/staging/frontier/alphatrack.c |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
drivers/staging/frontier/alphatrack.c +0 -0
index ef7fbf8..9d439fa 100644

drivers/staging/frontier/alphatrack.c MODULE_SUPPORTED_DEVICE("Frontier Designs Alphatrack Control Surface"); · line 95

Quoted 10 lines
drivers/staging/frontier/alphatrack.c +5 -2
@@ -88,8 +88,11 @@ MODULE_SUPPORTED_DEVICE("Frontier Designs Alphatrack Control Surface");
 static int debug = ALPHATRACK_DEBUG;
 
 /* Use our own dbg macro */
-#define dbg_info(dev, format, arg...) do \
-    { if (debug) dev_info(dev , format , ## arg); } while (0)
+#define dbg_info(dev, format, arg...) \
+do {
+	if (debug)
+		dev_info(dev , format , ## arg);
+} while (0)

Oops, no, this doesn't work, and it breaks the build. Did you test your patch after you made it?

(hint, you need to add a few more '\' characters...)

Care to redo this and resend it?

thanks,

greg k-h