Skip to contentSkip to conversation

Display 3 decimal places in raw sensors output

PATCH In review Jean Delvare 3 participants 4 messages Nov 2, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Display 3 decimal places in raw sensors output

I would like the raw output of "sensors" to display 3 decimal places as most sensor types use at the sysfs interface. This will make it easier for us to help users find out correct scaling factors when needed. Instead of telling them to go read the raw sysfs attributes, they can just report the output of "sensors -u -c /dev/null".

Objection anyone?

---
 prog/sensors/chips.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
prog/sensors/chips.c +1 -1
@@ -58,7 +58,7 @@ void print_chip_raw(const sensors_chip_n
 						sub->name,
 						sensors_strerror(err));
 				else
-					printf("  %s: %.2f\n", sub->name, val);
+					printf("  %s: %.3f\n", sub->name, val);
 			} else
 				printf("(%s)\n", label);
 		}
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
#1 lore raw

Re: [lm-sensors] [PATCH] Display 3 decimal places in raw sensors

Quoted 7 lines · Jean Delvare

I would like the raw output of "sensors" to display 3 decimal places as most sensor types use at the sysfs interface. This will make it easier for us to help users find out correct scaling factors when needed. Instead of telling them to go read the raw sysfs attributes, they can just report the output of "sensors -u -c /dev/null".

Objection anyone?

No objection. Makes sense to me.

Guenter

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#2 lore raw

Re: [lm-sensors] [PATCH] Display 3 decimal places in raw sensors

In reply to Jean Delvare
Quoted 26 lines

I would like the raw output of "sensors" to display 3 decimal places as most sensor types use at the sysfs interface. This will make it easier for us to help users find out correct scaling factors when needed. Instead of telling them to go read the raw sysfs attributes, they can just report the output of "sensors -u -c /dev/null".

Objection anyone?

---
 prog/sensors/chips.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lm-sensors.orig/prog/sensors/chips.c 2010-07-01 14:33:21.000000000
+0200
+++ lm-sensors/prog/sensors/chips.c 2010-11-02 13:24:12.000000000 +0100

prog/sensors/chips.c +1 -2
@@ -58,7 +58,7 @@ void print_chip_raw(const sensors_chip_n
 						sub->name,
 						sensors_strerror(err));
 				else
-					printf("  %s: %.2f\n", sub->name, val);
+					printf("  %s: %.3f\n", sub->name, val);
 			} else
 				printf("(%s)\n", label);
 		}
 
 
--
Quoted 2 lines

Jean Delvare

No objection to the concept. I appreciate the precision.

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

#3 lore raw

Re: [lm-sensors] [PATCH] Display 3 decimal places in raw sensors

In reply to Jean Delvare
Quoted 25 lines · Jeff Rickman
Quoted 25 lines

I would like the raw output of "sensors" to display 3 decimal places as most sensor types use at the sysfs interface. This will make it easier for us to help users find out correct scaling factors when needed. Instead of telling them to go read the raw sysfs attributes, they can just report the output of "sensors -u -c /dev/null".

Objection anyone?

---
 prog/sensors/chips.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lm-sensors.orig/prog/sensors/chips.c 2010-07-01 14:33:21.000000000
+0200
+++ lm-sensors/prog/sensors/chips.c 2010-11-02 13:24:12.000000000 +0100

prog/sensors/chips.c +1 -1
@@ -58,7 +58,7 @@ void print_chip_raw(const sensors_chip_n
 						sub->name,
 						sensors_strerror(err));
 				else
-					printf("  %s: %.2f\n", sub->name, val);
+					printf("  %s: %.3f\n", sub->name, val);
 			} else
 				printf("(%s)\n", label);
 		}
Quoted 5 lines
Quoted 3 lines

--
Jean Delvare

No objection to the concept. I appreciate the precision.

OK, I'll apply the patch tomorrow then.

Jeff, I take the opportunity to let you know that I am unable to e-mail you directly. Your mail server keeps rejecting my attempts, and it has been that way for months. I even tried an alternative sending server on my end but it did not help.

Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors