Skip to contentSkip to conversation

usb: gadget: goku_udc: add registered flag bit

PATCH In review Andy Whitcroft 3 participants 5 messages Nov 3, 2010 – Nov 9, 2010 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: gadget: goku_udc: add registered flag bit

The commit below cleaned up error handling, in part by introducing a registered flag bit. This however was not added to the device structure leding to build failures:

commit 319feaabb6c7ccd90da6e3207563c265da7d21ae
Author: Dan Carpenter <[email protected]>
Date: Tue Oct 5 18:55:34 2010 +0200

usb: gadget: goku_udc: Fix error path

Add the missing registered flag bit.

---
 drivers/usb/gadget/goku_udc.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/usb/gadget/goku_udc.h +2 -1
index 566cb23..e7e0c69 100644
@@ -251,7 +251,8 @@ struct goku_udc {
 					got_region:1,
 					req_config:1,
 					configured:1,
-					enabled:1;
+					enabled:1,
+					registered:1;
 
 	/* pci state used to access those endpoints */
 	struct pci_dev			*pdev;
Signature · 1 line
1.7.1
#1 lore raw
Quoted 11 lines · Andy Whitcroft

The commit below cleaned up error handling, in part by introducing a registered flag bit. This however was not added to the device structure leding to build failures:

commit 319feaabb6c7ccd90da6e3207563c265da7d21ae
Author: Dan Carpenter <[email protected]>
Date: Tue Oct 5 18:55:34 2010 +0200

usb: gadget: goku_udc: Fix error path

Add the missing registered flag bit.

Dan, is this patch below the correct fix? Or should we be looking at some other flag?

[Andy, please always cc: the original patch author when reporting problems, to not do so is a bit rude and causes others (i.e. me) extra work.]

thanks,

greg k-h

Quoted 22 lines
---
 drivers/usb/gadget/goku_udc.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/usb/gadget/goku_udc.h +2 -1
index 566cb23..e7e0c69 100644
@@ -251,7 +251,8 @@ struct goku_udc {
 					got_region:1,
 					req_config:1,
 					configured:1,
-					enabled:1;
+					enabled:1,
+					registered:1;
 
 	/* pci state used to access those endpoints */
 	struct pci_dev			*pdev;
Signature · 1 line
1.7.1
Acked-by
#2 lore raw
Quoted 9 lines · Greg KH
Quoted 8 lines · Andy Whitcroft

The commit below cleaned up error handling, in part by introducing a registered flag bit. This however was not added to the device structure leding to build failures:

commit 319feaabb6c7ccd90da6e3207563c265da7d21ae
Author: Dan Carpenter <[email protected]>
Date: Tue Oct 5 18:55:34 2010 +0200

Quoted 8 lines
Quoted 3 lines

usb: gadget: goku_udc: Fix error path

Add the missing registered flag bit.

Dan, is this patch below the correct fix? Or should we be looking at some other flag?

Yes. This was my fault. I forgot to send you that part of the patch.

regards,
dan carpenter

#3 lore raw
Quoted 15 lines · Dan Carpenter
Quoted 14 lines · Greg KH
Quoted 11 lines · Andy Whitcroft

The commit below cleaned up error handling, in part by introducing a registered flag bit. This however was not added to the device structure leding to build failures:

commit 319feaabb6c7ccd90da6e3207563c265da7d21ae
Author: Dan Carpenter <[email protected]>
Date: Tue Oct 5 18:55:34 2010 +0200

usb: gadget: goku_udc: Fix error path

Add the missing registered flag bit.

Quoted 7 lines
Quoted 3 lines

Dan, is this patch below the correct fix? Or should we be looking at some other flag?

Yes. This was my fault. I forgot to send you that part of the patch.

Thanks for the quick response, I'll queue this up.

greg k-h

#4 lore raw
In reply to Greg KH
Quoted 14 lines · Greg KH
Quoted 11 lines · Andy Whitcroft

The commit below cleaned up error handling, in part by introducing a registered flag bit. This however was not added to the device structure leding to build failures:

commit 319feaabb6c7ccd90da6e3207563c265da7d21ae
Author: Dan Carpenter <[email protected]>
Date: Tue Oct 5 18:55:34 2010 +0200

usb: gadget: goku_udc: Fix error path

Add the missing registered flag bit.

Quoted 6 lines

Dan, is this patch below the correct fix? Or should we be looking at some other flag?

[Andy, please always cc: the original patch author when reporting problems, to not do so is a bit rude and causes others (i.e. me) extra work.]

Appologies. I thought I used get_maintainers which I thought pulled in the recent committers. More care next time.

-apw