Skip to contentSkip to conversation

crypto: api.c: add comments to crypto_alg_lookup and crypto_alg_larval_lookup

PATCH In review Mark Allyn 2 participants 2 messages Nov 4, 2010 Crypto API

lore
Share & tools
lore

Mark Allyn

author
#0 lore raw

PATCH 1/1 crypto: api.c: add comments to crypto_alg_lookup and crypto_alg_larval_lookup

This is resubmitted due to errors in style

---
 crypto/api.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)
crypto/api.c +15 -0
index 033a714..0314083 100644
@@ -193,6 +193,13 @@ static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg)
 	return alg;
 }
 
+/**
+ * crypto_alg_lookup() - return crypto_alg structure for an algorithm
+ * @name:	text string containing name of algorithm
+ * @type:	crypto type defined in include/linux/crypto.h
+ * @mask:	mask of allowable crypto types (use or'd list
+ *		of types as defined in include/linux/crypto.h)
+ */
 struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
 {
 	struct crypto_alg *alg;
@@ -205,6 +212,14 @@ struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
 }
 EXPORT_SYMBOL_GPL(crypto_alg_lookup);
 
+/**
+ * crypto_alg_larval_lookup() - returns large value (larval) crypto_alg
+ *	structure for an algorithm
+ * @name:	text string containing name of algorithm
+ * @type:	crypto type defined in include/linux/crypto.h
+ * @mask:	mask of allowable crypto types (use or'd list
+ *		of types as defined in include/linux/crypto.h)
+ */
 struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask)
 {
 	struct crypto_alg *alg;
Signature · 1 line
1.6.3.3
#1 lore raw
Quoted 26 lines · On Thu, 4 Nov 2010 12:49:48 -0700 Mark Allyn wrote:

This is resubmitted due to errors in style

---
 crypto/api.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)
crypto/api.c +7 -0
index 033a714..0314083 100644
@@ -193,6 +193,13 @@ static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg)
 	return alg;
 }
 
+/**
+ * crypto_alg_lookup() - return crypto_alg structure for an algorithm
+ * @name:	text string containing name of algorithm
+ * @type:	crypto type defined in include/linux/crypto.h
+ * @mask:	mask of allowable crypto types (use or'd list
+ *		of types as defined in include/linux/crypto.h)
+ */
 struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
 {
 	struct crypto_alg *alg;

crypto/api.c struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask) · line 217

Quoted 6 lines
crypto/api.c +3 -0
@@ -205,6 +212,14 @@ struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
 }
 EXPORT_SYMBOL_GPL(crypto_alg_lookup);
 
+/**
+ * crypto_alg_larval_lookup() - returns large value (larval) crypto_alg
+ *	structure for an algorithm

That function name still does not match the actual name below.

crypto/api.c struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask) · line 225

Quoted 9 lines
crypto/api.c +5 -0
+ * @name:	text string containing name of algorithm
+ * @type:	crypto type defined in include/linux/crypto.h
+ * @mask:	mask of allowable crypto types (use or'd list
+ *		of types as defined in include/linux/crypto.h)
+ */
 struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask)
 {
 	struct crypto_alg *alg;

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***