Pull request for branch 2010.11-various-bumps
Hello,
Here is a small serie, for various stuff. Apart from the directfb/sawman bump, almost everything is independent.
Pick what you like !
Available at git://git.potipota.net/buildroot 2010.11-various-bumps
Regards,
--
Lionel Landwerlin
PATCH 1/12 sh: add /dev/ttyASx console devices
From: Lionel Landwerlin <[email protected]>
--- target/generic/Config.in | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)
target/generic/Config.in +12 -0
@@ -45,6 +45,18 @@ config BR2_TARGET_GENERIC_GETTY_TTYAMA2 config BR2_TARGET_GENERIC_GETTY_TTYAMA3 bool "ttyAMA3" depends on BR2_arm +config BR2_TARGET_GENERIC_GETTY_TTYAS0 + bool "ttyAS0" + depends on BR2_sh +config BR2_TARGET_GENERIC_GETTY_TTYAS1 + bool "ttyAS1" + depends on BR2_sh +config BR2_TARGET_GENERIC_GETTY_TTYAS2 + bool "ttyAS2" + depends on BR2_sh +config BR2_TARGET_GENERIC_GETTY_TTYAS3 + bool "ttyAS3" + depends on BR2_sh config BR2_TARGET_GENERIC_GETTY_TTYSAC0 bool "ttySAC0" depends on BR2_arm
Signature · 1 line
1.7.2.3
PATCH 1/12 sh: add /dev/ttyASx console devices
Quoted 3 lines · On Thu, 4 Nov 2010 03:50:20 +0100 llandwerlin at gmail.com wrote:
From: Lionel Landwerlin <[email protected]>
Signed-off-by Lionel Landwerlin <[email protected]>
I'd prefer to see
http://lists.busybox.net/pipermail/buildroot/2010-September/037987.html
be merged into Buildroot.
Basically, the idea of the patch is to get rid of the choice, and use a basic free form field instead.
Regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/12 sh: add /dev/ttyASx console devices
Quoted 5 lines · Thomas Petazzoni
Quoted 2 lines · On Thu, ?4 Nov 2010 03:50:20 +0100 llandwerlin at gmail.com wrote:
From: Lionel Landwerlin <[email protected]>
Quoted 9 lines
Quoted 1 line
Signed-off-by Lionel Landwerlin <[email protected]>I'd prefer to see
http://lists.busybox.net/pipermail/buildroot/2010-September/037987.html
be merged into Buildroot.Basically, the idea of the patch is to get rid of the choice, and use a basic free form field instead.
I wasn't aware of this one, but indeed a text entry would be better. Thanks for pointing out.
Regards,
--
Lionel Landwerlin
PATCH 2/12 rsync: drop special case now managed in Makefile.package.in
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/rsync/rsync.mk | 11 +++-------- 1 files changed, 3 insertions(+), 8 deletions(-)
package/rsync/rsync.mk +3 -8
@@ -9,14 +9,9 @@ RSYNC_SOURCE:=rsync-$(RSYNC_VERSION).tar.gz RSYNC_SITE:=http://rsync.samba.org/ftp/rsync/src RSYNC_INSTALL_STAGING:=NO RSYNC_INSTALL_TARGET:=YES -RSYNC_CONF_OPT=$(if $(BR2_ENABLE_DEBUG),--enable-debug,--disable-debug) -ifeq ($(BR2_ENABLE_DEBUG),y) -RSYNC_INSTALL_TARGET_OPT:=DESTDIR=$(TARGET_DIR) INSTALLCMD='./install-sh -c' \ - install -else -RSYNC_INSTALL_TARGET_OPT:=DESTDIR=$(TARGET_DIR) INSTALLCMD='./install-sh -c' \ - STRIPPROG="$(TARGET_STRIP)" install-strip -endif + +RSYNC_MAKE_ENV = STRIPPROG="$(STRIPCMD)" + RSYNC_CONF_OPT:=--with-included-popt $(eval $(call AUTOTARGETS,package,rsync))
Signature · 1 line
1.7.2.3
PATCH 2/12 rsync: drop special case now managed in Makefile.package.in
Hello,
Quoted 1 line · On Thu, 4 Nov 2010 03:50:21 +0100 llandwerlin at gmail.com wrote:
-RSYNC_CONF_OPT=$(if $(BR2_ENABLE_DEBUG),--enable-debug,--disable-debug)
As far as I can see, passing --{enable,disable}-debug is not handled by the autotools infrastructure. Maybe those are not needed, but this change is not transparent.
package/rsync/rsync.mk RSYNC_SOURCE:=rsync-$(RSYNC_VERSION).tar.gz · line 13
Quoted 9 lines
package/rsync/rsync.mk +2
-7-ifeq ($(BR2_ENABLE_DEBUG),y) -RSYNC_INSTALL_TARGET_OPT:=DESTDIR=$(TARGET_DIR) INSTALLCMD='./install-sh -c' \ - install -else -RSYNC_INSTALL_TARGET_OPT:=DESTDIR=$(TARGET_DIR) INSTALLCMD='./install-sh -c' \ - STRIPPROG="$(TARGET_STRIP)" install-strip -endif + +RSYNC_MAKE_ENV = STRIPPROG="$(STRIPCMD)"
The autotools infrastructure no longer uses the "install-strip" target. So is this still useful ?
Other question: the autotools infrastructure does not pass INSTALLCMD. If it's really needed by this package, then this patch will break the package.
Regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 3/12 autotools: fix MESSAGE calls
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/Makefile.autotools.in | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
package/Makefile.autotools.in +2 -2
@@ -138,7 +138,7 @@ $(2)_POST_PATCH_HOOKS += UPDATE_CONFIG_HOOK # Hook to patch libtool to make it work properly for cross-compilation # define LIBTOOL_PATCH_HOOK - @$(call MESSAGE,"Patching libtool") + @$$(call MESSAGE,"Patching libtool") $(Q)if test "$$($$(PKG)_LIBTOOL_PATCH)" = "YES" \ -a "$$($$(PKG)_AUTORECONF)" != "YES"; then \ for i in `find $$($$(PKG)_SRCDIR) -name ltmain.sh`; do \
@@ -162,7 +162,7 @@ endif # Hook to autoreconf the package if needed # define AUTORECONF_HOOK - @$(call MESSAGE,"Autoreconfiguring") + @$$(call MESSAGE,"Autoreconfiguring") $(Q)cd $$($$(PKG)_SRCDIR) && $(AUTORECONF) $$($$(PKG)_AUTORECONF_OPT) $(Q)if test "$$($$(PKG)_LIBTOOL_PATCH)" = "YES"; then \ for i in `find $$($$(PKG)_SRCDIR) -name ltmain.sh`; do \
Signature · 1 line
1.7.2.3
PATCH 3/12 autotools: fix MESSAGE calls
Quoted 3 lines · On Thu, 4 Nov 2010 03:50:22 +0100 llandwerlin at gmail.com wrote:
From: Lionel Landwerlin <[email protected]>
Signed-off-by Lionel Landwerlin <[email protected]>
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 3/12 autotools: fix MESSAGE calls
In reply to llandwerlin at gmail.comQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin <[email protected]> writes:
llandwerlin> From: Lionel Landwerlin <[email protected]> llandwerlin> Signed-off-by: Lionel Landwerlin <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 4/12 autotools: introduce $(PKG_NAME)_AUTORECONF_ENV/$(PKG_NAME)_AUTORECONF_OPT variables
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
Rather than defining the AUTORECONF variable containing the path to the autoreconf tool + all its arguments, we split the variable in two. There is now :
- AUTORECONF which contains the path to the autoreconf tool,
- $(PKG_NAME)_AUTORECONF_OPT which contains the autoreconf arguments,
- and we add $(PKG_NAME)_AUTORECONF_ENV which contains the autoreconf environment variables.
This allow us to define a specific setup to run autoreconf for both target and host as well as per package if needed.
--- docs/buildroot.html | 35 +++++++++++++++++++++++++++-------- package/Makefile.autotools.in | 19 ++++++++++++++++++- package/autoconf/autoconf.mk | 2 +- package/automake/automake.mk | 5 +++-- 4 files changed, 49 insertions(+), 12 deletions(-)
docs/buildroot.html +27 -8
@@ -1253,15 +1253,34 @@ LIBFOO_POST_PATCH_HOOKS += LIBFOO_POST_PATCH_FIXUP pass to make in the build step. These are passed after the <code>make</code> command. By default, empty.</li> - <li><code>LIBFOO_AUTORECONF</code>, tells whether the package should - be autoreconfigured or not (i.e, if the configure script and - Makefile.in files should be re-generated by re-running autoconf, - automake, libtool, etc.). Valid values are <code>YES</code> and - <code>NO</code>. By default, the value is <code>NO</code></li> - - <li><code>LIBFOO_AUTORECONF_OPT</code> to specify additional options + <li><code>LIBFOO_AUTORECONF</code>, tells whether the package + should be autoreconfigured or not (i.e, if the configure script + and Makefile.in files should be re-generated by re-running + autoconf, automake, libtool, etc.). Valid values + are <code>YES</code> and <code>NO</code>. By default, the value + is <code>NO</code></li> + + <li><code>LIBFOO_AUTORECONF_OPT</code> to specify additional + options passed to the <i>autoreconf</i> program + if <code>LIBFOO_AUTORECONF=YES</code>. By default, empty.</li> + + <li><code>LIBFOO_AUTORECONF_ENV</code>, to specify environment + variables to pass to <i>autoreconf</i> program if + <code>LIBFOO_AUTORECONF=YES</code>. By default, it depends + whether we're building a package for the host or target, but it + should always define the following variables : + <ul> + <li>ACLOCAL</li> + <li>AUTOCONF</li> + <li>AUTOHEADER</li> + <li>AUTOMAKE</li> + <li>LIBTOOLIZE</li> + </ul></li> + + <li><code>LIBFOO_AUTORECONF_OPT</code>, to specify options passed to the <i>autoreconf</i> program if - <code>LIBFOO_AUTORECONF=YES</code>. By default, empty.</li> + <code>LIBFOO_AUTORECONF=YES</code>. By default, <code>-f -i -I + "$(ACLOCAL_DIR)"</code>.</li> <li><code>LIBFOO_LIBTOOL_PATCH</code> tells whether the Buildroot patch to fix libtool cross-compilation issues should be applied or
package/Makefile.autotools.in +18 -1
@@ -62,8 +62,25 @@ $(2)_CONF_OPT ?= $(2)_MAKE ?= $(MAKE) $(2)_MAKE_ENV ?= $(2)_MAKE_OPT ?= +ifeq ($(5),host) $(2)_AUTORECONF ?= NO -$(2)_AUTORECONF_OPT ?= +$(2)_AUTORECONF_OPT ?= -f -i -I "$$(ACLOCAL_HOST_DIR)" +$(2)_AUTORECONF_ENV ?= $$(HOST_CONFIGURE_OPTS) \ + ACLOCAL="$$(ACLOCAL)" \ + AUTOCONF="$$(AUTOCONF)" \ + AUTOHEADER="$$(AUTOHEADER)" \ + AUTOMAKE="$$(AUTOMAKE)" \ + LIBTOOLIZE="$$(LIBTOOLIZE)" +else +$(2)_AUTORECONF ?= YES +$(2)_AUTORECONF_OPT ?= -f -i -I "$$(ACLOCAL_STAGING_DIR)" +$(2)_AUTORECONF_ENV ?= $$(TARGET_CONFIGURE_OPTS) \ + ACLOCAL="$$(ACLOCAL)" \ + AUTOCONF="$$(AUTOCONF)" \ + AUTOHEADER="$$(AUTOHEADER)" \ + AUTOMAKE="$$(AUTOMAKE)" \ + LIBTOOLIZE="$$(LIBTOOLIZE)" +endif $(2)_USE_CONFIG_CACHE ?= $(if $(BR2_CONFIG_CACHE),YES,NO) $(2)_INSTALL_STAGING_OPT ?= DESTDIR=$$(STAGING_DIR) install $(2)_INSTALL_TARGET_OPT ?= DESTDIR=$$(TARGET_DIR) install
package/autoconf/autoconf.mk +1 -1
@@ -23,4 +23,4 @@ $(eval $(call AUTOTARGETS,package,autoconf,host)) # variables used by other packages AUTOCONF:=$(HOST_DIR)/usr/bin/autoconf AUTOHEADER:=$(HOST_DIR)/usr/bin/autoheader -AUTORECONF=$(HOST_CONFIGURE_OPTS) ACLOCAL="$(ACLOCAL)" AUTOCONF="$(AUTOCONF)" AUTOHEADER="$(AUTOHEADER)" AUTOMAKE="$(AUTOMAKE)" $(HOST_DIR)/usr/bin/autoreconf -f -i -I "$(ACLOCAL_DIR)" +AUTORECONF=$(HOST_DIR)/usr/bin/autoreconf
package/automake/automake.mk +3 -2
@@ -22,5 +22,6 @@ $(eval $(call AUTOTARGETS,package,automake,host)) # variables used by other packages AUTOMAKE = $(HOST_DIR)/usr/bin/automake -ACLOCAL_DIR = $(STAGING_DIR)/usr/share/aclocal -ACLOCAL = $(HOST_DIR)/usr/bin/aclocal -I $(ACLOCAL_DIR) +ACLOCAL_STAGING_DIR = $(STAGING_DIR)/usr/share/aclocal +ACLOCAL_HOST_DIR = $(HOST_DIR)/usr/share/aclocal +ACLOCAL = $(HOST_DIR)/usr/bin/aclocal
Signature · 1 line
1.7.2.3
PATCH 4/12 autotools: introduce $(PKG_NAME)_AUTORECONF_ENV/$(PKG_NAME)_AUTORECONF_OPT variables
Hello,
Quoted 11 lines · On Thu, 4 Nov 2010 03:50:23 +0100 llandwerlin at gmail.com wrote:
Rather than defining the AUTORECONF variable containing the path to the autoreconf tool + all its arguments, we split the variable in two. There is now :
- AUTORECONF which contains the path to the autoreconf tool,
- $(PKG_NAME)_AUTORECONF_OPT which contains the autoreconf arguments,- and we add $(PKG_NAME)_AUTORECONF_ENV which contains the autoreconf environment variables.
This allow us to define a specific setup to run autoreconf for both target and host as well as per package if needed.
Ok on the principle, but see comment below.
docs/buildroot.html LIBFOO_POST_PATCH_HOOKS += LIBFOO_POST_PATCH_FIXUP · line 1265
Quoted 3 lines
docs/buildroot.html +3
-0+ <li><code>LIBFOO_AUTORECONF_OPT</code> to specify additional + options passed to the <i>autoreconf</i> program + if <code>LIBFOO_AUTORECONF=YES</code>. By default, empty.</li>
Seems to be a duplication of :
docs/buildroot.html LIBFOO_POST_PATCH_HOOKS += LIBFOO_POST_PATCH_FIXUP · line 1283
Quoted 5 lines
docs/buildroot.html +3
-1+ <li><code>LIBFOO_AUTORECONF_OPT</code>, to specify options passed to the <i>autoreconf</i> program if - <code>LIBFOO_AUTORECONF=YES</code>. By default, empty.</li> + <code>LIBFOO_AUTORECONF=YES</code>. By default, <code>-f -i -I + "$(ACLOCAL_DIR)"</code>.</li>
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 4/12 autotools: introduce $(PKG_NAME)_AUTORECONF_ENV/$(PKG_NAME)_AUTORECONF_OPT variables
Ok... this set of patch is a bunch of crap...
That would teach me to rebase things at 3:30am :)
Thanks again for reviewing.
Regards,
--
Lionel Landwerlin
Quoted 42 lines · Thomas Petazzoni
Hello,
Quoted 11 lines · On Thu, ?4 Nov 2010 03:50:23 +0100 llandwerlin at gmail.com wrote:
Rather than defining the AUTORECONF variable containing the path to the autoreconf tool + all its arguments, we split the variable in two. There is now :
? ? ? - AUTORECONF which contains the path to the autoreconf tool, ? ? ? - $(PKG_NAME)_AUTORECONF_OPT which contains the autoreconf arguments,? ? ? - and we add $(PKG_NAME)_AUTORECONF_ENV which contains the autoreconf ? ? ? ? environment variables.
This allow us to define a specific setup to run autoreconf for both target and host as well as per package if needed.
Ok on the principle, but see comment below.
Quoted 3 lines
+ ? ? ?<li><code>LIBFOO_AUTORECONF_OPT</code> to specify additional
+ ? ? ?options passed to the <i>autoreconf</i> program
+ ? ? ?if <code>LIBFOO_AUTORECONF=YES</code>. By default, empty.</li>Seems to be a duplication of :
Quoted 5 lines
+ ? ? ?<li><code>LIBFOO_AUTORECONF_OPT</code>, to specify options ? ? ? ?passed to the <i>autoreconf</i> program if
- ? ? ?<code>LIBFOO_AUTORECONF=YES</code>. By default, empty.</li>
+ ? ? ?<code>LIBFOO_AUTORECONF=YES</code>. By default, <code>-f -i -I
+ ? ? ?"$(ACLOCAL_DIR)"</code>.</li>Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
PATCH 4/12 autotools: introduce $(PKG_NAME)_AUTORECONF_ENV/$(PKG_NAME)_AUTORECONF_OPT variables
Quoted 2 lines · On Thu, 4 Nov 2010 14:49:36 +0100 Lionel Landwerlin <[email protected]>…
Ok... this set of patch is a bunch of crap...
That would teach me to rebase things at 3:30am :)
Hum, why ? Most of the patches look ok to me.
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 5/12 package: move autoreconfigure step to pre configure hook
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/Makefile.autotools.in | 2 +- package/Makefile.package.in | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-)
package/Makefile.autotools.in +1 -1
@@ -194,7 +194,7 @@ define AUTORECONF_HOOK endef ifeq ($$($(2)_AUTORECONF),YES) -$(2)_POST_PATCH_HOOKS += AUTORECONF_HOOK +$(2)_PRE_CONFIGURE_HOOKS += AUTORECONF_HOOK $(2)_DEPENDENCIES += host-automake host-autoconf host-libtool endif
package/Makefile.package.in +2 -0
@@ -261,6 +261,7 @@ $(BUILD_DIR)/%/.stamp_patched: # Configure $(BUILD_DIR)/%/.stamp_configured: + $(foreach hook,$($(PKG)_PRE_CONFIGURE_HOOKS),$(call $(hook))$(sep)) @$(call MESSAGE,"Configuring") $($(PKG)_CONFIGURE_CMDS) $(foreach hook,$($(PKG)_POST_CONFIGURE_HOOKS),$(call $(hook))$(sep))
@@ -410,6 +411,7 @@ $(2)_TARGET_DIRCLEAN = $$($(2)_DIR)/.stamp_dircleaned # post-steps hooks $(2)_POST_EXTRACT_HOOKS ?= $(2)_POST_PATCH_HOOKS ?= +$(2)_PRE_CONFIGURE_HOOKS ?= $(2)_POST_CONFIGURE_HOOKS ?= $(2)_POST_BUILD_HOOKS ?= $(2)_POST_INSTALL_HOOKS ?=
Signature · 1 line
1.7.2.3
PATCH 5/12 package: move autoreconfigure step to pre configure hook
Quoted 3 lines · On Thu, 4 Nov 2010 03:50:24 +0100 llandwerlin at gmail.com wrote:
From: Lionel Landwerlin <[email protected]>
Signed-off-by Lionel Landwerlin <[email protected]>
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 5/12 package: move autoreconfigure step to pre configure hook
In reply to llandwerlin at gmail.comQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin <[email protected]> writes:
llandwerlin> From: Lionel Landwerlin <[email protected]> llandwerlin> Signed-off-by: Lionel Landwerlin <[email protected]>
Thanks, committed. You forgot to update the documentation, but I've done that.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 6/12 gdk-pixbuf/libgtk2: move gdk-pixbuf loader cache setup script
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/gdk-pixbuf/S26gdk-pixbuf | 19 +++++++++++++++++++ package/gdk-pixbuf/gdk-pixbuf.mk | 4 ++++ package/libgtk2/S26libgtk2 | 19 ------------------- package/libgtk2/libgtk2.mk | 1 - 4 files changed, 23 insertions(+), 20 deletions(-) create mode 100644 package/gdk-pixbuf/S26gdk-pixbuf delete mode 100644 package/libgtk2/S26libgtk2
package/gdk-pixbuf/S26gdk-pixbuf new file +19 -0
@@ -0,0 +1,19 @@ +#!/bin/sh +# +# run pgdk-pixbuf-query-loaders if needed + +FILE=/usr/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache + +case "$1" in + start|"") + if [ ! -f "$FILE" ] ; then + /usr/bin/gdk-pixbuf-query-loaders --update-cache + fi + ;; + stop) + ;; + *) + echo "Usage: $0 {start|stop}" >&2 + exit 1 + ;; +esac
package/gdk-pixbuf/gdk-pixbuf.mk +4 -0
@@ -40,6 +40,10 @@ endif GDK_PIXBUF_DEPENDENCIES += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext libintl) host-pkg-config libglib2 libiconv +define GDK_PIXBUF_POST_INSTALL_TWEAKS + $(INSTALL) -m 755 package/gdk-pixbuf/S26gdk-pixbuf $(TARGET_DIR)/etc/init.d/ +endef + $(eval $(call AUTOTARGETS,package,gdk-pixbuf)) HOST_GDK_PIXBUF_CONF_OPT = \
package/libgtk2/S26libgtk2 deleted +0 -19
@@ -1,19 +0,0 @@ -#!/bin/sh -# -# run pgdk-pixbuf-query-loaders if needed - -FILE=/usr/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache - -case "$1" in - start|"") - if [ ! -f "$FILE" ] ; then - /usr/bin/gdk-pixbuf-query-loaders --update-cache - fi - ;; - stop) - ;; - *) - echo "Usage: $0 {start|stop}" >&2 - exit 1 - ;; -esac
package/libgtk2/libgtk2.mk +0 -1
@@ -115,7 +115,6 @@ LIBGTK2_CONF_OPT += --disable-cups endif define LIBGTK2_POST_INSTALL_TWEAKS - $(INSTALL) -m 755 package/libgtk2/S26libgtk2 $(TARGET_DIR)/etc/init.d/ rm -rf $(TARGET_DIR)/usr/share/gtk-2.0/demo $(TARGET_DIR)/usr/bin/gtk-demo endef
Signature · 1 line
1.7.2.3
PATCH 6/12 gdk-pixbuf/libgtk2: move gdk-pixbuf loader cache setup script
Quoted 4 lines · On Thu, Nov 4, 2010 at 4:50 AM, <[email protected]> wrote:
From: Lionel Landwerlin <[email protected]>
Signed-off-by Lionel Landwerlin <[email protected]>---
[...]
package/gdk-pixbuf/gdk-pixbuf.mk endif · line 46
Quoted 12 lines
package/gdk-pixbuf/gdk-pixbuf.mk +4
-0@@ -40,6 +40,10 @@ endif GDK_PIXBUF_DEPENDENCIES += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext libintl) host-pkg-config libglib2 libiconv +define GDK_PIXBUF_POST_INSTALL_TWEAKS + $(INSTALL) -m 755 package/gdk-pixbuf/S26gdk-pixbuf $(TARGET_DIR)/etc/init.d/ +endef +
Oh... come on!.. Don't break it the third time in these couple months :) You defined the hook - OK, but who will call it?
- Hide quoted text -
Quoted 3 lines
package/gdk-pixbuf/gdk-pixbuf.mk +0
-0$(eval $(call AUTOTARGETS,package,gdk-pixbuf)) HOST_GDK_PIXBUF_CONF_OPT = \
PATCH 6/12 gdk-pixbuf/libgtk2: move gdk-pixbuf loader cache setup script
Le jeudi 04 novembre 2010 ? 10:10 +0200, Paulius Zaleckas a ?crit :
Quoted 4 lines
Oh... come on!.. Don't break it the third time in these couple months :)
You defined the hook - OK, but who will call it?
Thanks, fixed on the repo.
Regards,
--
Lionel Landwerlin
PATCH 6/12 gdk-pixbuf/libgtk2: move gdk-pixbuf loader cache setup script
In reply to llandwerlin at gmail.comQuoted 3 lines · On Thu, 4 Nov 2010 03:50:25 +0100 llandwerlin at gmail.com wrote:
From: Lionel Landwerlin <[email protected]>
Signed-off-by Lionel Landwerlin <[email protected]>
Besides Paulius comment:
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 6/12 gdk-pixbuf/libgtk2: move gdk-pixbuf loader cache setup script
In reply to llandwerlin at gmail.comQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin <[email protected]> writes:
llandwerlin> From: Lionel Landwerlin <[email protected]> llandwerlin> Signed-off-by: Lionel Landwerlin <[email protected]>
Committed (fixed version), thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 7/12 automake: bump to 1.11.1
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/automake/automake.mk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
package/automake/automake.mk +1 -1
@@ -3,7 +3,7 @@ # automake # ############################################################# -AUTOMAKE_VERSION = 1.10 +AUTOMAKE_VERSION = 1.11.1 AUTOMAKE_SOURCE = automake-$(AUTOMAKE_VERSION).tar.bz2 AUTOMAKE_SITE = $(BR2_GNU_MIRROR)/automake
Signature · 1 line
1.7.2.3
PATCH 7/12 automake: bump to 1.11.1
Quoted 3 lines · On Thu, 4 Nov 2010 03:50:26 +0100 llandwerlin at gmail.com wrote:
From: Lionel Landwerlin <[email protected]>
Signed-off-by Lionel Landwerlin <[email protected]>
Not tested, but:
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 7/12 automake: bump to 1.11.1
In reply to llandwerlin at gmail.comQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin <[email protected]> writes:
llandwerlin> From: Lionel Landwerlin <[email protected]> llandwerlin> Signed-off-by: Lionel Landwerlin <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 8/12 sysstat: bump to 9.1.5
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/sysstat/sysstat.mk | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
package/sysstat/sysstat.mk +2 -4
@@ -4,7 +4,7 @@ # ############################################################# -SYSSTAT_VERSION = 9.0.5 +SYSSTAT_VERSION = 9.1.5 SYSSTAT_SOURCE = sysstat-$(SYSSTAT_VERSION).tar.bz2 SYSSTAT_SITE = http://pagesperso-orange.fr/sebastien.godard/ SYSSTAT_AUTORECONF = NO
@@ -12,9 +12,7 @@ SYSSTAT_LIBTOOL_PATCH = NO SYSSTAT_INSTALL_STAGING = NO SYSSTAT_INSTALL_TARGET = YES -# Should be --disable-man-group, it might be a little mistake in the -# configure.in script. -SYSSTAT_CONF_OPT = --enable-man-group +SYSSTAT_CONF_OPT = --disable-man-group ifneq ($(BR2_HAVE_DOCUMENTATION),y) SYSSTAT_CONF_OPT += --disable-documentation endif
Signature · 1 line
1.7.2.3
PATCH 8/12 sysstat: bump to 9.1.5
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin <[email protected]> writes:
llandwerlin> From: Lionel Landwerlin <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 9/12 libpcap: bump to 1.1.1
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
This new release avoids problems when running autoreconf.
--- package/libpcap/libpcap-1.0.0-wireless.patch | 26 -------------------------- package/libpcap/libpcap.mk | 2 +- 2 files changed, 1 insertions(+), 27 deletions(-) delete mode 100644 package/libpcap/libpcap-1.0.0-wireless.patch
package/libpcap/libpcap-1.0.0-wireless.patch deleted +0 -26
@@ -1,26 +0,0 @@ -[PATCH]: pcap-linux: fix build with wireless support - -Based on ba23aa7b upstream. - -linux/wireless.h includes linux/if.h, which conflicts with net/if.h as -they both define if* structures. Fix build by simply using linux/if.h -instead of net/if.h. - -Signed-off-by: Peter Korsgaard <[email protected]> ---- - pcap-linux.c | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -Index: libpcap-1.0.0/pcap-linux.c -=================================================================== ---- libpcap-1.0.0.orig/pcap-linux.c -+++ libpcap-1.0.0/pcap-linux.c -@@ -93,7 +93,7 @@ static const char rcsid[] _U_ = - #include <sys/ioctl.h> - #include <sys/utsname.h> - #include <sys/mman.h> --#include <net/if.h> -+#include <linux/if.h> - #include <netinet/in.h> - #include <linux/if_ether.h> - #include <net/if_arp.h>
package/libpcap/libpcap.mk +1 -1
@@ -4,7 +4,7 @@ # ############################################################# -LIBPCAP_VERSION:=1.0.0 +LIBPCAP_VERSION:=1.1.1 LIBPCAP_SITE:=http://www.tcpdump.org/release LIBPCAP_SOURCE:=libpcap-$(LIBPCAP_VERSION).tar.gz LIBPCAP_INSTALL_STAGING:=YES
Signature · 1 line
1.7.2.3
PATCH 9/12 libpcap: bump to 1.1.1
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin <[email protected]> writes:
llandwerlin> From: Lionel Landwerlin <[email protected]> llandwerlin> This new release avoids problems when running autoreconf.
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 10/12 linux-fusion: bump to 8.1.2
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- .../linux-fusion-8.1.1-missing-include.patch | 17 -------- ...ux-fusion-8.1.2-fix-warnings-at-link-time.patch | 40 ++++++++++++++++++++ package/linux-fusion/linux-fusion.mk | 7 ++- 3 files changed, 44 insertions(+), 20 deletions(-) delete mode 100644 package/linux-fusion/linux-fusion-8.1.1-missing-include.patch create mode 100644 package/linux-fusion/linux-fusion-8.1.2-fix-warnings-at-link-time.patch
package/linux-fusion/linux-fusion-8.1.1-missing-include.patch deleted +0 -17
@@ -1,17 +0,0 @@ -fusiondev.c does not compile due to TASK_INTERRUPTIBLE and other -related constants not being defined. - -Signed-off-by: Thomas Petazzoni <[email protected]> - -Index: linux-fusion-8.1.1/linux/drivers/char/fusion/fusiondev.c -=================================================================== ---- linux-fusion-8.1.1.orig/linux/drivers/char/fusion/fusiondev.c 2010-07-16 22:49:23.000000000 +0200 -+++ linux-fusion-8.1.1/linux/drivers/char/fusion/fusiondev.c 2010-07-16 22:49:39.000000000 +0200 -@@ -32,6 +32,7 @@ - #include <linux/proc_fs.h> - #include <linux/poll.h> - #include <linux/init.h> -+#include <linux/sched.h> - #include <asm/io.h> - #include <asm/uaccess.h> -
package/linux-fusion/linux-fusion-8.1.2-fix-warnings-at-link-time.patch new file +40 -0
@@ -0,0 +1,40 @@ +From 7884688ba7a2e4cb7772cbedb34245a7fc9bf9d9 Mon Sep 17 00:00:00 2001 +From: Lionel Landwerlin <[email protected]> +Date: Wed, 3 Nov 2010 10:25:17 +0100 +Subject: [PATCH] Fix warnings at link time + +Signed-off-by: Lionel Landwerlin <[email protected]> +--- + linux/drivers/char/fusion/entries.c | 2 +- + linux/drivers/char/fusion/fusiondev.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/linux/drivers/char/fusion/entries.c b/linux/drivers/char/fusion/entries.c +index 11edd43..8d102cf 100644 +--- a/linux/drivers/char/fusion/entries.c ++++ b/linux/drivers/char/fusion/entries.c +@@ -28,7 +28,7 @@ + #include "fusiondev.h" + #include "entries.h" + +-struct timeval now; ++static struct timeval now; + + void + fusion_entries_init(FusionEntries * entries, +diff --git a/linux/drivers/char/fusion/fusiondev.c b/linux/drivers/char/fusion/fusiondev.c +index 2457bc1..7c7680d 100644 +--- a/linux/drivers/char/fusion/fusiondev.c ++++ b/linux/drivers/char/fusion/fusiondev.c +@@ -64,7 +64,7 @@ + MODULE_LICENSE("GPL"); + MODULE_AUTHOR("Denis Oliver Kropp <[email protected]>"); + +-struct proc_dir_entry *proc_fusion_dir; ++static struct proc_dir_entry *proc_fusion_dir; + + static int fusion_major = FUSION_MAJOR; + +-- +1.6.0.6 +
package/linux-fusion/linux-fusion.mk +4 -3
@@ -3,7 +3,7 @@ # linux-fusion # ############################################################# -LINUX_FUSION_VERSION = 8.1.1 +LINUX_FUSION_VERSION = 8.1.2 LINUX_FUSION_SOURCE = linux-fusion-$(LINUX_FUSION_VERSION).tar.gz LINUX_FUSION_SITE = http://directfb.org/downloads/Core/linux-fusion LINUX_FUSION_INSTALL_STAGING = YES
@@ -22,17 +22,18 @@ LINUX_FUSION_MAKE_OPTS += CROSS_COMPILE=$(TARGET_CROSS) LINUX_FUSION_MAKE_OPTS += KERNEL_MODLIB=/lib/modules/$(LINUX_FOR_FUSION)/kernel define LINUX_FUSION_BUILD_CMDS - $(MAKE) $(TARGET_CONFIGURE_OPTS) $(LINUX_FUSION_MAKE_OPTS) -C $(@D) + $(MAKE) $(TARGET_CONFIGURE_OPTS) $(LINUX_FUSION_MAKE_OPTS) INSTALL_MOD_PATH=$(STAGING_DIR) -C $(@D) endef # Only the header file is needed in the staging directory define LINUX_FUSION_INSTALL_STAGING_CMDS - install -m 644 $(@D)/linux/include/linux/fusion.h $(STAGING_DIR)/usr/include/linux + $(MAKE) $(TARGET_CONFIGURE_OPTS) $(LINUX_FUSION_MAKE_OPTS) INSTALL_MOD_PATH=$(STAGING_DIR) -C $(@D) headers_install endef define LINUX_FUSION_INSTALL_TARGET_CMDS $(MAKE) $(TARGET_CONFIGURE_OPTS) \ $(LINUX_FUSION_MAKE_OPTS) \ + INSTALL_MOD_PATH=$(TARGET_DIR) \ -C $(@D) install mkdir -p $(LINUX_FUSION_ETC_DIR) cp -dpf package/linux-fusion/40-fusion.rules $(LINUX_FUSION_ETC_DIR)
Signature · 1 line
1.7.2.3
PATCH 10/12 linux-fusion: bump to 8.1.2
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin <[email protected]> writes:
llandwerlin> From: Lionel Landwerlin <[email protected]> llandwerlin> Signed-off-by: Lionel Landwerlin <[email protected]>
llandwerlin> +++ b/package/linux-fusion/linux-fusion.mk llandwerlin> @@ -3,7 +3,7 @@
llandwerlin> # linux-fusion llandwerlin> # llandwerlin> ############################################################# llandwerlin> -LINUX_FUSION_VERSION = 8.1.1 llandwerlin> +LINUX_FUSION_VERSION = 8.1.2 llandwerlin> LINUX_FUSION_SOURCE = linux-fusion-$(LINUX_FUSION_VERSION).tar.gz llandwerlin> LINUX_FUSION_SITE = http://directfb.org/downloads/Core/linux-fusion llandwerlin> LINUX_FUSION_INSTALL_STAGING = YES
llandwerlin> @@ -22,17 +22,18 @@ LINUX_FUSION_MAKE_OPTS += CROSS_COMPILE=$(TARGET_CROSS) llandwerlin> LINUX_FUSION_MAKE_OPTS += KERNEL_MODLIB=/lib/modules/$(LINUX_FOR_FUSION)/kernel
llandwerlin> define LINUX_FUSION_BUILD_CMDS
llandwerlin> - $(MAKE) $(TARGET_CONFIGURE_OPTS) $(LINUX_FUSION_MAKE_OPTS) -C $(@D)
llandwerlin> + $(MAKE) $(TARGET_CONFIGURE_OPTS) $(LINUX_FUSION_MAKE_OPTS) INSTALL_MOD_PATH=$(STAGING_DIR) -C $(@D)
Why is INSTALL_MOD_PATH needed at build time?
llandwerlin> endef
llandwerlin> # Only the header file is needed in the staging directory llandwerlin> define LINUX_FUSION_INSTALL_STAGING_CMDS
llandwerlin> - install -m 644 $(@D)/linux/include/linux/fusion.h $(STAGING_DIR)/usr/include/linux
That comment should presumably go now?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 11/12 directfb: bump to 1.4.10
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/directfb/directfb.mk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
package/directfb/directfb.mk +1 -1
@@ -4,7 +4,7 @@ # ############################################################# DIRECTFB_VERSION_MAJOR:=1.4 -DIRECTFB_VERSION:=1.4.5 +DIRECTFB_VERSION:=$(DIRECTFB_VERSION_MAJOR).10 DIRECTFB_SITE:=http://www.directfb.org/downloads/Core/DirectFB-$(DIRECTFB_VERSION_MAJOR) DIRECTFB_SOURCE:=DirectFB-$(DIRECTFB_VERSION).tar.gz DIRECTFB_AUTORECONF = NO
Signature · 1 line
1.7.2.3
PATCH 11/12 directfb: bump to 1.4.10
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin <[email protected]> writes:
llandwerlin> From: Lionel Landwerlin <[email protected]> llandwerlin> Signed-off-by: Lionel Landwerlin <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 11/12 directfb: bump to 1.4.10
In reply to llandwerlin at gmail.comQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin <[email protected]> writes:
llandwerlin> From: Lionel Landwerlin <[email protected]> llandwerlin> Signed-off-by: Lionel Landwerlin <[email protected]> llandwerlin> ---
llandwerlin> package/directfb/directfb.mk | 2 +-
llandwerlin> 1 files changed, 1 insertions(+), 1 deletions(-)
llandwerlin> diff --git a/package/directfb/directfb.mk b/package/directfb/directfb.mk llandwerlin> index e4b6d90..2703677 100644
llandwerlin> --- a/package/directfb/directfb.mk
llandwerlin> +++ b/package/directfb/directfb.mk
llandwerlin> @@ -4,7 +4,7 @@
llandwerlin> # llandwerlin> ############################################################# llandwerlin> DIRECTFB_VERSION_MAJOR:=1.4
llandwerlin> -DIRECTFB_VERSION:=1.4.5
llandwerlin> +DIRECTFB_VERSION:=$(DIRECTFB_VERSION_MAJOR).10
I'm getting build breakage with:
libtool: link: /scratch/peko/staging/usr/bin/arm-unknown-linux-uclibcgnueabi-gcc
--sysroot=/scratch/peko/staging -I/scratch/peko/staging/usr/include/freetype2 -
O3 -ffast-math -pipe -pipe -Os -mtune=arm926ej-s -march=armv5te -mabi=aapcs-linu x -msoft-float -I/scratch/peko/staging/usr/include -I/scratch/peko/staging/inclu de -D_GNU_SOURCE -finstrument-functions -std=gnu99 -Werror-implicit-function-dec laration -o .libs/dfbinspector dfbinspector.o -L/scratch/peko/staging/lib -L/sc ratch/peko/staging/usr/lib ../src/.libs/libdirectfb.so ../lib/fusion/.libs/libfu sion.so ../lib/direct/.libs/libdirect.so -ldl -lpthread -Wl,-rpath -Wl,/usr/lib ../src/.libs/libdirectfb.so: undefined reference to `sqrt'
collect2: ld returned 1 exit status
make[3]: *** [dfbg] Error 1
We seem to be dropping -lm.
Any idea why? If not, then I'll revert the patch as I would like to put out -rc1 this weekend.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 11/12 directfb: bump to 1.4.10
Quoted 33 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin ?<[email protected]> writes:
?llandwerlin> From: Lionel Landwerlin <[email protected]> ?llandwerlin> Signed-off-by: Lionel Landwerlin <[email protected]> ?llandwerlin> ---
?llandwerlin> ?package/directfb/directfb.mk | ? ?2 +- ?llandwerlin> ?1 files changed, 1 insertions(+), 1 deletions(-)?llandwerlin> diff --git
a/package/directfb/directfb.mkb/package/directfb/directfb.mk?llandwerlin> index e4b6d90..2703677 100644
?llandwerlin> ---a/package/directfb/directfb.mk
?llandwerlin> +++b/package/directfb/directfb.mk
?llandwerlin> @@ -4,7 +4,7 @@
?llandwerlin> ?#
?llandwerlin> ?############################################################# ?llandwerlin> ?DIRECTFB_VERSION_MAJOR:=1.4
?llandwerlin> -DIRECTFB_VERSION:=1.4.5
?llandwerlin> +DIRECTFB_VERSION:=$(DIRECTFB_VERSION_MAJOR).10I'm getting build breakage with:
libtool: link: /scratch/peko/staging/usr/bin/arm-unknown-linux-uclibcgnueabi-gcc ?--sysroot=/scratch/peko/staging -I/scratch/peko/staging/usr/include/freetype2 - O3 -ffast-math -pipe -pipe -Os -mtune=arm926ej-s -march=armv5te -mabi=aapcs-linu x -msoft-float -I/scratch/peko/staging/usr/include -I/scratch/peko/staging/inclu de -D_GNU_SOURCE -finstrument-functions -std=gnu99 -Werror-implicit-function-dec laration -o .libs/dfbinspector dfbinspector.o ?-L/scratch/peko/staging/lib -L/sc ratch/peko/staging/usr/lib ../src/.libs/libdirectfb.so ../lib/fusion/.libs/libfu sion.so ../lib/direct/.libs/libdirect.so -ldl -lpthread -Wl,-rpath -Wl,/usr/lib ../src/.libs/libdirectfb.so: undefined reference to `sqrt'
collect2: ld returned 1 exit status
make[3]: *** [dfbg] Error 1
Quoted 5 lines
We seem to be dropping -lm.
Any idea why? If not, then I'll revert the patch as I would like to put out -rc1 this weekend.
I issue has been discussed on the directfb mailing list indeed. I haven't seen it with glibc...
If you're about reverting it, you also have to revert the sawman bump. I think I can add a patch to force -lm for now, I will send this patch tonight. Can you wait for it ?
Regards,
--
Lionel Landwerlin
PATCH 11/12 directfb: bump to 1.4.10
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Lionel" == Lionel Landwerlin <[email protected]> writes:
Hi,
Quoted 5 lines
Quoted 5 lines
We seem to be dropping -lm.
Any idea why? If not, then I'll revert the patch as I would like to put out -rc1 this weekend.
Lionel> I issue has been discussed on the directfb mailing list indeed. Lionel> I haven't seen it with glibc...
Lionel> If you're about reverting it, you also have to revert the sawman bump. Lionel> I think I can add a patch to force -lm for now, I will send this patch Lionel> tonight. Can you wait for it ?
Sure, I'm planning on cutting -rc1 Sunday.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 12/12 sawman: bump to 1.4.10
In reply to llandwerlin at gmail.comFrom: Lionel Landwerlin <[email protected]>
--- package/sawman/sawman.mk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
package/sawman/sawman.mk +1 -1
@@ -3,7 +3,7 @@ # SAWMAN # ############################################################# -SAWMAN_VERSION:=1.4.3 +SAWMAN_VERSION:=1.4.10 SAWMAN_SOURCE:=SaWMan-$(SAWMAN_VERSION).tar.gz SAWMAN_SITE:=http://www.directfb.org/downloads/Extras SAWMAN_INSTALL_STAGING = YES
Signature · 1 line
1.7.2.3
PATCH 12/12 sawman: bump to 1.4.10
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"llandwerlin" == llandwerlin <[email protected]> writes:
llandwerlin> From: Lionel Landwerlin <[email protected]> llandwerlin> Signed-off-by: Lionel Landwerlin <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard