Skip to contentSkip to conversation

classifier: report statistics for basic classifier

PATCH Applied Stephen Hemminger 2 participants 2 messages Nov 4, 2010 – Nov 8, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 classifier: report statistics for basic classifier

The basic classifier keeps statistics but does not report it to user space. This showed up when using basic classifier (with police) as a default catch all on ingress; no statistics were reported.

---
I consider this a bug and should go into net-2.6 but not stable.

 net/sched/cls_basic.c |    4 ++++
 1 file changed, 4 insertions(+)
net/sched/cls_basic.c +4 -0
@@ -268,6 +268,10 @@ static int basic_dump(struct tcf_proto *
 		goto nla_put_failure;
 
 	nla_nest_end(skb, nest);
+
+	if (tcf_exts_dump_stats(skb, &f->exts, &basic_ext_map) < 0)
+		goto nla_put_failure;
+
 	return skb->len;
 
 nla_put_failure:
maintainer Applied
#1 lore raw

From: Stephen Hemminger <[email protected]>
Date: Thu, 4 Nov 2010 17:47:04 -0400

Quoted 5 lines

The basic classifier keeps statistics but does not report it to user space. This showed up when using basic classifier (with police) as a default catch all on ingress; no statistics were reported.

Applied.