Skip to contentSkip to conversation

Warnings from latest -git

DISCUSSION Chris Clayton 1 participant 1 message Nov 5, 2010 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Forwarding to linux-media, which I somehow removed from the list of recipients. Also removing indentation from part of my message. Don't know how that happened.

---------- Forwarded Message ----------

Subject: Re: Warnings from latest -git
Date: Friday 05 November 2010
From: Chris Clayton <[email protected]>
To: Mauro Carvalho Chehab <[email protected]>

Hi again,

Quoted 47 lines · Chris Clayton
Quoted 40 lines

Thanks for the reply, Mauro.

Quoted 36 lines · Mauro Carvalho Chehab

Em 30-10-2010 04:17, Chris Clayton escreveu:

Quoted 7 lines

Hi,

Please cc me on any reply as I'm not subscribed.

Building v2.6.36-9452-g2d10d87 pulled this morning, I get:

warning: (DVB_USB_DIB0700 && MEDIA_SUPPORT && DVB_CAPTURE_DRIVERS &&

DVB_CORE && DVB_USB && !DVB_FE_CUSTOMISE) selects DVB_DIB8000 which has

Quoted 2 lines

unmet direct dependencies (MEDIA_SUPPORT && DVB_CAPTURE_DRIVERS && DVB_FE_CUSTOMISE && DVB_CORE && I2C)

It certainly requires further investigation. From your config file, we have, for dib0700:

CONFIG_DVB_USB_DIB0700=m
CONFIG_MEDIA_SUPPORT=m
CONFIG_DVB_CAPTURE_DRIVERS=y
CONFIG_DVB_CORE=m
CONFIG_DVB_USB=m
# CONFIG_DVB_FE_CUSTOMISE is not set

And, for dib8000:

CONFIG_MEDIA_SUPPORT=m
CONFIG_DVB_CAPTURE_DRIVERS=y
# CONFIG_DVB_FE_CUSTOMISE is not set
CONFIG_DVB_CORE=m
CONFIG_I2C=y

Both dib0700 and dib8000 were marked as m:

CONFIG_DVB_DIB8000=m
CONFIG_DVB_USB_DIB0700=m

So, in this specific example, it actually worked, but we need to find a

fix

Quoted 4 lines
Quoted 1 line

for this bug.

I may be wrong, but I don't see why DVB_FE_CUSTOMISE is a dependency in

these

Quoted 10 lines
Quoted 1 line

two cases. When it is not set, all the FE drivers are built. When it is

set,

Quoted 1 line

the user selects, which drivers are to be built, but what I think the

select

Quoted 1 line

statements are doing is select drivers without which other selections the

user

Quoted 1 line

has made make little sense. If that's correct, the DVB_FE_CUSTOMISE can

simply

Quoted 1 line

be removed as dependencies.

I've looked at and played around with the related Kconfig files.. The "conflict" arises because when DVB_USB_DIB_0700 is selected, it triggers the selection of DVB_DIB8000 if !DVB_FE_CUSTOMISE. However, the menu that DVB_DIB8000 is contained in an "if DVB_FE_CUSTOMIZE" block and that seems to make DVB_FE_CUSTOMIZE a direct dependency for DVB_DIB8000. I guess the intention of the if block was to simply switch the display of the menu on or off.

There are identical truth conflicts involving DVB_TUNER_CUSTOMISE.

The only way I have been able to avoid the warnings is by removing the if blocks that guard the frontend customisation menu, but simply doing that makes the related question about customisation look silly.

I don't get this warning in 2.6.36, so I've checked recent changes to kconfig and 246cf9c26bf11f2bffbecea6e5bd222eee7b1df8 looks as if it will be the "culprit". It's not a regression, however. It's a deliberate change to report the type of conflict we have here. It looks like we need a different scheme for controlling the visibility of the customisation menu. I'll look at the kconfig docs and see if I can figure anything out.

Chris

Quoted 16 lines
Quoted 3 lines

Let me know if that makes sense and, if it does, I'll bake a patch.

I've now customised anyway, so teh warnings have gone away, but can soon

revert

Quoted 7 lines

that to test a fix.

Thanks
Chris

Quoted 2 lines

Cheers,
Mauro

--
The more I see, the more I know. The more I know, the less I understand. Changing Man - Paul Weller

Signature · 8 lines
The more I see, the more I know. The more I know, the less I understand.
Changing Man - Paul Weller

-------------------------------------------------------

-- 
The more I see, the more I know. The more I know, the less I understand. 
Changing Man - Paul Weller