Skip to contentSkip to conversation

Drivers: hid: Makefile: Cleaned up Makefile

PATCH In review Tracey Dent 2 participants 5 messages Nov 6, 2010 – Nov 7, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 Drivers: hid: Makefile: Cleaned up Makefile

Changed Makefile to use <modules>-y instead of <modules>-objs.

---
 drivers/hid/Makefile |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
drivers/hid/Makefile +6 -6
index c335605..dad858b 100644
@@ -1,7 +1,7 @@
 #
 # Makefile for the HID driver
 #
-hid-objs			:= hid-core.o hid-input.o
+hid-y			:= hid-core.o hid-input.o
 
 ifdef CONFIG_DEBUG_FS
 	hid-objs		+= hid-debug.o
@@ -11,18 +11,18 @@ obj-$(CONFIG_HID)		+= hid.o
 
 hid-$(CONFIG_HIDRAW)		+= hidraw.o
 
-hid-logitech-objs		:= hid-lg.o
+hid-logitech-y		:= hid-lg.o
 ifdef CONFIG_LOGITECH_FF
-	hid-logitech-objs	+= hid-lgff.o
+	hid-logitech-y	+= hid-lgff.o
 endif
 ifdef CONFIG_LOGIRUMBLEPAD2_FF
-	hid-logitech-objs	+= hid-lg2ff.o
+	hid-logitech-y	+= hid-lg2ff.o
 endif
 ifdef CONFIG_LOGIG940_FF
-	hid-logitech-objs	+= hid-lg3ff.o
+	hid-logitech-y	+= hid-lg3ff.o
 endif
 ifdef CONFIG_LOGIWII_FF
-	hid-logitech-objs	+= hid-lg4ff.o
+	hid-logitech-y	+= hid-lg4ff.o
 endif
 
 obj-$(CONFIG_HID_3M_PCT)	+= hid-3m-pct.o
Signature · 1 line
1.7.3.1.104.gc752e
#1 lore raw

PATCH 2/2 Drivers: hid: usbhid: Makefile: Cleaned up Makefile

Changed Makefile to use <modules>-y instead of <modules>-objs.

---
 drivers/hid/usbhid/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/hid/usbhid/Makefile +3 -3
index 1329ecb..db3cf31 100644
@@ -3,15 +3,15 @@
 #
 
 # Multipart objects.
-usbhid-objs	:= hid-core.o hid-quirks.o
+usbhid-y	:= hid-core.o hid-quirks.o
 
 # Optional parts of multipart objects.
 
 ifeq ($(CONFIG_USB_HIDDEV),y)
-	usbhid-objs	+= hiddev.o
+	usbhid-y	+= hiddev.o
 endif
 ifeq ($(CONFIG_HID_PID),y)
-	usbhid-objs	+= hid-pidff.o
+	usbhid-y	+= hid-pidff.o
 endif
 
 obj-$(CONFIG_USB_HID)		+= usbhid.o
Signature · 1 line
1.7.3.1.104.gc752e
#2 lore raw
In reply to Tracey Dent

Hi Tracey,

Quoted 2 lines · Tracey Dent

Changed Makefile to use <modules>-y instead of <modules>-objs.

Changelog normally should say why something has been done as what has been done is pretty clear from the patch itself.

Thanks.

Signature · 1 line
Dmitry
#3 lore raw
Quoted 9 lines · Dmitry Torokhov

Hi Tracey,

Quoted 2 lines · Tracey Dent

Changed Makefile to use <modules>-y instead of <modules>-objs.

Changelog normally should say why something has been done as what has been done is pretty clear from the patch itself.

Do you want me to resend patch with more descriptive changelog?

Quoted 5 lines

Thanks.

--
Dmitry

regards

td

#4 lore raw
Quoted 4 lines · Tracey Dent
Quoted 3 lines · Dmitry Torokhov

Hi Tracey,

On Sat, Nov 06, 2010 at 03:07:43PM -0400, Tracey Dent wrote:

Quoted 9 lines
Quoted 6 lines
Quoted 2 lines

Changed Makefile to use <modules>-y instead of <modules>-objs.

Changelog normally should say why something has been done as what has been done is pretty clear from the patch itself.

Do you want me to resend patch with more descriptive changelog?

Yes please.

Signature · 1 line
Dmitry