Skip to contentSkip to conversation

docs: Add neigh/gc_thresh3 and route/max_size documentation.

PATCH Applied Ben Greear 2 participants 5 messages Nov 8, 2010 – Nov 12, 2010

Subsystems (4)
lore
Share & tools
lore

Ben Greear

author
#0 lore raw

PATCH 1/2 docs: Add neigh/gc_thresh3 and route/max_size documentation.

---
:100644 100644 f350c69... 7c5cca2... M Documentation/networking/ip-sysctl.txt

 Documentation/networking/ip-sysctl.txt |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)
Documentation/networking/ip-sysctl.txt +9 -0
index f350c69..7c5cca2 100644
@@ -20,6 +20,15 @@ ip_no_pmtu_disc - BOOLEAN
 min_pmtu - INTEGER
 	default 562 - minimum discovered Path MTU
 
+route/max_size - INTEGER
+	Maximum number of routes allowed in the kernel.  Increase
+	this when using large numbers of interfaces and/or routes.
+
+neigh/default/gc_thresh3 - INTEGER
+	Maximum number of neighbor entries allowed.  Increase this
+	when using large numbers of interfaces and when communicating
+	with large numbers of directly-connected peers. 
+
 mtu_expires - INTEGER
 	Time, in seconds, that cached PMTU information is kept.
 
Signature · 1 line
1.6.2.5
author
#1 lore raw

PATCH 2/2 IPv6: Warn users when route/max_entries is reached.

---
:100644 100644 a275c6e... 348b34c... M net/ipv6/route.c

 net/ipv6/route.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
net/ipv6/route.c +5 -1
index a275c6e..348b34c 100644
@@ -1060,8 +1060,12 @@ static int ip6_dst_gc(struct dst_ops *ops)
 	unsigned long rt_last_gc = net->ipv6.ip6_rt_last_gc;
 
 	if (time_after(rt_last_gc + rt_min_interval, now) &&
-	    atomic_read(&ops->entries) <= rt_max_size)
+	    atomic_read(&ops->entries) <= rt_max_size) {
+		if (net_ratelimit())
+			pr_warning("IPv6:  Maximum number of routes reached,"
+				   " consider increasing route/max_size.\n");
 		goto out;
+	}
 
 	net->ipv6.ip6_rt_gc_expire++;
 	fib6_run_gc(net->ipv6.ip6_rt_gc_expire, net);
Signature · 1 line
1.6.2.5
author
#2 lore raw

Re: [PATCH 2/2] IPv6: Warn users when route/max_entries is reached.

Quoted 14 lines · Ben Greear

---
:100644 100644 a275c6e... 348b34c... M net/ipv6/route.c

  net/ipv6/route.c |    6 +++++-
  1 files changed, 5 insertions(+), 1 deletions(-)
net/ipv6/route.c +0 -0
index a275c6e..348b34c 100644
@@ -1060,8 +1060,12 @@ static int ip6_dst_gc(struct dst_ops *ops)
  	unsigned long rt_last_gc = net->ipv6.ip6_rt_last_gc;
 
  	if (time_after(rt_last_gc + rt_min_interval, now)&&

net/ipv6/route.c static int ip6_dst_gc(struct dst_ops *ops) · line 1071

Quoted 10 lines
net/ipv6/route.c +5 -1
-	    atomic_read(&ops->entries)<= rt_max_size)
+	    atomic_read(&ops->entries)<= rt_max_size) {
+		if (net_ratelimit())
+			pr_warning("IPv6:  Maximum number of routes reached,"
+				   " consider increasing route/max_size.\n");
  		goto out;
+	}
 
  	net->ipv6.ip6_rt_gc_expire++;
  	fib6_run_gc(net->ipv6.ip6_rt_gc_expire, net);

Please don't apply this. I mis-read this code and that warning is useless at best in this place.

Thanks,
Ben

Signature · 2 lines
Ben Greear <[email protected]>
Candela Technologies Inc  http://www.candelatech.com
maintainer
#3 lore raw

Re: [PATCH 2/2] IPv6: Warn users when route/max_entries is reached.

From: Ben Greear <[email protected]>
Date: Mon, 08 Nov 2010 13:09:29 -0800

Quoted 2 lines · Ben Greear
Quoted 1 line

...

Quoted 2 lines

Please don't apply this. I mis-read this code and that warning is useless at best in this place.

Ok.

maintainer Applied
#4 lore raw
In reply to Ben Greear

From: Ben Greear <[email protected]>
Date: Mon, 8 Nov 2010 11:13:48 -0800

Quoted 1 line

Applied.

Documentation/networking/ip-sysctl.txt ip_no_pmtu_disc - BOOLEAN · line 30

Quoted 1 line
Documentation/networking/ip-sysctl.txt +1 -0
+	with large numbers of directly-connected peers. 

This line has trailing whitespace, please avoid that in the future so I don't have to correct your patches by hand.

Thanks.