Skip to contentSkip to conversation

Drivers: block: Makefile: replace the use of <module>-objs with <module>-y

PATCH RESEND Applied Tracey Dent 4 participants 8 messages Nov 6, 2010 – Nov 9, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/2 Drivers: block: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

---
 drivers/block/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/block/Makefile +1 -1
index d7f463d..40528ba 100644
@@ -39,4 +39,4 @@ obj-$(CONFIG_XEN_BLKDEV_FRONTEND)	+= xen-blkfront.o
 obj-$(CONFIG_BLK_DEV_DRBD)     += drbd/
 obj-$(CONFIG_BLK_DEV_RBD)     += rbd.o
 
-swim_mod-objs	:= swim.o swim_asm.o
+swim_mod-y	:= swim.o swim_asm.o
Signature · 1 line
1.7.3.2.146.gca209
#1 lore raw

PATCH RESEND 2/2 Drivers: block: aoe: Makefile: replace the use of <module>-objs with <module>-y

Changed <module>-objs to <module>-y in Makefile.

---
 drivers/block/aoe/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/block/aoe/Makefile +1 -1
index e76d997..06ea82c 100644
@@ -3,4 +3,4 @@
 #
 
 obj-$(CONFIG_ATA_OVER_ETH)	+= aoe.o
-aoe-objs := aoeblk.o aoechr.o aoecmd.o aoedev.o aoemain.o aoenet.o
+aoe-y := aoeblk.o aoechr.o aoecmd.o aoedev.o aoemain.o aoenet.o
Signature · 1 line
1.7.3.2.146.gca209
#2 lore raw

Re: [Resend][PATCH 2/2] Drivers: block: aoe: Makefile: replace the use of <module>-objs with <module>-y

Quoted 1 line · Tracey Dent

Changed <module>-objs to <module>-y in Makefile.

Andrew Morton, hi. I don't know whether Tracey Dent is expecting me to push this change to Linus, but lately you've been pushing the aoe changes. I see similar changes in other
drivers on the LKML, so if it looks good to you, would you mind please picking up this patch?

Quoted 18 lines

---
drivers/block/aoe/Makefile | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
drivers/block/aoe/Makefile +0 -0
index e76d997..06ea82c 100644
@@ -3,4 +3,4 @@
 #
 

obj-$(CONFIG_ATA_OVER_ETH) += aoe.o

drivers/block/aoe/Makefile +1 -1
-aoe-objs := aoeblk.o aoechr.o aoecmd.o aoedev.o aoemain.o aoenet.o
+aoe-y := aoeblk.o aoechr.o aoecmd.o aoedev.o aoemain.o aoenet.o
Signature · 1 line
1.7.3.2.146.gca209
Signature · 2 lines
  Ed Cashin
  [email protected]
#3 lore raw

Re: [Resend][PATCH 2/2] Drivers: block: aoe: Makefile: replace the use of <module>-objs with <module>-y

Quoted 9 lines · On Mon, 8 Nov 2010 10:03:24 -0500 Ed Cashin <[email protected]> wrote:
Quoted 1 line · Tracey Dent

Changed <module>-objs to <module>-y in Makefile.

Andrew Morton, hi. I don't know whether Tracey Dent is expecting me to push this change to Linus, but lately you've been pushing the aoe changes. I see similar changes in other
drivers on the LKML, so if it looks good to you, would you mind please picking up this patch?

I queued both patches - I guess I'll send them to Jens.

I queued them as "unchangelogged patches". Because what the changelogs told us was utterly obvious from reading the patch.

What the changelogs didn't tell us was _why_ the change was made. And guess what? I don't have a clue! I just haven't been following these kbuild minutea.

Tracey, please send a description of *why* this change is being made and I'll add it to the changelogs. Please include that explanation in all such patches.

#4 lore raw

Re: [Resend][PATCH 2/2] Drivers: block: aoe: Makefile: replace the use of <module>-objs with <module>-y

Hi Ed,

Quoted 8 lines · On Mon, 8 Nov 2010 13:05:43 -0800 Andrew Morton <[email protected]>…
Quoted 4 lines · On Mon, 8 Nov 2010 10:03:24 -0500 Ed Cashin <[email protected]> wrote:
Quoted 1 line · Tracey Dent

Changed <module>-objs to <module>-y in Makefile.

Quoted 7 lines
Quoted 5 lines

Andrew Morton, hi. I don't know whether Tracey Dent is expecting me to push this change to Linus, but lately you've been pushing the aoe changes. I see similar changes in other
drivers on the LKML, so if it looks good to you, would you mind please picking up this patch?

I queued both patches - I guess I'll send them to Jens.

I have a quilt series in linux-next called aoe that has not been updated since Nov, 2009. Can I assume that it is defunct and remove it? Or will you be using it again?

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#5 lore raw

Re: [Resend][PATCH 2/2] Drivers: block: aoe: Makefile: replace the use of <module>-objs with <module>-y

On Nov 8, 2010, at 8:11 PM, Stephen Rothwell wrote:
...

Quoted 3 lines

I have a quilt series in linux-next called aoe that has not been updated since Nov, 2009. Can I assume that it is defunct and remove it? Or will you be using it again?

You can remove it, thanks. When I created it, I had the misunderstanding that I was supposed to push through linux-next into Linus's tree. But patches still just go through Andrew or Jens.

The aoe changes usually aren't invasive enough to benefit from being available in linux-next, I think.

Signature · 2 lines
  Ed Cashin
  [email protected]
#6 lore raw

Re: [Resend][PATCH 2/2] Drivers: block: aoe: Makefile: replace the use of <module>-objs with <module>-y

Hi Ed,

Quoted 7 lines · On Tue, 9 Nov 2010 08:54:55 -0500 Ed Cashin <[email protected]> wrote:

On Nov 8, 2010, at 8:11 PM, Stephen Rothwell wrote:
...

Quoted 3 lines

I have a quilt series in linux-next called aoe that has not been updated since Nov, 2009. Can I assume that it is defunct and remove it? Or will you be using it again?

Quoted 7 lines

You can remove it, thanks. When I created it, I had the misunderstanding that I was supposed to push through linux-next into Linus's tree. But patches still just go through Andrew or Jens.

The aoe changes usually aren't invasive enough to benefit from being available in linux-next, I think.

OK, thanks, will do.

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#7 lore raw

Re: [Resend][PATCH 2/2] Drivers: block: aoe: Makefile: replace the use of <module>-objs with <module>-y

In reply to Andrew Morton
Quoted 18 lines · Andrew Morton
Quoted 9 lines · On Mon, 8 Nov 2010 10:03:24 -0500 Ed Cashin <[email protected]> wrote:
Quoted 1 line · Tracey Dent

Changed <module>-objs to <module>-y in Makefile.

Andrew Morton, hi. I don't know whether Tracey Dent is expecting me to push this change to Linus, but lately you've been pushing the aoe changes. I see similar changes in other
drivers on the LKML, so if it looks good to you, would you mind please picking up this patch?

I queued both patches - I guess I'll send them to Jens.

I queued them as "unchangelogged patches". Because what the changelogs told us was utterly obvious from reading the patch.

Quoted 8 lines

What the changelogs didn't tell us was _why_ the change was made. And guess what? I don't have a clue! I just haven't been following these kbuild minutea.

Tracey, please send a description of *why* this change is being made and I'll add it to the changelogs. Please include that explanation in all such patches.

Is this good?

Changed Makefile to use <modules>-y instead of <modules>-objs because -objs is deprecated and should now be switched. According to (documentation/kbuild/makefiles.txt).

regards

td