Skip to contentSkip to conversation

env_mmc: fix compile warning

PATCH New Mike Frysinger 3 participants 4 messages Nov 9, 2010 – Nov 14, 2010 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 env_mmc: fix compile warning

Quoted 1 line · On Tuesday, November 09, 2010 10:18:42 Lei Wen wrote:

Hi Mike,

please dont top post

Quoted 4 lines

I am sorry for that...
Here is the warning:
env_mmc.c: In function 'saveenv':
env_mmc.c:109: warning: implicit declaration of function 'hexport'

please resend your patch with an updated changelog
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101109/c673cc60/attachment.pgp

#2 lore raw

PATCH 1/1 env_mmc: fix compile warning

Hi Mike,

Please review this refined patch.

#3 lore raw

PATCH 1/1 env_mmc: fix compile warning

Quoted 3 lines · On Tuesday, November 09, 2010 18:39:23 Lei Wen wrote:

Hi Mike,

Please review this refined patch.

thanks, this looks much better

not that ive ever used env_mmc, so i cant comment on correctness of it -mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20101109/a2a78222/attachment.pgp

#4 lore raw

PATCH 1/1 env_mmc: fix compile warning

In reply to Lei Wen

Dear Lei Wen,

Quoted 15 lines · In message <[email protected]> you…

--00248c0d766c2c192a0494a740ed
Content-Type: text/plain; charset=UTF-8

Hi Mike,

Please review this refined patch.

Quoted 1 line

From a7c694f84bec6b0db26ece4c77d06585be5a6755 Mon Sep 17 00:00:00 2001

From: Lei Wen <[email protected]>
Date: Wed, 10 Nov 2010 07:44:03 +0800
Subject: [PATCH] env_mmc: fix compile warning

hexport would complain implicit declaration, if we don't add the include file.

Quoted 7 lines

env_mmc.c: In function 'saveenv':
env_mmc.c:109: warning: implicit declaration of function 'hexport'

---
 common/env_mmc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Applies, thanks.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Is not that the nature of men and women -- that the  pleasure  is  in
the learning of each other?
	-- Natira, the High Priestess of Yonada, "For the World is
	   Hollow and I Have Touched the Sky", stardate 5476.3.