Skip to contentSkip to conversation

mv78xx: wrong cpu1 window base register address

PATCH New Evgeniy Dushistov 2 participants 2 messages Nov 9, 2010 – Nov 22, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mv78xx: wrong cpu1 window base register address

The constant DDR_WINDOW_CPU1_BASE has wrong value. Because of that mv78xx0_mbus_dram_info is not filled properly on start, and in its turn drivers, that used mv78xx0_mbus_dram_info, in my case mv643xx_eth.c, not work on second core. According to

MV76100, MV78100, and MV78200 DiscoveryTM Innovation Series CPU Family
Functional Specifications

address should be 0x1570.

---
 arch/arm/mach-mv78xx0/include/mach/mv78xx0.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-mv78xx0/include/mach/mv78xx0.h +1 -1
index 788bdac..3eff399 100644
@@ -65,7 +65,7 @@
  */
 #define DDR_VIRT_BASE		(MV78XX0_REGS_VIRT_BASE | 0x00000)
 #define  DDR_WINDOW_CPU0_BASE	(DDR_VIRT_BASE | 0x1500)
-#define  DDR_WINDOW_CPU1_BASE	(DDR_VIRT_BASE | 0x1700)
+#define  DDR_WINDOW_CPU1_BASE	(DDR_VIRT_BASE | 0x1570)
 
 #define DEV_BUS_PHYS_BASE	(MV78XX0_REGS_PHYS_BASE | 0x10000)
 #define DEV_BUS_VIRT_BASE	(MV78XX0_REGS_VIRT_BASE | 0x10000)
Signature · 4 lines
1.7.2.2

-- 
/Evgeniy
#1 lore raw

PATCH 1/1 mv78xx: wrong cpu1 window base register address

Quoted 6 lines · Evgeniy Dushistov

The constant DDR_WINDOW_CPU1_BASE has wrong value. Because of that mv78xx0_mbus_dram_info is not filled properly on start, and in its turn drivers, that used mv78xx0_mbus_dram_info, in my case mv643xx_eth.c, not work on second core. According to

Quoted 7 lines

MV76100, MV78100, and MV78200 DiscoveryTM Innovation Series CPU Family
Functional Specifications

address should be 0x1570.