virtio: fix format of sysfs driver/vendor files
PATCH 1/1 virtio: fix format of sysfs driver/vendor files
The sysfs files for virtio produce the wrong format and are missing the required newline. The output for virtio bus vendor/device should have the same format as the corresponding entries for PCI devices.
Although this technically changes the ABI for sysfs, these files were broken to start with!
Signed-off-by Stephen Hemminger <[email protected]>
drivers/virtio/virtio.c +3 -3
@@ -9,19 +9,19 @@ static ssize_t device_show(struct device struct device_attribute *attr, char *buf) { struct virtio_device *dev = container_of(_d,struct virtio_device,dev); -return sprintf (buf,"%hu" , dev->id.device); +return sprintf (buf,"0x%04x\n" , dev->id.device); }static ssize_t vendor_show (struct device *_d,struct device_attribute *attr,char *buf) { struct virtio_device *dev = container_of(_d,struct virtio_device,dev); -return sprintf (buf,"%hu" , dev->id.vendor); +return sprintf (buf,"0x%04x\n" , dev->id.vendor); }static ssize_t status_show (struct device *_d,struct device_attribute *attr,char *buf) { struct virtio_device *dev = container_of(_d,struct virtio_device,dev); -return sprintf (buf,"0x%08x" , dev->config->get_status (dev)); +return sprintf (buf,"0x%08x\n" , dev->config->get_status (dev)); }static ssize_t modalias_show (struct device *_d,struct device_attribute *attr,char *buf)
Rusty Russell
AppliedQuoted 6 lines · Stephen Hemminger
The sysfs files for virtio produce the wrong format and are missing the required newline. The output for virtio bus vendor/device should have the same format as the corresponding entries for PCI devices.
Although this technically changes the ABI for sysfs, these files were broken to start with!
Agreed, and I don't think anyone currently uses them.
Applied,
Rusty.