Make swap accounting default behavior configurable
Subsystems (3)
RFC PATCH 1/1 Make swap accounting default behavior configurable
Hi,
could you consider the patch bellow? It basically changes the default swap accounting behavior (when it is turned on in configuration) to be configurable as well.
The rationale is described in the patch but in short it makes it much more easier to enable this feature in distribution kernels as the functionality can be provided in the general purpose kernel (with the option disabled) without any drawbacks and interested users can enable it. This is not possible currently.
I am aware that boot command line parameter name change is not ideal but the original semantic wasn't good enough and I don't like noswapaccount=yes|no very much.
If we really have to stick to it I can rework the patch to keep the name and just add the yes|no logic, though. Or we can keep the original one and add swapaccount paramete which would mean the oposite as the other one.
The patch is based on the current Linus tree.
Any thoughts?
---
Quoted 1 line
From
c874f2c1ff1493e49611f19308434e564c2d37c6Mon Sep 17 00:00:00 2001
From: Michal Hocko <[email protected]>
Date: Wed, 10 Nov 2010 13:30:04 +0100
Subject: [PATCH] Make swap accounting default behavior configurable
Swap accounting can be configured by CONFIG_CGROUP_MEM_RES_CTLR_SWAP configuration option and then it is turned on by default. There is a boot option (noswapaccount) which can disable this feature.
This makes it hard for distributors to enable the configuration option as this feature leads to a bigger memory consumption and this is a no-go for general purpose distribution kernel. On the other hand swap accounting may be very usuful for some workloads.
This patch adds a new configuration option which controls the default behavior (CGROUP_MEM_RES_CTLR_SWAP_ENABLED) and changes the original noswapaccount parameter to swapaccount=true|false which provides a more fine grained way to control this feature.
The default behavior is unchanged (if CONFIG_CGROUP_MEM_RES_CTLR_SWAP is enabled then CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED is enabled as well)
--- init/Kconfig | 13 +++++++++++++ mm/memcontrol.c | 19 ++++++++++++++----- 2 files changed, 27 insertions(+), 5 deletions(-)
init/Kconfig +13 -0
@@ -613,6 +613,19 @@ config CGROUP_MEM_RES_CTLR_SWAP if boot option "noswapaccount" is set, swap will not be accounted. Now, memory usage of swap_cgroup is 2 bytes per entry. If swap page size is 4096bytes, 512k per 1Gbytes of swap. +config CGROUP_MEM_RES_CTLR_SWAP_ENABLED + bool "Memory Resource Controller Swap Extension enabled by default" + depends on CGROUP_MEM_RES_CTLR_SWAP + default y + help + Memory Resource Controller Swap Extension comes with its price in + a bigger memory consumption. General purpose distribution kernels + which want to enable the feautre but keep it disabled by default + and let the user enable it by swapaccount=true boot command line + parameter should have this option unselected. + For those who want to have the feature enabled by default should + select this option (if, for some reason, they need to disable it + then swapaccount=false does the trick). menuconfig CGROUP_SCHED bool "Group CPU scheduler"
mm/memcontrol.c +14 -5
@@ -61,7 +61,14 @@ struct mem_cgroup *root_mem_cgroup __read_mostly;#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */ int do_swap_account__read_mostly ; -static int really_do_swap_account__initdata =1 ;/* for remember boot option*/ + +/* for remember boot option*/ +#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED +static int really_do_swap_account__initdata =1 ; +#else +static int really_do_swap_account__initdata =0 ; +#endif +#else #define do_swap_account (0)#endif
@@ -4909,11 +4916,13 @@ struct cgroup_subsys mem_cgroup_subsys = { };#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP - -static int __init disable_swap_account (char *s) +static int __init enable_swap_account (char *s) { - really_do_swap_account =0 ; +if (!s || !strcmp (s,"true" )) + really_do_swap_account =1 ; +else if (!strcmp (s,"false" )) + really_do_swap_account =0 ;return 1 ; } -__setup ("noswapaccount" , disable_swap_account); +__setup ("swapaccount" , enable_swap_account);#endif
Signature · 10 lines
1.7.2.3 -- Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
Quoted 11 lines · On Wed, 10 Nov 2010 13:51:54 +0100 Michal Hocko <[email protected]> wrote:
Hi,
could you consider the patch bellow? It basically changes the default swap accounting behavior (when it is turned on in configuration) to be configurable as well.The rationale is described in the patch but in short it makes it much more easier to enable this feature in distribution kernels as the functionality can be provided in the general purpose kernel (with the option disabled) without any drawbacks and interested users can enable it. This is not possible currently.
Quoted 9 lines
I am aware that boot command line parameter name change is not ideal but the original semantic wasn't good enough and I don't like noswapaccount=yes|no very much.
If we really have to stick to it I can rework the patch to keep the name and just add the yes|no logic, though. Or we can keep the original one and add swapaccount paramete which would mean the oposite as the other one.
hmm, I agree that current parameter name(noswapaccount) is not desirable for yes|no, but IMHO changing the user interface(iow, making what worked before unusable) is worse.
Although I'm not sure how many people are using this parameter, I vote for using "noswapaccount[=(yes|no)]".
And you should update Documentation/kernel-parameters.txt too.
Thanks,
Daisuke Nishimura.
Quoted 113 lines
The patch is based on the current Linus tree.
Any thoughts?
---From
c874f2c1ff1493e49611f19308434e564c2d37c6Mon Sep 17 00:00:00 2001
From: Michal Hocko <[email protected]>
Date: Wed, 10 Nov 2010 13:30:04 +0100
Subject: [PATCH] Make swap accounting default behavior configurableSwap accounting can be configured by
CONFIG_CGROUP_MEM_RES_CTLR_SWAPconfiguration option and then it is turned on by default. There is a boot option (noswapaccount) which can disable this feature.This makes it hard for distributors to enable the configuration option as this feature leads to a bigger memory consumption and this is a no-go for general purpose distribution kernel. On the other hand swap accounting may be very usuful for some workloads.
This patch adds a new configuration option which controls the default behavior (
CGROUP_MEM_RES_CTLR_SWAP_ENABLED) and changes the original noswapaccount parameter to swapaccount=true|false which provides a more fine grained way to control this feature.The default behavior is unchanged (if
CONFIG_CGROUP_MEM_RES_CTLR_SWAPis enabled thenCONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLEDis enabled as well)Signed-off-by Michal Hocko <[email protected]>--- init/Kconfig | 13 +++++++++++++ mm/memcontrol.c | 19 ++++++++++++++----- 2 files changed, 27 insertions(+), 5 deletions(-)init/Kconfig +13
-0@@ -613,6 +613,19 @@ config CGROUP_MEM_RES_CTLR_SWAP if boot option "noswapaccount" is set, swap will not be accounted. Now, memory usage of swap_cgroup is 2 bytes per entry. If swap page size is 4096bytes, 512k per 1Gbytes of swap. +config CGROUP_MEM_RES_CTLR_SWAP_ENABLED + bool "Memory Resource Controller Swap Extension enabled by default" + depends on CGROUP_MEM_RES_CTLR_SWAP + default y + help + Memory Resource Controller Swap Extension comes with its price in + a bigger memory consumption. General purpose distribution kernels + which want to enable the feautre but keep it disabled by default + and let the user enable it by swapaccount=true boot command line + parameter should have this option unselected. + For those who want to have the feature enabled by default should + select this option (if, for some reason, they need to disable it + then swapaccount=false does the trick). menuconfig CGROUP_SCHED bool "Group CPU scheduler"mm/memcontrol.c +14
-5@@ -61,7 +61,14 @@ struct mem_cgroup *root_mem_cgroup __read_mostly;#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */ int do_swap_account__read_mostly ; -static int really_do_swap_account__initdata =1 ;/* for remember boot option*/ + +/* for remember boot option*/ +#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED +static int really_do_swap_account__initdata =1 ; +#else +static int really_do_swap_account__initdata =0 ; +#endif +#else #define do_swap_account (0)#endif @@ -4909,11 +4916,13 @@ struct cgroup_subsys mem_cgroup_subsys = { };#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP - -static int __init disable_swap_account (char *s) +static int __init enable_swap_account (char *s) { - really_do_swap_account =0 ; +if (!s || !strcmp (s,"true" )) + really_do_swap_account =1 ; +else if (!strcmp (s,"false" )) + really_do_swap_account =0 ;return 1 ; } -__setup ("noswapaccount" , disable_swap_account); +__setup ("swapaccount" , enable_swap_account);#endif Signature · 17 lines
1.7.2.3 -- Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 23 lines · Daisuke Nishimura
Quoted 11 lines · On Wed, 10 Nov 2010 13:51:54 +0100 Michal Hocko <[email protected]> wrote:
Hi,
could you consider the patch bellow? It basically changes the default swap accounting behavior (when it is turned on in configuration) to be configurable as well.The rationale is described in the patch but in short it makes it much more easier to enable this feature in distribution kernels as the functionality can be provided in the general purpose kernel (with the option disabled) without any drawbacks and interested users can enable it. This is not possible currently.
Quoted 9 lines
I am aware that boot command line parameter name change is not ideal but the original semantic wasn't good enough and I don't like noswapaccount=yes|no very much.
If we really have to stick to it I can rework the patch to keep the name and just add the yes|no logic, though. Or we can keep the original one and add swapaccount paramete which would mean the oposite as the other one.
Quoted 6 lines
hmm, I agree that current parameter name(noswapaccount) is not desirable for yes|no, but IMHO changing the user
interface(iow, making what worked before unusable)is worse.Although I'm not sure how many people are using this parameter, I vote for using "noswapaccount[=(yes|no)]".
Isn't a new swapaccount parameter better than that? I know we don't want to have too many parameters but having a something with a clear meaning is better IMO (noswapaccount=no doesn't sound very intuitive to me).
Quoted 1 line
And you should update
Documentation/kernel-parameters.txttoo.
Yes, I am aware of that and will do that once there is an agreement on the patch itself. At this stage, I just wanted to have a feadback about the change.
Quoted 124 lines
Thanks,
Daisuke Nishimura.Quoted 113 lines
The patch is based on the current Linus tree.
Any thoughts?
---From
c874f2c1ff1493e49611f19308434e564c2d37c6Mon Sep 17 00:00:00 2001
From: Michal Hocko <[email protected]>
Date: Wed, 10 Nov 2010 13:30:04 +0100
Subject: [PATCH] Make swap accounting default behavior configurableSwap accounting can be configured by
CONFIG_CGROUP_MEM_RES_CTLR_SWAPconfiguration option and then it is turned on by default. There is a boot option (noswapaccount) which can disable this feature.This makes it hard for distributors to enable the configuration option as this feature leads to a bigger memory consumption and this is a no-go for general purpose distribution kernel. On the other hand swap accounting may be very usuful for some workloads.
This patch adds a new configuration option which controls the default behavior (
CGROUP_MEM_RES_CTLR_SWAP_ENABLED) and changes the original noswapaccount parameter to swapaccount=true|false which provides a more fine grained way to control this feature.The default behavior is unchanged (if
CONFIG_CGROUP_MEM_RES_CTLR_SWAPis enabled thenCONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLEDis enabled as well)Signed-off-by Michal Hocko <[email protected]>--- init/Kconfig | 13 +++++++++++++ mm/memcontrol.c | 19 ++++++++++++++----- 2 files changed, 27 insertions(+), 5 deletions(-)init/Kconfig +13
-0@@ -613,6 +613,19 @@ config CGROUP_MEM_RES_CTLR_SWAP if boot option "noswapaccount" is set, swap will not be accounted. Now, memory usage of swap_cgroup is 2 bytes per entry. If swap page size is 4096bytes, 512k per 1Gbytes of swap. +config CGROUP_MEM_RES_CTLR_SWAP_ENABLED + bool "Memory Resource Controller Swap Extension enabled by default" + depends on CGROUP_MEM_RES_CTLR_SWAP + default y + help + Memory Resource Controller Swap Extension comes with its price in + a bigger memory consumption. General purpose distribution kernels + which want to enable the feautre but keep it disabled by default + and let the user enable it by swapaccount=true boot command line + parameter should have this option unselected. + For those who want to have the feature enabled by default should + select this option (if, for some reason, they need to disable it + then swapaccount=false does the trick). menuconfig CGROUP_SCHED bool "Group CPU scheduler"mm/memcontrol.c +14
-5@@ -61,7 +61,14 @@ struct mem_cgroup *root_mem_cgroup __read_mostly;#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */ int do_swap_account__read_mostly ; -static int really_do_swap_account__initdata =1 ;/* for remember boot option*/ + +/* for remember boot option*/ +#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED +static int really_do_swap_account__initdata =1 ; +#else +static int really_do_swap_account__initdata =0 ; +#endif +#else #define do_swap_account (0)#endif @@ -4909,11 +4916,13 @@ struct cgroup_subsys mem_cgroup_subsys = { };#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP - -static int __init disable_swap_account (char *s) +static int __init enable_swap_account (char *s) { - really_do_swap_account =0 ; +if (!s || !strcmp (s,"true" )) + really_do_swap_account =1 ; +else if (!strcmp (s,"false" )) + really_do_swap_account =0 ;return 1 ; } -__setup ("noswapaccount" , disable_swap_account); +__setup ("swapaccount" , enable_swap_account);#endif Signature · 17 lines
1.7.2.3 -- Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"[email protected]"> [email protected] </a>--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Signature · 13 lines
Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 28 lines · On Thu, 11 Nov 2010 10:31:55 +0100 Michal Hocko <[email protected]> wrote:
Quoted 27 lines · Daisuke Nishimura
Quoted 11 lines · On Wed, 10 Nov 2010 13:51:54 +0100 Michal Hocko <[email protected]> wrote:
Hi,
could you consider the patch bellow? It basically changes the default swap accounting behavior (when it is turned on in configuration) to be configurable as well.The rationale is described in the patch but in short it makes it much more easier to enable this feature in distribution kernels as the functionality can be provided in the general purpose kernel (with the option disabled) without any drawbacks and interested users can enable it. This is not possible currently.
Quoted 9 lines
I am aware that boot command line parameter name change is not ideal but the original semantic wasn't good enough and I don't like noswapaccount=yes|no very much.
If we really have to stick to it I can rework the patch to keep the name and just add the yes|no logic, though. Or we can keep the original one and add swapaccount paramete which would mean the oposite as the other one.
hmm, I agree that current parameter name(noswapaccount) is not desirable for yes|no, but IMHO changing the user
interface(iow, making what worked before unusable)is worse.
Quoted 7 lines
Quoted 2 lines
Although I'm not sure how many people are using this parameter, I vote for using "noswapaccount[=(yes|no)]".
Isn't a new swapaccount parameter better than that? I know we don't want to have too many parameters but having a something with a clear meaning is better IMO (noswapaccount=no doesn't sound very intuitive to me).
Fair enough. It's just an trade-off between compatibility and understandability.
Quoted 6 lines
Quoted 1 line
And you should update
Documentation/kernel-parameters.txttoo.Yes, I am aware of that and will do that once there is an agreement on the patch itself. At this stage, I just wanted to have a feadback about the change.
I'll ack your patch when it's been released with documentation update.
Thanks,
Daisuke Nishimura.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [RFC PATCH] Make swap accounting default behavior configurable v2
Quoted 40 lines · Daisuke Nishimura
Quoted 28 lines · On Thu, 11 Nov 2010 10:31:55 +0100 Michal Hocko <[email protected]> wrote:
Quoted 27 lines · Daisuke Nishimura
Quoted 11 lines · On Wed, 10 Nov 2010 13:51:54 +0100 Michal Hocko <[email protected]> wrote:
Hi,
could you consider the patch bellow? It basically changes the default swap accounting behavior (when it is turned on in configuration) to be configurable as well.The rationale is described in the patch but in short it makes it much more easier to enable this feature in distribution kernels as the functionality can be provided in the general purpose kernel (with the option disabled) without any drawbacks and interested users can enable it. This is not possible currently.
Quoted 9 lines
I am aware that boot command line parameter name change is not ideal but the original semantic wasn't good enough and I don't like noswapaccount=yes|no very much.
If we really have to stick to it I can rework the patch to keep the name and just add the yes|no logic, though. Or we can keep the original one and add swapaccount paramete which would mean the oposite as the other one.
hmm, I agree that current parameter name(noswapaccount) is not desirable for yes|no, but IMHO changing the user
interface(iow, making what worked before unusable)is worse.Quoted 7 lines
Quoted 2 lines
Although I'm not sure how many people are using this parameter, I vote for using "noswapaccount[=(yes|no)]".
Isn't a new swapaccount parameter better than that? I know we don't want to have too many parameters but having a something with a clear meaning is better IMO (noswapaccount=no doesn't sound very intuitive to me).
Fair enough. It's just an trade-off between compatibility and understandability.
Quoted 7 lines
Quoted 6 lines
Quoted 1 line
And you should update
Documentation/kernel-parameters.txttoo.Yes, I am aware of that and will do that once there is an agreement on the patch itself. At this stage, I just wanted to have a feadback about the change.
I'll ack your patch when it's been released with documentation update.
Changes since v1:
* do not remove noswapaccount parameter and add swapaccount parameter instead
* Documentation/kernel-parameters.txt updated
---
Re: [RFC PATCH] Make swap accounting default behavior configurable v2
Quoted 94 lines · On Fri, 12 Nov 2010 09:31:03 +0100 Michal Hocko <[email protected]> wrote:
Quoted 40 lines · Daisuke Nishimura
Quoted 28 lines · On Thu, 11 Nov 2010 10:31:55 +0100 Michal Hocko <[email protected]> wrote:
Quoted 27 lines · Daisuke Nishimura
Quoted 11 lines · On Wed, 10 Nov 2010 13:51:54 +0100 Michal Hocko <[email protected]> wrote:
Hi,
could you consider the patch bellow? It basically changes the default swap accounting behavior (when it is turned on in configuration) to be configurable as well.The rationale is described in the patch but in short it makes it much more easier to enable this feature in distribution kernels as the functionality can be provided in the general purpose kernel (with the option disabled) without any drawbacks and interested users can enable it. This is not possible currently.
Quoted 9 lines
I am aware that boot command line parameter name change is not ideal but the original semantic wasn't good enough and I don't like noswapaccount=yes|no very much.
If we really have to stick to it I can rework the patch to keep the name and just add the yes|no logic, though. Or we can keep the original one and add swapaccount paramete which would mean the oposite as the other one.
hmm, I agree that current parameter name(noswapaccount) is not desirable for yes|no, but IMHO changing the user
interface(iow, making what worked before unusable)is worse.Quoted 7 lines
Quoted 2 lines
Although I'm not sure how many people are using this parameter, I vote for using "noswapaccount[=(yes|no)]".
Isn't a new swapaccount parameter better than that? I know we don't want to have too many parameters but having a something with a clear meaning is better IMO (noswapaccount=no doesn't sound very intuitive to me).
Fair enough. It's just an trade-off between compatibility and understandability.
Quoted 7 lines
Quoted 6 lines
Quoted 1 line
And you should update
Documentation/kernel-parameters.txttoo.Yes, I am aware of that and will do that once there is an agreement on the patch itself. At this stage, I just wanted to have a feadback about the change.
I'll ack your patch when it's been released with documentation update.
Changes since v1:
* do not remove noswapaccount parameter and add swapaccount parameter instead
*Documentation/kernel-parameters.txtupdated---
Fromc60e3d76702cd9b4b5b13c01be335da31d03bc1cMon Sep 17 00:00:00 2001
From: Michal Hocko <[email protected]>
Date: Wed, 10 Nov 2010 13:30:04 +0100
Subject: [PATCH] Make swap accounting default behavior configurableSwap accounting can be configured by
CONFIG_CGROUP_MEM_RES_CTLR_SWAPconfiguration option and then it is turned on by default. There is a boot option (noswapaccount) which can disable this feature.This makes it hard for distributors to enable the configuration option as this feature leads to a bigger memory consumption and this is a no-go for general purpose distribution kernel. On the other hand swap accounting may be very usuful for some workloads.
This patch adds a new configuration option which controls the default behavior (
CGROUP_MEM_RES_CTLR_SWAP_ENABLED). If the option is selected then the feature is turned on by default.It also adds a new boot parameter swapaccount which (contrary to noswapaccount) enables the feature. (I would consider swapaccount=yes|no semantic with removed noswapaccount parameter much better but this parameter is kind of API which might be in use and unexpected breakage is no-go.)
The default behavior is unchanged (if
CONFIG_CGROUP_MEM_RES_CTLR_SWAPis enabled thenCONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLEDis enabled as well)Signed-off-by Michal Hocko <[email protected]>--- Documentation/kernel-parameters.txt | 2 ++ init/Kconfig | 13 +++++++++++++ mm/memcontrol.c | 15 ++++++++++++++- 3 files changed, 29 insertions(+), 1 deletions(-)Documentation/kernel-parameters.txt +0
-0
Documentation/kernel-parameters.txt and is between 256 and 4096 characters. It is defined in the file · line 1759
Quoted 8 lines
Documentation/kernel-parameters.txt +2
-0@@ -1752,6 +1752,8 @@ and is between 256 and 4096 characters. It is defined in the file noswapaccount [KNL] Disable accounting of swap in memory resource controller. (See Documentation/cgroups/memory.txt) + swapaccount [KNL] Enable accounting of swap in memory resource + controller. (See Documentation/cgroups/memory.txt) nosync [HW,M68K] Disables sync negotiation for all devices.
(I've add Andrew and Balbir to CC-list.)
It seems that almost all parameters are listed in alphabetic order in the document, so I think it would be better to obey the rule.
Thanks,
Daisuke Nishimura.
Quoted 60 lines
init/Kconfig +13
-0@@ -613,6 +613,19 @@ config CGROUP_MEM_RES_CTLR_SWAP if boot option "noswapaccount" is set, swap will not be accounted. Now, memory usage of swap_cgroup is 2 bytes per entry. If swap page size is 4096bytes, 512k per 1Gbytes of swap. +config CGROUP_MEM_RES_CTLR_SWAP_ENABLED + bool "Memory Resource Controller Swap Extension enabled by default" + depends on CGROUP_MEM_RES_CTLR_SWAP + default y + help + Memory Resource Controller Swap Extension comes with its price in + a bigger memory consumption. General purpose distribution kernels + which want to enable the feautre but keep it disabled by default + and let the user enable it by swapaccount boot command line + parameter should have this option unselected. + For those who want to have the feature enabled by default should + select this option (if, for some reason, they need to disable it + then noswapaccount does the trick). menuconfig CGROUP_SCHED bool "Group CPU scheduler"mm/memcontrol.c +14
-1@@ -61,7 +61,14 @@ struct mem_cgroup *root_mem_cgroup __read_mostly;#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */ int do_swap_account__read_mostly ; -static int really_do_swap_account__initdata =1 ;/* for remember boot option*/ + +/* for remember boot option*/ +#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED +static int really_do_swap_account__initdata =1 ; +#else +static int really_do_swap_account__initdata =0 ; +#endif +#else #define do_swap_account (0)#endif @@ -4909,6 +4916,12 @@ struct cgroup_subsys mem_cgroup_subsys = { };#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP +static int __init enable_swap_account (char *s) +{ + really_do_swap_account =1 ; +return 1 ; +} +__setup ("swapaccount" , enable_swap_account);static int __init disable_swap_account (char *s) {Signature · 1 line
1.7.2.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [RFC PATCH] Make swap accounting default behavior configurable v2
* [email protected] <[email protected]> [2010-11-15 10:13:35]:
Thanks Nishimura-San
It seems like the motivation for the patch is to allow distros to enable memory cgroups and swap control, but to have swap control turned off by default (because we provide default on today)
- is my understanding correct?
Signature · 9 lines
Three Cheers, Balbir -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [RFC PATCH] Make swap accounting default behavior configurable v2
Quoted 9 lines · On Mon, 15 Nov 2010 07:33:30 +0530 Balbir Singh <[email protected]>…
* [email protected] <[email protected]> [2010-11-15 10:13:35]:
Thanks Nishimura-San
It seems like the motivation for the patch is to allow distros to enable memory cgroups and swap control, but to have swap control turned off by default (because we provide default on today)
- is my understanding correct?
I think you're right.
This patch make the default behavior configurable by .config and let users turn swap control on even if it's disabled by .config.
It will give distros and users wider choice.
Thanks,
Daisuke Nishimura.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [RFC PATCH] Make swap accounting default behavior configurable v3
In reply to Daisuke NishimuraQuoted 1 line · Daisuke Nishimura
On Fri, 12 Nov 2010 09:31:03 +0100
[...]
Quoted 11 lines
Quoted 11 lines
Documentation/kernel-parameters.txt +2
-0@@ -1752,6 +1752,8 @@ and is between 256 and 4096 characters. It is defined in the file noswapaccount [KNL] Disable accounting of swap in memory resource controller. (See Documentation/cgroups/memory.txt) + swapaccount [KNL] Enable accounting of swap in memory resource + controller. (See Documentation/cgroups/memory.txt)
Quoted 5 lines
Documentation/kernel-parameters.txt and is between 256 and 4096 characters. It is defined in the file · line 1759
Quoted 2 lines
Documentation/kernel-parameters.txt +0
-0nosync [HW,M68K] Disables sync negotiation for all devices.(I've add Andrew and Balbir to CC-list.)
It seems that almost all parameters are listed in alphabetic order in the document, so I think it would be better to obey the rule.
You are right. The header of the file says:
" The following is a consolidated list of the kernel parameters as implemented (mostly) by the __setup() macro and sorted into English Dictionary order (defined as ignoring all punctuation and sorting digits before letters in a case insensitive manner), and with descriptions where known."
Updated patch follows bellow.
Quoted 3 lines
Thanks,
Daisuke Nishimura.
Changes since v2:
* put the new parameter description to the proper (alphabetically sorted) place in Documentation/kernel-parameters.txt
Changes since v1:
* do not remove noswapaccount parameter and add swapaccount parameter instead
* Documentation/kernel-parameters.txt updated
---
Quoted 1 line
From
21df3801e2b65f47a2807534487ebb353dad6340Mon Sep 17 00:00:00 2001
From: Michal Hocko <[email protected]>
Date: Wed, 10 Nov 2010 13:30:04 +0100
Subject: [PATCH] Make swap accounting default behavior configurable
Swap accounting can be configured by CONFIG_CGROUP_MEM_RES_CTLR_SWAP configuration option and then it is turned on by default. There is a boot option (noswapaccount) which can disable this feature.
This makes it hard for distributors to enable the configuration option as this feature leads to a bigger memory consumption and this is a no-go for general purpose distribution kernel. On the other hand swap accounting may be very usuful for some workloads.
This patch adds a new configuration option which controls the default behavior (CGROUP_MEM_RES_CTLR_SWAP_ENABLED). If the option is selected then the feature is turned on by default.
It also adds a new boot parameter swapaccount which (contrary to noswapaccount) enables the feature. (I would consider swapaccount=yes|no semantic with removed noswapaccount parameter much better but this parameter is kind of API which might be in use and unexpected breakage is no-go.)
The default behavior is unchanged (if CONFIG_CGROUP_MEM_RES_CTLR_SWAP is enabled then CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED is enabled as well)
--- Documentation/kernel-parameters.txt | 3 +++ init/Kconfig | 13 +++++++++++++ mm/memcontrol.c | 15 ++++++++++++++- 3 files changed, 30 insertions(+), 1 deletions(-)
Documentation/kernel-parameters.txt +3 -0
@@ -2385,6 +2385,9 @@ and is between 256 and 4096 characters. It is defined in the file improve throughput, but will also increase the amount of memory reserved for use by the client. + swapaccount [KNL] Enable accounting of swap in memory resource + controller. (See Documentation/cgroups/memory.txt) + swiotlb= [IA-64] Number of I/O TLB slabs switches= [HW,M68k]
init/Kconfig +13 -0
@@ -613,6 +613,19 @@ config CGROUP_MEM_RES_CTLR_SWAP if boot option "noswapaccount" is set, swap will not be accounted. Now, memory usage of swap_cgroup is 2 bytes per entry. If swap page size is 4096bytes, 512k per 1Gbytes of swap. +config CGROUP_MEM_RES_CTLR_SWAP_ENABLED + bool "Memory Resource Controller Swap Extension enabled by default" + depends on CGROUP_MEM_RES_CTLR_SWAP + default y + help + Memory Resource Controller Swap Extension comes with its price in + a bigger memory consumption. General purpose distribution kernels + which want to enable the feautre but keep it disabled by default + and let the user enable it by swapaccount boot command line + parameter should have this option unselected. + For those who want to have the feature enabled by default should + select this option (if, for some reason, they need to disable it + then noswapaccount does the trick). menuconfig CGROUP_SCHED bool "Group CPU scheduler"
mm/memcontrol.c +14 -1
@@ -61,7 +61,14 @@ struct mem_cgroup *root_mem_cgroup __read_mostly;#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */ int do_swap_account__read_mostly ; -static int really_do_swap_account__initdata =1 ;/* for remember boot option*/ + +/* for remember boot option*/ +#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED +static int really_do_swap_account__initdata =1 ; +#else +static int really_do_swap_account__initdata =0 ; +#endif +#else #define do_swap_account (0)#endif
@@ -4909,6 +4916,12 @@ struct cgroup_subsys mem_cgroup_subsys = { };#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP +static int __init enable_swap_account (char *s) +{ + really_do_swap_account =1 ; +return 1 ; +} +__setup ("swapaccount" , enable_swap_account);static int __init disable_swap_account (char *s) {
Signature · 9 lines
1.7.2.3 -- Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
Daisuke Nishimura
Acked-byRe: [RFC PATCH] Make swap accounting default behavior configurable v3
Thank you for your work.
Daisuke Nishimura.
Quoted 158 lines · On Mon, 15 Nov 2010 09:35:40 +0100 Michal Hocko <[email protected]> wrote:
Quoted 1 line · Daisuke Nishimura
On Fri, 12 Nov 2010 09:31:03 +0100
[...]
Quoted 11 lines
Quoted 11 lines
Documentation/kernel-parameters.txt +2
-0@@ -1752,6 +1752,8 @@ and is between 256 and 4096 characters. It is defined in the file noswapaccount [KNL] Disable accounting of swap in memory resource controller. (See Documentation/cgroups/memory.txt) + swapaccount [KNL] Enable accounting of swap in memory resource + controller. (See Documentation/cgroups/memory.txt)Quoted 5 lines
Documentation/kernel-parameters.txt and is between 256 and 4096 characters. It is defined in the file · line 1759
Quoted 2 lines
Documentation/kernel-parameters.txt +0
-0nosync [HW,M68K] Disables sync negotiation for all devices.(I've add Andrew and Balbir to CC-list.)
It seems that almost all parameters are listed in alphabetic order in the document, so I think it would be better to obey the rule.You are right. The header of the file says:
" The following is a consolidated list of the kernel parameters as implemented (mostly) by the
__setup()macro and sorted into English Dictionary order (defined as ignoring all punctuation and sorting digits before letters in a case insensitive manner), and with descriptions where known."Updated patch follows bellow.
Quoted 3 lines
Thanks,
Daisuke Nishimura.Changes since v2:
* put the new parameter description to the proper (alphabetically sorted) place inDocumentation/kernel-parameters.txtChanges since v1:
* do not remove noswapaccount parameter and add swapaccount parameter instead
*Documentation/kernel-parameters.txtupdated
---From
21df3801e2b65f47a2807534487ebb353dad6340Mon Sep 17 00:00:00 2001
From: Michal Hocko <[email protected]>
Date: Wed, 10 Nov 2010 13:30:04 +0100
Subject: [PATCH] Make swap accounting default behavior configurableSwap accounting can be configured by
CONFIG_CGROUP_MEM_RES_CTLR_SWAPconfiguration option and then it is turned on by default. There is a boot option (noswapaccount) which can disable this feature.This makes it hard for distributors to enable the configuration option as this feature leads to a bigger memory consumption and this is a no-go for general purpose distribution kernel. On the other hand swap accounting may be very usuful for some workloads.
This patch adds a new configuration option which controls the default behavior (
CGROUP_MEM_RES_CTLR_SWAP_ENABLED). If the option is selected then the feature is turned on by default.It also adds a new boot parameter swapaccount which (contrary to noswapaccount) enables the feature. (I would consider swapaccount=yes|no semantic with removed noswapaccount parameter much better but this parameter is kind of API which might be in use and unexpected breakage is no-go.)
The default behavior is unchanged (if
CONFIG_CGROUP_MEM_RES_CTLR_SWAPis enabled thenCONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLEDis enabled as well)Signed-off-by Michal Hocko <[email protected]>--- Documentation/kernel-parameters.txt | 3 +++ init/Kconfig | 13 +++++++++++++ mm/memcontrol.c | 15 ++++++++++++++- 3 files changed, 30 insertions(+), 1 deletions(-)Documentation/kernel-parameters.txt +3
-0@@ -2385,6 +2385,9 @@ and is between 256 and 4096 characters. It is defined in the file improve throughput, but will also increase the amount of memory reserved for use by the client. + swapaccount [KNL] Enable accounting of swap in memory resource + controller. (See Documentation/cgroups/memory.txt) + swiotlb= [IA-64] Number of I/O TLB slabs switches= [HW,M68k]init/Kconfig +13
-0@@ -613,6 +613,19 @@ config CGROUP_MEM_RES_CTLR_SWAP if boot option "noswapaccount" is set, swap will not be accounted. Now, memory usage of swap_cgroup is 2 bytes per entry. If swap page size is 4096bytes, 512k per 1Gbytes of swap. +config CGROUP_MEM_RES_CTLR_SWAP_ENABLED + bool "Memory Resource Controller Swap Extension enabled by default" + depends on CGROUP_MEM_RES_CTLR_SWAP + default y + help + Memory Resource Controller Swap Extension comes with its price in + a bigger memory consumption. General purpose distribution kernels + which want to enable the feautre but keep it disabled by default + and let the user enable it by swapaccount boot command line + parameter should have this option unselected. + For those who want to have the feature enabled by default should + select this option (if, for some reason, they need to disable it + then noswapaccount does the trick). menuconfig CGROUP_SCHED bool "Group CPU scheduler"mm/memcontrol.c +14
-1@@ -61,7 +61,14 @@ struct mem_cgroup *root_mem_cgroup __read_mostly;#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */ int do_swap_account__read_mostly ; -static int really_do_swap_account__initdata =1 ;/* for remember boot option*/ + +/* for remember boot option*/ +#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED +static int really_do_swap_account__initdata =1 ; +#else +static int really_do_swap_account__initdata =0 ; +#endif +#else #define do_swap_account (0)#endif @@ -4909,6 +4916,12 @@ struct cgroup_subsys mem_cgroup_subsys = { };#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP +static int __init enable_swap_account (char *s) +{ + really_do_swap_account =1 ; +return 1 ; +} +__setup ("swapaccount" , enable_swap_account);static int __init disable_swap_account (char *s) {Signature · 9 lines
1.7.2.3 -- Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [RFC PATCH] Make swap accounting default behavior configurable v3
Quoted 1 line · Daisuke Nishimura
Thank you. What should be next steps? Waiting for other ACKs or push it through Andrew?
Btw. is this a stable tree material? I guess that distribution would like to have this patch and the stable is the easiest way how to deliver this.
Quoted 172 lines
Thank you for your work.
Daisuke Nishimura.Quoted 158 lines · On Mon, 15 Nov 2010 09:35:40 +0100 Michal Hocko <[email protected]> wrote:
Quoted 1 line · Daisuke Nishimura
On Fri, 12 Nov 2010 09:31:03 +0100
[...]
Quoted 11 lines
Quoted 11 lines
Documentation/kernel-parameters.txt +2
-0@@ -1752,6 +1752,8 @@ and is between 256 and 4096 characters. It is defined in the file noswapaccount [KNL] Disable accounting of swap in memory resource controller. (See Documentation/cgroups/memory.txt) + swapaccount [KNL] Enable accounting of swap in memory resource + controller. (See Documentation/cgroups/memory.txt)Quoted 5 lines
Documentation/kernel-parameters.txt and is between 256 and 4096 characters. It is defined in the file · line 1759
Quoted 2 lines
Documentation/kernel-parameters.txt +0
-0nosync [HW,M68K] Disables sync negotiation for all devices.(I've add Andrew and Balbir to CC-list.)
It seems that almost all parameters are listed in alphabetic order in the document, so I think it would be better to obey the rule.You are right. The header of the file says:
" The following is a consolidated list of the kernel parameters as implemented (mostly) by the
__setup()macro and sorted into English Dictionary order (defined as ignoring all punctuation and sorting digits before letters in a case insensitive manner), and with descriptions where known."Updated patch follows bellow.
Quoted 3 lines
Thanks,
Daisuke Nishimura.Changes since v2:
* put the new parameter description to the proper (alphabetically sorted) place inDocumentation/kernel-parameters.txtChanges since v1:
* do not remove noswapaccount parameter and add swapaccount parameter instead
*Documentation/kernel-parameters.txtupdated
---From
21df3801e2b65f47a2807534487ebb353dad6340Mon Sep 17 00:00:00 2001
From: Michal Hocko <[email protected]>
Date: Wed, 10 Nov 2010 13:30:04 +0100
Subject: [PATCH] Make swap accounting default behavior configurableSwap accounting can be configured by
CONFIG_CGROUP_MEM_RES_CTLR_SWAPconfiguration option and then it is turned on by default. There is a boot option (noswapaccount) which can disable this feature.This makes it hard for distributors to enable the configuration option as this feature leads to a bigger memory consumption and this is a no-go for general purpose distribution kernel. On the other hand swap accounting may be very usuful for some workloads.
This patch adds a new configuration option which controls the default behavior (
CGROUP_MEM_RES_CTLR_SWAP_ENABLED). If the option is selected then the feature is turned on by default.It also adds a new boot parameter swapaccount which (contrary to noswapaccount) enables the feature. (I would consider swapaccount=yes|no semantic with removed noswapaccount parameter much better but this parameter is kind of API which might be in use and unexpected breakage is no-go.)
The default behavior is unchanged (if
CONFIG_CGROUP_MEM_RES_CTLR_SWAPis enabled thenCONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLEDis enabled as well)Signed-off-by Michal Hocko <[email protected]>--- Documentation/kernel-parameters.txt | 3 +++ init/Kconfig | 13 +++++++++++++ mm/memcontrol.c | 15 ++++++++++++++- 3 files changed, 30 insertions(+), 1 deletions(-)Documentation/kernel-parameters.txt +3
-0@@ -2385,6 +2385,9 @@ and is between 256 and 4096 characters. It is defined in the file improve throughput, but will also increase the amount of memory reserved for use by the client. + swapaccount [KNL] Enable accounting of swap in memory resource + controller. (See Documentation/cgroups/memory.txt) + swiotlb= [IA-64] Number of I/O TLB slabs switches= [HW,M68k]init/Kconfig +13
-0@@ -613,6 +613,19 @@ config CGROUP_MEM_RES_CTLR_SWAP if boot option "noswapaccount" is set, swap will not be accounted. Now, memory usage of swap_cgroup is 2 bytes per entry. If swap page size is 4096bytes, 512k per 1Gbytes of swap. +config CGROUP_MEM_RES_CTLR_SWAP_ENABLED + bool "Memory Resource Controller Swap Extension enabled by default" + depends on CGROUP_MEM_RES_CTLR_SWAP + default y + help + Memory Resource Controller Swap Extension comes with its price in + a bigger memory consumption. General purpose distribution kernels + which want to enable the feautre but keep it disabled by default + and let the user enable it by swapaccount boot command line + parameter should have this option unselected. + For those who want to have the feature enabled by default should + select this option (if, for some reason, they need to disable it + then noswapaccount does the trick). menuconfig CGROUP_SCHED bool "Group CPU scheduler"mm/memcontrol.c +14
-1@@ -61,7 +61,14 @@ struct mem_cgroup *root_mem_cgroup __read_mostly;#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */ int do_swap_account__read_mostly ; -static int really_do_swap_account__initdata =1 ;/* for remember boot option*/ + +/* for remember boot option*/ +#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED +static int really_do_swap_account__initdata =1 ; +#else +static int really_do_swap_account__initdata =0 ; +#endif +#else #define do_swap_account (0)#endif @@ -4909,6 +4916,12 @@ struct cgroup_subsys mem_cgroup_subsys = { };#ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP +static int __init enable_swap_account (char *s) +{ + really_do_swap_account =1 ; +return 1 ; +} +__setup ("swapaccount" , enable_swap_account);static int __init disable_swap_account (char *s) {Signature · 9 lines
1.7.2.3 -- Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Signature · 13 lines
Michal Hocko L3 team SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Re: [RFC PATCH] Make swap accounting default behavior configurable v3
Quoted 5 lines · On Tue, 16 Nov 2010 09:15:44 +0100 Michal Hocko <[email protected]> wrote:
Quoted 1 line · Daisuke Nishimura
Thank you. What should be next steps? Waiting for other ACKs or push it through Andrew?
I recommend you to resend the patch removing "RFC" in a clean patch format (i.e. without any quotes).
Quoted 4 lines
Btw. is this a stable tree material? I guess that distribution would like to have this patch and the stable is the easiest way how to deliver this.
It's not stable material. This is not a BUG or anything that meets the conditions described in Documentation/stable_kernel_rules.txt.
Thanks,
Daisuke Nishimura.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>