Skip to contentSkip to conversation

dove: add support for CM-A510 machine.

PATCH New Konstantin Sinyuk 6 participants 13 messages Oct 7, 2010 – Nov 11, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

---
 arch/arm/mach-dove/Kconfig   |    6 +++
 arch/arm/mach-dove/Makefile  |    1 +
 arch/arm/mach-dove/cm-a510.c |   96 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 103 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-dove/cm-a510.c
arch/arm/mach-dove/Kconfig +6 -0
index 3b9a32a..a4ed390 100644
@@ -9,6 +9,12 @@ config MACH_DOVE_DB
 	  Say 'Y' here if you want your kernel to support the
 	  Marvell DB-MV88AP510 Development Board.
 
+ config MACH_CM_A510
+	bool "CompuLab CM-A510 Board"
+	help
+	  Say 'Y' here if you want your kernel to support the
+	  CompuLab CM-A510 Board.
+
 endmenu
 
 endif
arch/arm/mach-dove/Makefile +1 -0
index 7ab3be5..f74f549 100644
@@ -1,3 +1,4 @@
 obj-y				+= common.o addr-map.o irq.o pcie.o
 
 obj-$(CONFIG_MACH_DOVE_DB)	+= dove-db-setup.o
+obj-$(CONFIG_MACH_CM_A510)	+= cm-a510.o
arch/arm/mach-dove/cm-a510.c new file +96 -0

96 lines not on this page · raw message

--
1.7.0.4

#1 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

Quoted 116 lines · Konstantin Sinyuk

---

?arch/arm/mach-dove/Kconfig ? | ? ?6 +++
?arch/arm/mach-dove/Makefile ?| ? ?1 +
?arch/arm/mach-dove/cm-a510.c | ? 96 ++++++++++++++++++++++++++++++++++++++++++

?3 files changed, 103 insertions(+), 0 deletions(-) ?create mode 100644 arch/arm/mach-dove/cm-a510.c

arch/arm/mach-dove/Kconfig +0 -0
index 3b9a32a..a4ed390 100644
@@ -9,6 +9,12 @@ config MACH_DOVE_DB

? ? ? ? ?Say 'Y' here if you want your kernel to support the ? ? ? ? ?Marvell DB-MV88AP510 Development Board.

+ config MACH_CM_A510
+ ? ? ? bool "CompuLab CM-A510 Board"
+ ? ? ? help
+ ? ? ? ? Say 'Y' here if you want your kernel to support the
+ ? ? ? ? CompuLab CM-A510 Board.
+
?endmenu

?endif

arch/arm/mach-dove/Makefile +0 -0
index 7ab3be5..f74f549 100644
@@ -1,3 +1,4 @@

?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ?+= common.o addr-map.o irq.o pcie.o

?obj-$(CONFIG_MACH_DOVE_DB) ? ? += dove-db-setup.o

arch/arm/mach-dove/Makefile +1 -0
+obj-$(CONFIG_MACH_CM_A510) ? ? += cm-a510.o
arch/arm/mach-dove/cm-a510.c new file +75 -0
new file mode 100644
index 0000000..321c961
@@ -0,0 +1,96 @@
+/*
+ * arch/arm/mach-dove/cm-a510.c
+ *
+ * Copyright (C) 2010 CompuLab, Ltd.
+ * Konstantin Sinyuk <[email protected]>
+ *
+ * Based on Marvell DB-MV88AP510-BP Development Board Setup
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. ?This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/ata_platform.h>
+#include <linux/mv643xx_eth.h>
+#include <linux/spi/spi.h>
+#include <linux/spi/flash.h>
+
+#include <asm/mach-types.h>
+#include <asm/mach/arch.h>
+
+#include <mach/dove.h>
+
+#include "common.h"
+
+static struct mv643xx_eth_platform_data cm_a510_ge00_data = {
+ ? ? ? .phy_addr ? ? ? = MV643XX_ETH_PHY_ADDR_DEFAULT,
+};
+
+static struct mv_sata_platform_data cm_a510_sata_data = {
+ ? ? ? .n_ports ? ? ? ?= 1,
+};
+
+/*
+ * SPI Devices:
+ * SPI0: 1M Flash Winbond w25q32bv
+ */
+static const struct flash_platform_data cm_a510_spi_flash_data = {
+ ? ? ? .type ? ? ? ? ? = "w25q32bv",
+};
+
+static struct spi_board_info __initdata cm_a510_spi_flash_info[] = {
+ ? ? ? {
+ ? ? ? ? ? ? ? .modalias ? ? ? = "m25p80",
+ ? ? ? ? ? ? ? .platform_data ?= &cm_a510_spi_flash_data,
+ ? ? ? ? ? ? ? .irq ? ? ? ? ? ?= -1,
+ ? ? ? ? ? ? ? .max_speed_hz ? = 20000000,
+ ? ? ? ? ? ? ? .bus_num ? ? ? ?= 0,
+ ? ? ? ? ? ? ? .chip_select ? ?= 0,
+ ? ? ? },
+};
+
+static int __init cm_a510_pci_init(void)
+{
+ ? ? ? if (machine_is_cm_a510())
+ ? ? ? ? ? ? ? dove_pcie_init(1, 1);
+
+ ? ? ? return 0;
+}
+
+subsys_initcall(cm_a510_pci_init);
+
+/* Board Init */
+static void __init cm_a510_init(void)
+{
+ ? ? ? /*
+ ? ? ? ?* Basic Dove setup. Needs to be called early.
+ ? ? ? ?*/
+ ? ? ? dove_init();
+
+ ? ? ? dove_ge00_init(&cm_a510_ge00_data);
+ ? ? ? dove_ehci0_init();
+ ? ? ? dove_ehci1_init();

arch/arm/mach-dove/cm-a510.c line 85

Quoted 10 lines
arch/arm/mach-dove/cm-a510.c new file +10 -0
+ ? ? ? dove_sata_init(&cm_a510_sata_data);
+ ? ? ? dove_sdio0_init();
+ ? ? ? dove_sdio1_init();
+ ? ? ? dove_spi0_init();
+ ? ? ? dove_spi1_init();
+ ? ? ? dove_uart0_init();
+ ? ? ? dove_uart1_init();
+ ? ? ? dove_i2c_init();
+ ? ? ? spi_register_board_info(cm_a510_spi_flash_info,
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ARRAY_SIZE(cm_a510_spi_flash_info));

Konstantin, are you sure your board has all the above interfaces? other than that the patch looks fine to me.

Quoted 13 lines
arch/arm/mach-dove/cm-a510.c new file +11 -1
+}
+
+MACHINE_START(CM_A510, "Compulab CM-A510 Board")
+ ? ? ? .phys_io ? ? ? ?= DOVE_SB_REGS_PHYS_BASE,
+ ? ? ? .io_pg_offst ? ?= ((DOVE_SB_REGS_VIRT_BASE) >> 18) & 0xfffc,
+ ? ? ? .boot_params ? ?= 0x00000100,
+ ? ? ? .init_machine ? = cm_a510_init,
+ ? ? ? .map_io ? ? ? ? = dove_map_io,
+ ? ? ? .init_irq ? ? ? = dove_init_irq,
+ ? ? ? .timer ? ? ? ? ?= &dove_timer,
+MACHINE_END
--

1.7.0.4

#2 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

Quoted 5 lines · saeed bishara
Quoted 3 lines · Konstantin Sinyuk

---

[ snip ]

Quoted 15 lines
Quoted 15 lines
arch/arm/mach-dove/cm-a510.c new file +15 -0
+/* Board Init */
+static void __init cm_a510_init(void)
+{
+       /*
+        * Basic Dove setup. Needs to be called early.
+        */
+       dove_init();
+
+       dove_ge00_init(&cm_a510_ge00_data);
+       dove_ehci0_init();
+       dove_ehci1_init();
+       dove_sata_init(&cm_a510_sata_data);
+       dove_sdio0_init();
+       dove_sdio1_init();
+       dove_spi0_init();
Quoted 8 lines

arch/arm/mach-dove/cm-a510.c line 85

Quoted 6 lines
arch/arm/mach-dove/cm-a510.c new file +6 -0
+       dove_spi1_init();
+       dove_uart0_init();
+       dove_uart1_init();
+       dove_i2c_init();
+       spi_register_board_info(cm_a510_spi_flash_info,
+                               ARRAY_SIZE(cm_a510_spi_flash_info));

Konstantin, are you sure your board has all the above interfaces? other than that the patch looks fine to me.

Our board indeed has all the above interfaces. Moreover, it uses other Dove interfaces that haven't yet hit the mainline.

Quoted 13 lines
Quoted 13 lines
arch/arm/mach-dove/cm-a510.c new file +11 -1
+}
+
+MACHINE_START(CM_A510, "Compulab CM-A510 Board")
+       .phys_io        = DOVE_SB_REGS_PHYS_BASE,
+       .io_pg_offst    = ((DOVE_SB_REGS_VIRT_BASE) >> 18) & 0xfffc,
+       .boot_params    = 0x00000100,
+       .init_machine   = cm_a510_init,
+       .map_io         = dove_map_io,
+       .init_irq       = dove_init_irq,
+       .timer          = &dove_timer,
+MACHINE_END
--

1.7.0.4

Signature · 2 lines
Sincerely yours,
Mike.
#3 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

In reply to Konstantin Sinyuk

Hi Russell,
Shell we send it to your patch system?

Quoted 140 lines · Konstantin Sinyuk
---
 arch/arm/mach-dove/Kconfig   |    6 +++
 arch/arm/mach-dove/Makefile  |    1 +
 arch/arm/mach-dove/cm-a510.c |   96 ++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 103 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/mach-dove/cm-a510.c
arch/arm/mach-dove/Kconfig +6 -0
index 3b9a32a..a4ed390 100644
@@ -9,6 +9,12 @@ config MACH_DOVE_DB
 	  Say 'Y' here if you want your kernel to support the
 	  Marvell DB-MV88AP510 Development Board.
 
+ config MACH_CM_A510
+	bool "CompuLab CM-A510 Board"
+	help
+	  Say 'Y' here if you want your kernel to support the
+	  CompuLab CM-A510 Board.
+
 endmenu
 
 endif
arch/arm/mach-dove/Makefile +1 -0
index 7ab3be5..f74f549 100644
@@ -1,3 +1,4 @@
 obj-y				+= common.o addr-map.o irq.o pcie.o
 
 obj-$(CONFIG_MACH_DOVE_DB)	+= dove-db-setup.o
+obj-$(CONFIG_MACH_CM_A510)	+= cm-a510.o
arch/arm/mach-dove/cm-a510.c new file +96 -1
new file mode 100644
index 0000000..321c961
@@ -0,0 +1,96 @@
+/*
+ * arch/arm/mach-dove/cm-a510.c
+ *
+ * Copyright (C) 2010 CompuLab, Ltd.
+ * Konstantin Sinyuk <[email protected]>
+ *
+ * Based on Marvell DB-MV88AP510-BP Development Board Setup
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/ata_platform.h>
+#include <linux/mv643xx_eth.h>
+#include <linux/spi/spi.h>
+#include <linux/spi/flash.h>
+
+#include <asm/mach-types.h>
+#include <asm/mach/arch.h>
+
+#include <mach/dove.h>
+
+#include "common.h"
+
+static struct mv643xx_eth_platform_data cm_a510_ge00_data = {
+	.phy_addr	= MV643XX_ETH_PHY_ADDR_DEFAULT,
+};
+
+static struct mv_sata_platform_data cm_a510_sata_data = {
+	.n_ports        = 1,
+};
+
+/*
+ * SPI Devices:
+ * SPI0: 1M Flash Winbond w25q32bv
+ */
+static const struct flash_platform_data cm_a510_spi_flash_data = {
+	.type		= "w25q32bv",
+};
+
+static struct spi_board_info __initdata cm_a510_spi_flash_info[] = {
+	{
+		.modalias       = "m25p80",
+		.platform_data  = &cm_a510_spi_flash_data,
+		.irq            = -1,
+		.max_speed_hz   = 20000000,
+		.bus_num        = 0,
+		.chip_select    = 0,
+	},
+};
+
+static int __init cm_a510_pci_init(void)
+{
+	if (machine_is_cm_a510())
+		dove_pcie_init(1, 1);
+
+	return 0;
+}
+
+subsys_initcall(cm_a510_pci_init);
+
+/* Board Init */
+static void __init cm_a510_init(void)
+{
+	/*
+	 * Basic Dove setup. Needs to be called early.
+	 */
+	dove_init();
+
+	dove_ge00_init(&cm_a510_ge00_data);
+	dove_ehci0_init();
+	dove_ehci1_init();
+	dove_sata_init(&cm_a510_sata_data);
+	dove_sdio0_init();
+	dove_sdio1_init();
+	dove_spi0_init();
+	dove_spi1_init();
+	dove_uart0_init();
+	dove_uart1_init();
+	dove_i2c_init();
+	spi_register_board_info(cm_a510_spi_flash_info,
+				ARRAY_SIZE(cm_a510_spi_flash_info));
+}
+
+MACHINE_START(CM_A510, "Compulab CM-A510 Board")
+	.phys_io	= DOVE_SB_REGS_PHYS_BASE,
+	.io_pg_offst	= ((DOVE_SB_REGS_VIRT_BASE) >> 18) & 0xfffc,
+	.boot_params	= 0x00000100,
+	.init_machine	= cm_a510_init,
+	.map_io		= dove_map_io,
+	.init_irq	= dove_init_irq,
+	.timer		= &dove_timer,
+MACHINE_END
--

1.7.0.4

Signature · 2 lines
Sincerely yours,
Mike.
#4 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

Quoted 2 lines · Mike Rapoport

Hi Russell,
Shell we send it to your patch system?

I've no idea what to do about this. I can find no entry in MAINTAINERS for anyone who looks after Marvell Dove, so I assume it's another bit of orphaned code.

It seems that it started off being looked after by Nico, and now that Nico has moved on to pastures new, it's (presumably) maintainer-less.

Is there someone out there who'd be willing to look after this class of platforms and put their name in MAINTAINERS for it?

#5 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

Saeed?

Sent from my iPhone

Quoted 18 lines · Russell King - ARM Linux
Quoted 2 lines · Mike Rapoport

Hi Russell,
Shell we send it to your patch system?

I've no idea what to do about this. I can find no entry in MAINTAINERS for anyone who looks after Marvell Dove, so I assume it's another bit of orphaned code.

It seems that it started off being looked after by Nico, and now that Nico has moved on to pastures new, it's (presumably) maintainer-less.

Is there someone out there who'd be willing to look after this class of platforms and put their name in MAINTAINERS for it?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#6 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

In reply to Russell King - ARM Linux
Quoted 8 lines · Russell King - ARM Linux
Quoted 2 lines · Mike Rapoport

Hi Russell,
Shell we send it to your patch system?

I've no idea what to do about this. ?I can find no entry in MAINTAINERS for anyone who looks after Marvell Dove, so I assume it's another bit of orphaned code.

Quoted 5 lines

It seems that it started off being looked after by Nico, and now that Nico has moved on to pastures new, it's (presumably) maintainer-less.

Is there someone out there who'd be willing to look after this class of platforms and put their name in MAINTAINERS for it?

yes, I'ld. should I send a patch to update the MAINTAINERS file?

saeed

Quoted 6 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#7 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

Quoted 10 lines · saeed bishara
Quoted 8 lines · Russell King - ARM Linux
Quoted 2 lines · Mike Rapoport

Hi Russell,
Shell we send it to your patch system?

I've no idea what to do about this. ?I can find no entry in MAINTAINERS for anyone who looks after Marvell Dove, so I assume it's another bit of orphaned code.

Quoted 6 lines
Quoted 5 lines

It seems that it started off being looked after by Nico, and now that Nico has moved on to pastures new, it's (presumably) maintainer-less.

Is there someone out there who'd be willing to look after this class of platforms and put their name in MAINTAINERS for it?

yes, I'ld. should I send a patch to update the MAINTAINERS file?

Yes, and does the CM-A510 patch get your ack, and/or are you going to deal with it?

#8 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

Quoted 6 lines
Quoted 3 lines
Quoted 2 lines

Is there someone out there who'd be willing to look after this class of platforms and put their name in MAINTAINERS for it?

yes, I'ld. should I send a ?patch to update the MAINTAINERS file?

Yes, and does the CM-A510 patch get your ack, and/or are you going to deal with it?

I reviewed it, it looks fine to me.
saeed

#9 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

In reply to saeed bishara
Quoted 10 lines · saeed bishara
Quoted 8 lines · Russell King - ARM Linux
Quoted 2 lines · Mike Rapoport

Hi Russell,
Shell we send it to your patch system?

I've no idea what to do about this. I can find no entry in MAINTAINERS for anyone who looks after Marvell Dove, so I assume it's another bit of orphaned code.

Quoted 6 lines
Quoted 5 lines

It seems that it started off being looked after by Nico, and now that Nico has moved on to pastures new, it's (presumably) maintainer-less.

Is there someone out there who'd be willing to look after this class of platforms and put their name in MAINTAINERS for it?

yes, I'ld. should I send a patch to update the MAINTAINERS file?

Saeed,
Please add me as co-maintener.

Quoted 7 lines

saeed

Quoted 6 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Signature · 2 lines
Sincerely yours,
Mike.
#10 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

In reply to Russell King - ARM Linux
Quoted 10 lines · Russell King - ARM Linux
Quoted 2 lines · Mike Rapoport

Hi Russell,
Shell we send it to your patch system?

I've no idea what to do about this. I can find no entry in MAINTAINERS for anyone who looks after Marvell Dove, so I assume it's another bit of orphaned code.

It seems that it started off being looked after by Nico, and now that Nico has moved on to pastures new, it's (presumably) maintainer-less.

I still gather Orion/Kirkwood/Dove patches sent my way and give them a quick sanity check.

Nicolas

#11 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

Quoted 10 lines · Nicolas Pitre
Quoted 8 lines · Russell King - ARM Linux
Quoted 2 lines · Mike Rapoport

Hi Russell,
Shell we send it to your patch system?

I've no idea what to do about this. I can find no entry in MAINTAINERS for anyone who looks after Marvell Dove, so I assume it's another bit of orphaned code.

Quoted 5 lines
Quoted 2 lines

It seems that it started off being looked after by Nico, and now that Nico has moved on to pastures new, it's (presumably) maintainer-less.

I still gather Orion/Kirkwood/Dove patches sent my way and give them a quick sanity check.

Russell, Nicolas,
I'm little bit confused now. Should the Dove patches go to the patch tracking system or through Nicolas orion tree?

Quoted 2 lines

Nicolas

Signature · 2 lines
Sincerely yours,
Mike.
#12 lore raw

PATCH 1/1 dove: add support for CM-A510 machine.

Quoted 14 lines · Mike Rapoport
Quoted 13 lines · Nicolas Pitre
Quoted 10 lines · Russell King - ARM Linux
Quoted 2 lines · Mike Rapoport

Hi Russell,
Shell we send it to your patch system?

I've no idea what to do about this. I can find no entry in MAINTAINERS for anyone who looks after Marvell Dove, so I assume it's another bit of orphaned code.

It seems that it started off being looked after by Nico, and now that Nico has moved on to pastures new, it's (presumably) maintainer-less.

Quoted 6 lines
Quoted 2 lines

I still gather Orion/Kirkwood/Dove patches sent my way and give them a quick sanity check.

Russell, Nicolas,
I'm little bit confused now. Should the Dove patches go to the patch tracking system or through Nicolas orion tree?

I have no idea - I was surprised that you were asking me about Dove stuff as I've never had anything to do with Dove.

Looking at Dove's history, it has been looked after by Nicolas, so it's up to Nicolas to declare what his intention is, and sort out replacement maintainers if he doesn't want to look after it anymore. In any case, the missing MAINTAINERS entry needs fixing to indicate who should accept patches for it, or whether mach-dove is orphaned.