Skip to contentSkip to conversation

Input: acecad - fix a memory leak in usb_acecad_probe error path

PATCH Applied Axel Lin 2 participants 2 messages Nov 11, 2010

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 Input: acecad - fix a memory leak in usb_acecad_probe error path

Add a missing usb_free_urb() in usb_acecad_probe() error path.

---
 drivers/input/tablet/acecad.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/input/tablet/acecad.c +2 -1
index aea9a93..d94f7e9 100644
@@ -229,12 +229,13 @@ static int usb_acecad_probe(struct usb_interface *intf, const struct usb_device_
 
 	err = input_register_device(acecad->input);
 	if (err)
-		goto fail2;
+		goto fail3;
 
 	usb_set_intfdata(intf, acecad);
 
 	return 0;
 
+ fail3:	usb_free_urb(acecad->irq);
  fail2:	usb_free_coherent(dev, 8, acecad->data, acecad->data_dma);
  fail1: input_free_device(input_dev);
 	kfree(acecad);
Signature · 1 line
1.7.2
maintainer Applied
#1 lore raw
Quoted 2 lines · Axel Lin

Add a missing usb_free_urb() in usb_acecad_probe() error path.

Applied, thanks Axel.

Signature · 1 line
Dmitry