Fix Atmel soc audio boards Kconfig dependency
PATCH 1/1 Fix Atmel soc audio boards Kconfig dependency
Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missing clk_set_parent and clk_set_rate when building without AT91_PROGRAMMABLE_CLOCKS.
---
sound/soc/atmel/Kconfig +3 -2
@@ -16,7 +16,8 @@ config SND_ATMEL_SOC_SSC config SND_AT91_SOC_SAM9G20_WM8731 tristate "SoC Audio support for WM8731-based At91sam9g20 evaluation board" - depends on ATMEL_SSC && ARCH_AT91SAM9G20 && SND_ATMEL_SOC + depends on ATMEL_SSC && ARCH_AT91SAM9G20 && SND_ATMEL_SOC && \ + AT91_PROGRAMMABLE_CLOCKS select SND_ATMEL_SOC_SSC select SND_SOC_WM8731 help
@@ -25,7 +26,7 @@ config SND_AT91_SOC_SAM9G20_WM8731 config SND_AT32_SOC_PLAYPAQ tristate "SoC Audio support for PlayPaq with WM8510" - depends on SND_ATMEL_SOC && BOARD_PLAYPAQ + depends on SND_ATMEL_SOC && BOARD_PLAYPAQ && AT91_PROGRAMMABLE_CLOCKS select SND_ATMEL_SOC_SSC select SND_SOC_WM8510 help
Quoted 6 lines · Ryan Mallon
Add
Kconfigdependency onAT91_PROGRAMMABLE_CLOCKSfor the Atmel SoC audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missingclk_set_parentandclk_set_ratewhen building withoutAT91_PROGRAMMABLE_CLOCKS.Signed-off-by Ryan Mallon <[email protected]>
Signature · 3 lines
Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk
Quoted 11 lines · Liam Girdwood
Quoted 7 lines · Ryan Mallon
Add
Kconfigdependency onAT91_PROGRAMMABLE_CLOCKSfor the Atmel SoC audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missingclk_set_parentandclk_set_ratewhen building withoutAT91_PROGRAMMABLE_CLOCKS.Signed-off-by Ryan Mallon <[email protected]>Acked-by Liam Girdwood <[email protected]>
Just realised that the PlayPaq board only appears in the sound/soc/atmel directory. I cannot find a board file for it under either arch/arm/mach-at91 or arch/avr32/. The updated patch below only changes the dependency for the SAM9G20-EK board since I think the PlayPaq is actually AVR32, and therefore should not depend on AT91_PROGRAMMABLE_CLOCKS. This patch replaces my previous one.
---
Add Kconfig dependency on AT91_PROGRAMMABLE_CLOCKS for the Atmel SoC audio SAM9G20-EK board. Fixes link errors on missing clk_set_parent and clk_set_rate when building without AT91_PROGRAMMABLE_CLOCKS.
---
sound/soc/atmel/Kconfig +2 -1
@@ -16,7 +16,8 @@ config SND_ATMEL_SOC_SSC config SND_AT91_SOC_SAM9G20_WM8731 tristate "SoC Audio support for WM8731-based At91sam9g20 evaluation board" - depends on ATMEL_SSC && ARCH_AT91SAM9G20 && SND_ATMEL_SOC + depends on ATMEL_SSC && ARCH_AT91SAM9G20 && SND_ATMEL_SOC && \ + AT91_PROGRAMMABLE_CLOCKS select SND_ATMEL_SOC_SSC select SND_SOC_WM8731 help
Geoffrey Wossum
Acked-byQuoted 9 lines · Ryan Mallon
Quoted 8 lines · Liam Girdwood
Quoted 6 lines · Ryan Mallon
Add
Kconfigdependency onAT91_PROGRAMMABLE_CLOCKSfor the Atmel SoC audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missingclk_set_parentandclk_set_ratewhen building withoutAT91_PROGRAMMABLE_CLOCKS.Signed-off-by Ryan Mallon <[email protected]>
Quoted 8 lines
Quoted 1 line
Acked-by Liam Girdwood <[email protected]>Just realised that the PlayPaq board only appears in the
sound/soc/atmeldirectory. I cannot find a board file for it under eitherarch/arm/mach-at91orarch/avr32/. The updated patch below only changes the dependency for the SAM9G20-EK board since I think the PlayPaq is actually AVR32, and therefore should not depend onAT91_PROGRAMMABLE_CLOCKS. This patch replaces my previous one.
PlayPaq is an AT32AP7000 board, so the new patch is correct.
Quoted 6 lines
---
AddKconfigdependency onAT91_PROGRAMMABLE_CLOCKSfor the Atmel SoC audio SAM9G20-EK board. Fixes link errors on missingclk_set_parentandclk_set_ratewhen building withoutAT91_PROGRAMMABLE_CLOCKS.Signed-off-by Ryan Mallon <[email protected]>
Liam Girdwood
Acked-byQuoted 21 lines · Geoffrey Wossum
Quoted 9 lines · Ryan Mallon
Quoted 8 lines · Liam Girdwood
Quoted 6 lines · Ryan Mallon
Add
Kconfigdependency onAT91_PROGRAMMABLE_CLOCKSfor the Atmel SoC audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missingclk_set_parentandclk_set_ratewhen building withoutAT91_PROGRAMMABLE_CLOCKS.Signed-off-by Ryan Mallon <[email protected]>Quoted 8 lines
Quoted 1 line
Acked-by Liam Girdwood <[email protected]>Just realised that the PlayPaq board only appears in the
sound/soc/atmeldirectory. I cannot find a board file for it under eitherarch/arm/mach-at91orarch/avr32/. The updated patch below only changes the dependency for the SAM9G20-EK board since I think the PlayPaq is actually AVR32, and therefore should not depend onAT91_PROGRAMMABLE_CLOCKS. This patch replaces my previous one.PlayPaq is an AT32AP7000 board, so the new patch is correct.
Quoted 8 lines
Quoted 6 lines
---
AddKconfigdependency onAT91_PROGRAMMABLE_CLOCKSfor the Atmel SoC audio SAM9G20-EK board. Fixes link errors on missingclk_set_parentandclk_set_ratewhen building withoutAT91_PROGRAMMABLE_CLOCKS.Signed-off-by Ryan Mallon <[email protected]>Acked-by Geoffrey Wossum <[email protected]>
Signature · 3 lines
Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk
Mark Brown
AppliedQuoted 6 lines · Ryan Mallon
Add
Kconfigdependency onAT91_PROGRAMMABLE_CLOCKSfor the Atmel SoC audio SAM9G20-EK and PlayPaq boards. Fixes link errors on missingclk_set_parentandclk_set_ratewhen building withoutAT91_PROGRAMMABLE_CLOCKS.Signed-off-by Ryan Mallon <[email protected]>
Applied, thanks.